From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934617AbcLUH7u (ORCPT ); Wed, 21 Dec 2016 02:59:50 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:55548 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934183AbcLUH7s (ORCPT ); Wed, 21 Dec 2016 02:59:48 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee61b-f79d86d00000197e-db-585a36642d14 Content-transfer-encoding: 8BIT Message-id: <585A3664.2080403@samsung.com> Date: Wed, 21 Dec 2016 16:59:32 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Baolin Wang Cc: myungjoo.ham@samsung.com, Chen-Yu Tsai , Kishon , =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= , LKML , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Linaro Kernel Mailman List , Mark Brown , NeilBrown Subject: Re: [PATCH 2/3] extcon: axp288: Set EXTCON_USB when EXTCON_CHG_USB_SDP was set References: <7b9836ce2ca34118a2acd1ea113605a5f13b4439.1482300213.git.baolin.wang@linaro.org> <11fb7adc2982a9134faee9abb1de4dcfb253f2d2.1482300213.git.baolin.wang@linaro.org> <585A2DBB.8070504@samsung.com> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsVy+t9jAd0Us6gIg2NN6hafGq4wW0x9+ITN 4v+j16wWF572sFm8P/SM2WLT42usFpd3zWGz+PTgP7PF7cYVQNbGWIufh84zOXB7bHi0mtVj 06pONo871/aweWxeUu9x+99jZo++LasYPbZfm8fssX7LVRaP4ze2M3l83iQXwBXlZpORmpiS WqSQmpecn5KZl26rFBripmuhpJCXmJtqqxSh6xsSpKRQlphTCuQZGaABB+cA92AlfbsEt4yt pwsKZvNXbOy5z9rAeIK7i5GTQ0LARKLn8EVGCFtM4sK99WxdjFwcQgJLGSXuft/PApLgFRCU +DH5HpDNwcEsIC9x5FI2hKkuMWVKLkT5A0aJ8z/uMkGUa0n8XDeRGcRmEVCV2PS4CWw+G1B8 /4sbbCA2v4CixNUfjxlB5ogKREh0n6gECYsIaEisPbGTBWQms8BPJomTW5+B1QsLREpc/nSI EWLZWyaJs8tXgN3GKRAs8Wr3YZYJjIKzkJw6C+HUWQinLmBkXsUokVqQXFCclJ5rlJdarlec mFtcmpeul5yfu4kRHMvPpHcwHt7lfohRgINRiYfXISMyQog1say4MvcQowQHs5II70btqAgh 3pTEyqrUovz4otKc1OJDjKZAv05klhJNzgemmbySeEMTcxNzYwMLc0tLEyMlcd7G2c/ChQTS E0tSs1NTC1KLYPqYODilGhhnNDzv7nqzZOFlK5O2WuHmb+ybOC//sPGeUKuxRejIfRf2UIOk CzZz80STjH6u9Dx30719sm0Zy6lJa/V2ebJwb5+dMIN1j9aNvMfCt9U+iU9+X+vSH5c9a8uV 1eZ9/fOy3vHvc2RuUi+8uCnl3LLsExHnXLXbBZo9DE0W1M6/zdf5vp7pDqMSS3FGoqEWc1Fx IgDBL8NS+wIAAA== X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2016년 12월 21일 16:55, Baolin Wang wrote: > Hi, > > On 21 December 2016 at 15:22, Chanwoo Choi wrote: >> Hi, >> >> On 2016년 12월 21일 15:10, Baolin Wang wrote: >>> According to the documentation, we should set the EXTCON_USB when >>> one SDP charger connector was reported. >>> >>> Signed-off-by: Baolin Wang >>> --- >>> drivers/extcon/extcon-axp288.c | 7 ++++++- >>> 1 file changed, 6 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c >>> index 42f41e8..4490726 100644 >>> --- a/drivers/extcon/extcon-axp288.c >>> +++ b/drivers/extcon/extcon-axp288.c >>> @@ -102,6 +102,7 @@ enum axp288_extcon_irq { >>> }; >>> >>> static const unsigned int axp288_extcon_cables[] = { >>> + EXTCON_USB, >>> EXTCON_CHG_USB_SDP, >>> EXTCON_CHG_USB_CDP, >>> EXTCON_CHG_USB_DCP, >>> @@ -225,8 +226,12 @@ static int axp288_handle_chrg_det_event(struct axp288_extcon_info *info) >>> vbus_attach ? USB_EVENT_VBUS : USB_EVENT_NONE, NULL); >>> } >>> >>> - if (notify_charger) >>> + if (notify_charger) { >>> extcon_set_state_sync(info->edev, cable, vbus_attach); >>> + if (cable == EXTCON_CHG_USB_SDP) >>> + extcon_set_state_sync(info->edev, EXTCON_USB, >>> + vbus_attach); >>> + } >>> >>> /* Clear the flags on disconnect event */ >>> if (!vbus_attach) >>> >> >> The extcon-axp288.c driver has some patches on extcon-next[1] branch. >> [1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/log/?h=extcon-next >> >> I rework your patch on extcon-next branch as following: >> If you ok, I'll merge it for v4.11. > > It is okay for me. Thanks. Applied it. Thanks. [snip] -- Regards, Chanwoo Choi