From: <Dharma.B@microchip.com>
To: <robh@kernel.org>
Cc: <Conor.Dooley@microchip.com>, <sam@ravnborg.org>,
<bbrezillon@kernel.org>, <maarten.lankhorst@linux.intel.com>,
<mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>,
<daniel@ffwll.ch>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>, <claudiu.beznea@tuxon.dev>,
<dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <lee@kernel.org>,
<thierry.reding@gmail.com>, <u.kleine-koenig@pengutronix.de>,
<linux-pwm@vger.kernel.org>, <Linux4Microchip@microchip.com>
Subject: Re: [PATCH v3 2/3] dt-bindings: atmel,hlcdc: convert pwm bindings to json-schema
Date: Wed, 24 Jan 2024 09:58:46 +0000 [thread overview]
Message-ID: <58641356-8039-47c4-9e5c-36c6c76877cd@microchip.com> (raw)
In-Reply-To: <20240119194534.GA938671-robh@kernel.org>
Hi Rob,
On 20/01/24 1:15 am, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Thu, Jan 18, 2024 at 02:56:11PM +0530, Dharma Balasubiramani wrote:
>> Convert device tree bindings for Atmel's HLCDC PWM controller to YAML
>> format.
>>
>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>> ---
>> changelog
>> v2 -> v3
>> - Remove '|' in description, as there is no formatting to preserve.
>> - Delete the description for pwm-cells.
>> - Drop the label for pwm node as it not used.
>> v1 -> v2
>> - Remove the explicit copyrights.
>> - Modify title (not include words like binding/driver).
>> - Modify description actually describing the hardware and not the driver.
>> - Remove pinctrl properties which aren't required.
>> - Drop parent node and it's other sub-device node which are not related here.
>> ---
>> .../bindings/pwm/atmel,hlcdc-pwm.yaml | 44 +++++++++++++++++++
>> .../bindings/pwm/atmel-hlcdc-pwm.txt | 29 ------------
>> 2 files changed, 44 insertions(+), 29 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml
>> delete mode 100644 Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml b/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml
>> new file mode 100644
>> index 000000000000..4f4cc21fe4f7
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml
>> @@ -0,0 +1,44 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pwm/atmel,hlcdc-pwm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Atmel's HLCDC's PWM controller
>> +
>> +maintainers:
>> + - Nicolas Ferre <nicolas.ferre@microchip.com>
>> + - Alexandre Belloni <alexandre.belloni@bootlin.com>
>> + - Claudiu Beznea <claudiu.beznea@tuxon.dev>
>> +
>> +description:
>> + The LCDC integrates a Pulse Width Modulation (PWM) Controller. This block
>> + generates the LCD contrast control signal (LCD_PWM) that controls the
>> + display's contrast by software. LCDC_PWM is an 8-bit PWM signal that can be
>> + converted to an analog voltage with a simple passive filter. LCD display
>> + panels have different backlight specifications in terms of minimum/maximum
>> + values for PWM frequency. If the LCDC PWM frequency range does not match the
>> + LCD display panel, it is possible to use the standalone PWM Controller to
>> + drive the backlight.
>> +
>> +properties:
>> + compatible:
>> + const: atmel,hlcdc-pwm
>> +
>> + "#pwm-cells":
>> + const: 3
>> +
>> +required:
>> + - compatible
>> + - "#pwm-cells"
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + pwm {
>> + compatible = "atmel,hlcdc-pwm";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_lcd_pwm>;
>> + #pwm-cells = <3>;
>> + };
>
> Move the example to the MFD schema. Or just drop if already there.
As Sam suggested I will send v4 series with this binding as it is and
will send the clean up patch later.
--
Thanks,
Dharma B.
>
> Rob
next prev parent reply other threads:[~2024-01-24 9:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 9:26 [PATCH v3 0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema Dharma Balasubiramani
2024-01-18 9:26 ` [PATCH v3 1/3] dt-bindings: display: convert Atmel's HLCDC to DT schema Dharma Balasubiramani
2024-01-18 15:31 ` Conor Dooley
2024-01-19 2:51 ` Dharma.B
2024-01-18 9:26 ` [PATCH v3 2/3] dt-bindings: atmel,hlcdc: convert pwm bindings to json-schema Dharma Balasubiramani
2024-01-18 10:16 ` Uwe Kleine-König
2024-01-20 10:03 ` Uwe Kleine-König
2024-01-19 19:45 ` Rob Herring
2024-01-24 9:58 ` Dharma.B [this message]
2024-01-18 9:26 ` [PATCH v3 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format Dharma Balasubiramani
2024-01-18 15:40 ` Conor Dooley
2024-01-19 3:32 ` Dharma.B
2024-01-19 12:03 ` Conor Dooley
2024-01-22 3:38 ` Dharma.B
2024-01-22 9:16 ` Conor Dooley
2024-01-24 5:18 ` Dharma.B
2024-01-24 16:39 ` Conor Dooley
2024-01-25 6:47 ` Dharma.B
2024-01-25 8:27 ` Conor Dooley
2024-01-26 14:22 ` Dharma.B
2024-01-26 15:33 ` Conor Dooley
2024-01-29 3:41 ` Dharma.B
2024-01-29 17:14 ` Conor Dooley
2024-01-18 19:30 ` [PATCH v3 0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema Sam Ravnborg
2024-01-19 8:41 ` Dharma.B
2024-01-19 21:33 ` Sam Ravnborg
2024-01-19 19:51 ` Rob Herring
2024-01-20 13:23 ` Sam Ravnborg
2024-01-22 3:52 ` Dharma.B
2024-01-22 16:02 ` Sam Ravnborg
2024-01-22 16:04 ` Sam Ravnborg
2024-01-24 8:55 ` Dharma.B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58641356-8039-47c4-9e5c-36c6c76877cd@microchip.com \
--to=dharma.b@microchip.com \
--cc=Conor.Dooley@microchip.com \
--cc=Linux4Microchip@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=airlied@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).