linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	broonie@kernel.org, vkoul@kernel.org
Cc: robh@kernel.org, devicetree@vger.kernel.org,
	yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/5] soundwire: add static port mapping support
Date: Fri, 12 Mar 2021 10:56:00 -0600	[thread overview]
Message-ID: <5869594c-dfd6-c49d-0168-1993cdeb5a43@linux.intel.com> (raw)
In-Reply-To: <20210312113929.17512-2-srinivas.kandagatla@linaro.org>



On 3/12/21 5:39 AM, Srinivas Kandagatla wrote:
> Some of the SoundWire device ports are statically mapped to Controller
> ports during design, however there is no way to expose this information
> to the controller. Controllers like Qualcomm ones use this info to setup
> static bandwidth parameters for those ports.
> 
> A generic port allocation is not possible in this cases!
> So this patch adds a new member m_port_map to struct sdw_slave to expose
> this static map.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>   include/linux/soundwire/sdw.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
> index d08039d65825..b032d6ac0b39 100644
> --- a/include/linux/soundwire/sdw.h
> +++ b/include/linux/soundwire/sdw.h
> @@ -614,6 +614,7 @@ struct sdw_slave_ops {
>    * @debugfs: Slave debugfs
>    * @node: node for bus list
>    * @port_ready: Port ready completion flag for each Slave port
> + * @m_port_map: static Master port map for each Slave port0 to port14

did you mean port1..port14?

DP0 is a special case that's not supposed to be used for audio transport 
but rather extended control and command?

>    * @dev_num: Current Device Number, values can be 0 or dev_num_sticky
>    * @dev_num_sticky: one-time static Device Number assigned by Bus
>    * @probed: boolean tracking driver state
> @@ -645,6 +646,7 @@ struct sdw_slave {
>   #endif
>   	struct list_head node;
>   	struct completion port_ready[SDW_MAX_PORTS];
> +	unsigned int m_port_map[SDW_MAX_PORTS];
>   	enum sdw_clk_stop_mode curr_clk_stop_mode;
>   	u16 dev_num;
>   	u16 dev_num_sticky;
> 

  reply	other threads:[~2021-03-12 16:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12 11:39 [PATCH v3 0/5] soundwire: add static port map support Srinivas Kandagatla
2021-03-12 11:39 ` [PATCH v3 1/5] soundwire: add static port mapping support Srinivas Kandagatla
2021-03-12 16:56   ` Pierre-Louis Bossart [this message]
2021-03-15  9:54     ` Srinivas Kandagatla
2021-03-12 11:39 ` [PATCH v3 2/5] soundwire: qcom: update port map allocation bit mask Srinivas Kandagatla
2021-03-12 11:39 ` [PATCH v3 3/5] soundwire: qcom: add static port map support Srinivas Kandagatla
2021-03-12 11:39 ` [PATCH v3 4/5] ASoC: dt-bindings: wsa881x: add bindings for port mapping Srinivas Kandagatla
2021-03-12 11:39 ` [PATCH v3 5/5] ASoC: codecs: wsa881x: add static port map support Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5869594c-dfd6-c49d-0168-1993cdeb5a43@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sanyog.r.kale@intel.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).