[PATCH 1/2] soc: ti: knav_dma: fix typos in trace message

[PATCH 1/2] soc: ti: knav_dma: fix typos in trace message

[Murali Karicheri]

This patch fixes some typos in the trace message

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 drivers/soc/ti/knav_dma.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c
index 1a7b5ca..ecebe2e 100644
--- a/drivers/soc/ti/knav_dma.c
+++ b/drivers/soc/ti/knav_dma.c
@@ -395,7 +395,7 @@ static int of_channel_match_helper(struct device_node *np, const char *name,
 
 	if (of_parse_phandle_with_fixed_args(np, "ti,navigator-dmas",
 					1, index, &args)) {
-		dev_err(kdev->dev, "Missing the pahndle args name %s\n", name);
+		dev_err(kdev->dev, "Missing the phandle args name %s\n", name);
 		return -ENODEV;
 	}
 
@@ -436,7 +436,7 @@ void *knav_dma_open_channel(struct device *dev, const char *name,
 	}
 
 	dev_dbg(kdev->dev, "initializing %s channel %d from DMA %s\n",
-		  config->direction == DMA_MEM_TO_DEV   ? "transmit" :
+		  config->direction == DMA_MEM_TO_DEV ? "transmit" :
 		  config->direction == DMA_DEV_TO_MEM ? "receive"  :
 		  "unknown", chan_num, instance);
 
-- 
1.9.1

[PATCH 2/2] soc: ti: knav: cleanup includes and sort header files

[Murali Karicheri]

This patch cleanup the code to remove unnecessary header files and
also sort the header files.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Signed-off-by: WingMan Kwok <w-kwok2@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 drivers/soc/ti/knav_qmss_acc.c   | 15 +++------------
 drivers/soc/ti/knav_qmss_queue.c | 25 ++++++++-----------------
 2 files changed, 11 insertions(+), 29 deletions(-)

diff --git a/drivers/soc/ti/knav_qmss_acc.c b/drivers/soc/ti/knav_qmss_acc.c
index 0612eba..3d7225f 100644
--- a/drivers/soc/ti/knav_qmss_acc.c
+++ b/drivers/soc/ti/knav_qmss_acc.c
@@ -16,21 +16,12 @@
  * General Public License for more details.
  */
 
-#include <linux/kernel.h>
-#include <linux/module.h>
-#include <linux/device.h>
+#include <linux/dma-mapping.h>
 #include <linux/io.h>
 #include <linux/interrupt.h>
-#include <linux/bitops.h>
-#include <linux/slab.h>
-#include <linux/spinlock.h>
-#include <linux/soc/ti/knav_qmss.h>
-#include <linux/platform_device.h>
-#include <linux/dma-mapping.h>
-#include <linux/of.h>
-#include <linux/of_device.h>
+#include <linux/module.h>
 #include <linux/of_address.h>
-#include <linux/firmware.h>
+#include <linux/soc/ti/knav_qmss.h>
 
 #include "knav_qmss.h"
 
diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
index eacad57..279e7c5 100644
--- a/drivers/soc/ti/knav_qmss_queue.c
+++ b/drivers/soc/ti/knav_qmss_queue.c
@@ -16,26 +16,17 @@
  * General Public License for more details.
  */
 
-#include <linux/kernel.h>
-#include <linux/module.h>
-#include <linux/device.h>
-#include <linux/clk.h>
-#include <linux/io.h>
-#include <linux/interrupt.h>
-#include <linux/bitops.h>
-#include <linux/slab.h>
-#include <linux/spinlock.h>
-#include <linux/platform_device.h>
+#include <linux/debugfs.h>
 #include <linux/dma-mapping.h>
-#include <linux/of.h>
-#include <linux/of_irq.h>
-#include <linux/of_device.h>
+#include <linux/firmware.h>
+#include <linux/interrupt.h>
+#include <linux/io.h>
+#include <linux/module.h>
 #include <linux/of_address.h>
+#include <linux/of_device.h>
+#include <linux/of_irq.h>
 #include <linux/pm_runtime.h>
-#include <linux/firmware.h>
-#include <linux/debugfs.h>
-#include <linux/seq_file.h>
-#include <linux/string.h>
+#include <linux/slab.h>
 #include <linux/soc/ti/knav_qmss.h>
 
 #include "knav_qmss.h"
-- 
1.9.1

Re: [PATCH 1/2] soc: ti: knav_dma: fix typos in trace message

[Santosh Shilimkar]

On 12/20/2016 2:24 PM, Murali Karicheri wrote:
> This patch fixes some typos in the trace message
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---
Patch 1 and 2 looks fine. Will pick them for next
merge window. Thanks !!

Regards,
Santosh

Re: [PATCH 1/2] soc: ti: knav_dma: fix typos in trace message

[Murali Karicheri]

On 12/20/2016 08:01 PM, Santosh Shilimkar wrote:
> On 12/20/2016 2:24 PM, Murali Karicheri wrote:
>> This patch fixes some typos in the trace message
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
>> ---
> Patch 1 and 2 looks fine. Will pick them for next
> merge window. Thanks !!
> 
> Regards,
> Santosh
> 
Santosh,

Could you send this to linux-next please so that I can
cherry-pick them for our internal release?

-- 
Murali Karicheri
Linux Kernel, Keystone

Re: [PATCH 1/2] soc: ti: knav_dma: fix typos in trace message

[Santosh Shilimkar]

On 1/5/2017 11:08 AM, Murali Karicheri wrote:
> On 12/20/2016 08:01 PM, Santosh Shilimkar wrote:
>> On 12/20/2016 2:24 PM, Murali Karicheri wrote:
>>> This patch fixes some typos in the trace message
>>>
>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
>>> ---
>> Patch 1 and 2 looks fine. Will pick them for next
>> merge window. Thanks !!
>>
>> Regards,
>> Santosh
>>
> Santosh,
>
> Could you send this to linux-next please so that I can
> cherry-pick them for our internal release?
>
Am collecting few more patches Murali. Hopefully
I will be able to push that to linux-next next week.

Regards,
Santosh