From: Frank Rowand <frowand.list@gmail.com>
To: YiPing Xu <xuyiping@hisilicon.com>,
pantelis.antoniou@konsulko.com, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: remove redundant memset in overlay
Date: Mon, 9 Jan 2017 10:50:43 -0800 [thread overview]
Message-ID: <5873DB83.4010606@gmail.com> (raw)
In-Reply-To: <1483787067-108430-1-git-send-email-xuyiping@hisilicon.com>
Hi Rob,
On 01/07/17 03:04, YiPing Xu wrote:
> From: XuYing <xuyiping@hisilicon.com>
>
> memset in of_build_overlay_info is redundant, the ovinfo has been
> zeroed in of_fill_overlay_info when error.
>
> Signed-off-by: YiPing Xu <xuyiping@hisilicon.com>
> ---
> drivers/of/overlay.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
> index 0d4cda7..4b1b6b3 100644
> --- a/drivers/of/overlay.c
> +++ b/drivers/of/overlay.c
> @@ -314,7 +314,6 @@ static int of_build_overlay_info(struct of_overlay *ov,
>
> cnt = 0;
> for_each_child_of_node(tree, node) {
> - memset(&ovinfo[cnt], 0, sizeof(*ovinfo));
> err = of_fill_overlay_info(ov, node, &ovinfo[cnt]);
> if (err == 0)
> cnt++;
>
Reviewed-by: Frank Rowand <frank.rowand@am.sony.com>
I am in the midst of a cleanup of overlay.c. I can add this patch to
my series if you would prefer. And of course if I get delayed with
the series I would expect you to apply this one without my series if
you desire.
-Frank
next prev parent reply other threads:[~2017-01-09 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 11:04 [PATCH] of: remove redundant memset in overlay YiPing Xu
2017-01-09 18:50 ` Frank Rowand [this message]
2017-01-10 5:35 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5873DB83.4010606@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
--cc=xuyiping@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).