From: Rajendra Nayak <rnayak@codeaurora.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Sricharan R <sricharan@codeaurora.org>,
sboyd@codeaurora.org, mturquette@baylibre.com,
linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/2] clk: qcom: gdsc: Add support for gdscs with HW control
Date: Tue, 10 Jan 2017 10:18:27 +0530 [thread overview]
Message-ID: <5874679B.8010102@codeaurora.org> (raw)
In-Reply-To: <a0fc11d9-49de-33d1-0cea-bed4e6b0765c@linaro.org>
[]..
>> static int gdsc_toggle_logic(struct gdsc *sc, bool en)
>> {
>> int ret;
>> @@ -164,16 +171,28 @@ static int gdsc_enable(struct generic_pm_domain *domain)
>> */
>> udelay(1);
>>
>> + /* Turn on HW trigger mode if supported */
>> + if (sc->flags & HW_CTRL)
>> + return gdsc_hwctrl(sc, true);
>> +
>> return 0;
>> }
>>
>> static int gdsc_disable(struct generic_pm_domain *domain)
>> {
>> struct gdsc *sc = domain_to_gdsc(domain);
>> + int ret;
>>
>> if (sc->pwrsts == PWRSTS_ON)
>> return gdsc_assert_reset(sc);
>>
>> + /* Turn off HW trigger mode if supported */
>> + if (sc->flags & HW_CTRL) {
>> + ret = gdsc_hwctrl(sc, false);
>
> Looking in the downstream implementation the disabling of the hw control
> bit shouldn't be enough.
>
> After disabling hw control bit we must have a 1us delay and polling for
> enabled PWR_ON bit with timeout of 100us, only then we should continue
> with disabling the GDSC in software controlled mode.
Stan, thats right. I will send a patch to fix this up right-away.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2017-01-10 4:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 12:28 [PATCH V2 0/2] clk: qcom: gdsc: Add support for gdscs with HW control Sricharan R
2016-11-18 12:28 ` [PATCH V2 1/2] " Sricharan R
2016-11-24 0:41 ` Stephen Boyd
2017-01-09 9:45 ` Stanimir Varbanov
2017-01-10 4:48 ` Rajendra Nayak [this message]
2016-11-18 12:28 ` [PATCH V2 2/2] clk: qcom: Put venus core0/1 gdscs to hw control mode Sricharan R
2016-11-18 14:49 ` [PATCH V2 0/2] clk: qcom: gdsc: Add support for gdscs with HW control Stanimir Varbanov
2016-11-18 18:10 ` Sricharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5874679B.8010102@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=sricharan@codeaurora.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).