From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935197AbdAKBEt (ORCPT ); Tue, 10 Jan 2017 20:04:49 -0500 Received: from regular1.263xmail.com ([211.150.99.138]:51108 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932324AbdAKBEp (ORCPT ); Tue, 10 Jan 2017 20:04:45 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: zhengxing@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zhengxing@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v4 1/2] arm64: dts: rockchip: add "rockchip, grf" property for RK3399 PMUCRU/CRU To: Doug Anderson References: <1484028930-20305-1-git-send-email-zhengxing@rock-chips.com> <1484028930-20305-2-git-send-email-zhengxing@rock-chips.com> Cc: =?UTF-8?Q?Heiko_St=c3=bcbner?= , "open list:ARM/Rockchip SoC..." , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Caesar Wang , Shawn Lin , Brian Norris , Jianqun Xu , Elaine Zhang , David Wu , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" From: Xing Zheng Message-ID: <58758498.40309@rock-chips.com> Date: Wed, 11 Jan 2017 09:04:24 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Doug, On 2017年01月11日 02:45, Doug Anderson wrote: > Hi, > > On Mon, Jan 9, 2017 at 10:15 PM, Xing Zheng wrote: >> The structure rockchip_clk_provider needs to refer the GRF regmap >> in somewhere, if the CRU node has not "rockchip,grf" property, >> calling syscon_regmap_lookup_by_phandle will return an invalid GRF >> regmap, and the MUXGRF type clock will be not supported. >> >> Therefore, we need to add them. >> >> Signed-off-by: Xing Zheng >> --- >> >> Changes in v4: >> - separte the binding patch >> >> Changes in v3: >> - add optional roperty rockchip,grf in rockchip,rk3399-cru.txt >> >> Changes in v2: >> - referring pmugrf for PMUGRU >> - fix the typo "invaild" in COMMIT message >> >> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 ++ >> 1 file changed, 2 insertions(+) > This seems fine to me, so: > > Reviewed-by: Douglas Anderson > > ...but I will say that before you actually add any real "MUXGRF" > clocks on rk3399 you _might_ need to rework the code to make things > truly "optional". If it turns out that any existing clocks that > already exist today already go through one of these muxes in the GRF > and we've always been assuming one setting of the mux, we'll need to > make sure we keep assuming that setting of the mux even if the "grf" > isn't specified. > > As I understand it, your motivation for this patch is to eventually be > able to model the EDP reference clock which can either be xin24 or > "edp osc". Presumably the eDP "reference clock" isn't related to any > of the pre-existing eDP clocks so that one should be safe. Hmm... I had intended to use this patch for EDP reference clock, but we don't need to change the parent clock (see the BUG: 61664). I just woud like to add this patch to avoid getting some unavailable MUXGRF clock and need to debug it again, if we support it one day in future. Thanks. -- - Xing Zheng