From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762725AbdAKJJ7 (ORCPT ); Wed, 11 Jan 2017 04:09:59 -0500 Received: from www62.your-server.de ([213.133.104.62]:36944 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756359AbdAKJJ5 (ORCPT ); Wed, 11 Jan 2017 04:09:57 -0500 Message-ID: <5875F65A.4010904@iogearbox.net> Date: Wed, 11 Jan 2017 10:09:46 +0100 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Andy Lutomirski CC: Andy Lutomirski , Netdev , LKML , Linux Crypto Mailing List , "Jason A. Donenfeld" , Hannes Frederic Sowa , Alexei Starovoitov , Eric Dumazet , Eric Biggers , Tom Herbert , "David S. Miller" , Alexei Starovoitov Subject: Re: [PATCH v2 7/8] net: Rename TCA*BPF_DIGEST to ..._SHA256 References: <58758169.2020408@iogearbox.net> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On 01/11/2017 04:11 AM, Andy Lutomirski wrote: > On Tue, Jan 10, 2017 at 4:50 PM, Daniel Borkmann wrote: >> On 01/11/2017 12:24 AM, Andy Lutomirski wrote: >>> >>> This makes it easier to add another digest algorithm down the road if >>> needed. It also serves to force any programs that might have been >>> written against a kernel that had the old field name to notice the >>> change and make any necessary changes. >>> >>> This shouldn't violate any stable API policies, as no released kernel >>> has ever had TCA*BPF_DIGEST. >> >> Imho, this and patch 6/8 is not really needed. Should there ever >> another digest alg be used (doubt it), then you'd need a new nl >> attribute and fdinfo line anyway to keep existing stuff intact. >> Nobody made the claim that you can just change this underneath >> and not respecting abi for existing applications when I read from >> above that such apps now will get "forced" to notice a change. > > Fair enough. I was more concerned about prerelease iproute2 versions, > but maybe that's a nonissue. I'll drop these two patches. Ok. Sleeping over this a bit, how about a general rename into "prog_tag" for fdinfo and TCA_BPF_TAG resp. TCA_ACT_BPF_TAG for the netlink attributes, fwiw, it might reduce any assumptions on this being made? If this would be preferable, I could cook that patch against -net for renaming it? Thanks, Daniel