* [PATCH] staging: r8188eu: remove write-only variable bLCKInProgress
@ 2021-09-11 13:23 Martin Kaiser
2021-09-11 13:32 ` Michael Straube
0 siblings, 1 reply; 2+ messages in thread
From: Martin Kaiser @ 2021-09-11 13:23 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, linux-staging,
linux-kernel, Martin Kaiser
bLCKInProgress in struct odm_rf_cal is never read. Remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 4 ----
drivers/staging/r8188eu/include/odm.h | 1 -
2 files changed, 5 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
index 6e0abaf58791..d9693c8014ce 100644
--- a/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
+++ b/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
@@ -1212,16 +1212,12 @@ void PHY_LCCalibrate_8188E(struct adapter *adapt)
timecount += 50;
}
- dm_odm->RFCalibrateInfo.bLCKInProgress = true;
-
if (dm_odm->RFType == ODM_2T2R) {
phy_LCCalibrate_8188E(adapt, true);
} else {
/* For 88C 1T1R */
phy_LCCalibrate_8188E(adapt, false);
}
-
- dm_odm->RFCalibrateInfo.bLCKInProgress = false;
}
static void phy_setrfpathswitch_8188e(struct adapter *adapt, bool main, bool is2t)
diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188eu/include/odm.h
index 7c8f082930dd..cda8b3ffe0be 100644
--- a/drivers/staging/r8188eu/include/odm.h
+++ b/drivers/staging/r8188eu/include/odm.h
@@ -679,7 +679,6 @@ struct odm_rf_cal {
u32 Reg864;
bool bIQKInitialized;
- bool bLCKInProgress;
bool bAntennaDetected;
u32 ADDA_backup[IQK_ADDA_REG_NUM];
u32 IQK_MAC_backup[IQK_MAC_REG_NUM];
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: r8188eu: remove write-only variable bLCKInProgress
2021-09-11 13:23 [PATCH] staging: r8188eu: remove write-only variable bLCKInProgress Martin Kaiser
@ 2021-09-11 13:32 ` Michael Straube
0 siblings, 0 replies; 2+ messages in thread
From: Michael Straube @ 2021-09-11 13:32 UTC (permalink / raw)
To: Martin Kaiser, Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, linux-staging, linux-kernel
On 9/11/21 15:23, Martin Kaiser wrote:
> bLCKInProgress in struct odm_rf_cal is never read. Remove it.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 4 ----
> drivers/staging/r8188eu/include/odm.h | 1 -
> 2 files changed, 5 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
> index 6e0abaf58791..d9693c8014ce 100644
> --- a/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
> +++ b/drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
> @@ -1212,16 +1212,12 @@ void PHY_LCCalibrate_8188E(struct adapter *adapt)
> timecount += 50;
> }
>
> - dm_odm->RFCalibrateInfo.bLCKInProgress = true;
> -
> if (dm_odm->RFType == ODM_2T2R) {
> phy_LCCalibrate_8188E(adapt, true);
> } else {
> /* For 88C 1T1R */
> phy_LCCalibrate_8188E(adapt, false);
> }
> -
> - dm_odm->RFCalibrateInfo.bLCKInProgress = false;
> }
>
> static void phy_setrfpathswitch_8188e(struct adapter *adapt, bool main, bool is2t)
> diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188eu/include/odm.h
> index 7c8f082930dd..cda8b3ffe0be 100644
> --- a/drivers/staging/r8188eu/include/odm.h
> +++ b/drivers/staging/r8188eu/include/odm.h
> @@ -679,7 +679,6 @@ struct odm_rf_cal {
> u32 Reg864;
>
> bool bIQKInitialized;
> - bool bLCKInProgress;
> bool bAntennaDetected;
> u32 ADDA_backup[IQK_ADDA_REG_NUM];
> u32 IQK_MAC_backup[IQK_MAC_REG_NUM];
>
Compiles and looks good to me, thanks.
Acked-by: Michael Straube <straube.linux@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-11 13:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-11 13:23 [PATCH] staging: r8188eu: remove write-only variable bLCKInProgress Martin Kaiser
2021-09-11 13:32 ` Michael Straube
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).