From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752020AbdARCUS (ORCPT <rfc822;w@1wt.eu>);
        Tue, 17 Jan 2017 21:20:18 -0500
Received: from szxga03-in.huawei.com ([119.145.14.66]:16383 "EHLO
        szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751205AbdARCUR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Jan 2017 21:20:17 -0500
Message-ID: <587ED0CB.6060109@huawei.com>
Date: Wed, 18 Jan 2017 10:19:55 +0800
From: Xishi Qiu <qiuxishi@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: Paolo Bonzini <pbonzini@redhat.com>
CC: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        the arch/x86 maintainers <x86@kernel.org>, <wanpeng.li@hotmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        <hidehiro.kawai.ez@hitachi.com>, LKML <linux-kernel@vger.kernel.org>,
        Fengtiantian <fengtiantian@huawei.com>, Xiexiuqi <xiexiuqi@huawei.com>
Subject: Re: [PATCH V3] x86: call smp vmxoff in smp stop
References: <586CCA5A.8050607@huawei.com> <586DA529.1040803@huawei.com> <58798201.2@huawei.com> <9b0db9ff-19aa-5687-dac0-dc2fa2337cc0@redhat.com>
In-Reply-To: <9b0db9ff-19aa-5687-dac0-dc2fa2337cc0@redhat.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.25.179]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2017/1/17 23:18, Paolo Bonzini wrote:

> 
> 
> On 14/01/2017 02:42, Xishi Qiu wrote:
>> From: Tiantian Feng <fengtiantian@huawei.com>
>>
>> We need to disable VMX on all CPUs before stop cpu when OS panic,
>> otherwisewe risk hanging up the machine, because the CPU ignore INIT
>> signals when VMX is enabled. In kernel mainline this issue existence.
>>
>> Signed-off-by: Tiantian Feng <fengtiantian@huawei.com>
> 
> Xishi,
> 
> it's still missing your Signed-off-by.
> 

Hi Paolo,

This patch is from fengtiantian, and I just send it for him,
so still should add my SOB?

Thanks,
Xishi Qiu

> Paolo
> 
>> ---
>>  arch/x86/kernel/smp.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c
>> index 68f8cc2..b574d55 100644
>> --- a/arch/x86/kernel/smp.c
>> +++ b/arch/x86/kernel/smp.c
>> @@ -33,6 +33,7 @@
>>  #include <asm/mce.h>
>>  #include <asm/trace/irq_vectors.h>
>>  #include <asm/kexec.h>
>> +#include <asm/virtext.h>
>>  
>>  /*
>>   *	Some notes on x86 processor bugs affecting SMP operation:
>> @@ -162,6 +163,7 @@ static int smp_stop_nmi_callback(unsigned int val, struct pt_regs *regs)
>>  	if (raw_smp_processor_id() == atomic_read(&stopping_cpu))
>>  		return NMI_HANDLED;
>>  
>> +	cpu_emergency_vmxoff();
>>  	stop_this_cpu(NULL);
>>  
>>  	return NMI_HANDLED;
>> @@ -174,6 +176,7 @@ static int smp_stop_nmi_callback(unsigned int val, struct pt_regs *regs)
>>  asmlinkage __visible void smp_reboot_interrupt(void)
>>  {
>>  	ipi_entering_ack_irq();
>> +	cpu_emergency_vmxoff();
>>  	stop_this_cpu(NULL);
>>  	irq_exit();
>>  }
>>
> 
> .
>