From: Chanwoo Choi <cw00.choi@samsung.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: myungjoo.ham@samsung.com, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH v2] extcon: arizona: Wait for any running HPDETs to complete on jack removal
Date: Wed, 25 Jan 2017 18:48:06 +0900 [thread overview]
Message-ID: <58887456.1060904@samsung.com> (raw)
In-Reply-To: <1485336846-6440-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
Hi,
I modified some minor issue and added my comment on below.
After modified them by myself, Applied it.
On 2017년 01월 25일 18:34, Charles Keepax wrote:
> As the HPDET can't be aborted mid way through we should not allow any new
> insertion to be processed until the previous HPDET has finished. It is very
> unlikely but with low enough debounce settings you could start a new HPDET
> before the old one has completed, which results in an erroneous reading.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>
> Changes since v1:
> - Added defines for the count and delay
> - Added a comment to explain why we call arizona_hpdet_wait
>
> Thanks,
> Charles
>
> drivers/extcon/extcon-arizona.c | 45 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index ed78b7c..df98d84 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -1049,6 +1049,42 @@ static void arizona_hpdet_work(struct work_struct *work)
> mutex_unlock(&info->lock);
> }
>
> +#define ARIZONA_HPDET_WAIT_COUNT 15
> +#define ARIZONA_HPDET_WAIT_DELAY_MS 20
Move these definitions on the top.
> +
> +static int arizona_hpdet_wait(struct arizona_extcon_info *info)
> +{
> + struct arizona *arizona = info->arizona;
> + unsigned int val;
> + int i, ret;
> +
> + for (i = 0; i < ARIZONA_HPDET_WAIT_COUNT; i++) {
> + ret = regmap_read(arizona->regmap, ARIZONA_HEADPHONE_DETECT_2,
> + &val);
Remove the space indentation. I prefer to use only tab indentation.
> + if (ret) {
> + dev_err(arizona->dev,
> + "Failed to read HPDET state: %d\n", ret);
> + return ret;
> + }
> +
> + switch (info->hpdet_ip_version) {
> + case 0:
> + if (val & ARIZONA_HP_DONE)
> + return 0;
> + break;
> + default:
> + if (val & ARIZONA_HP_DONE_B)
> + return 0;
> + break;
> + }
> +
> + msleep(ARIZONA_HPDET_WAIT_DELAY_MS);
> + }
> +
> + dev_err(arizona->dev, "HPDET did not appear to complete\n");
Use dev_warn() instead of dev_err() because this message just
warn the current status.
> + return -ETIMEDOUT;
> +}
> +
> static irqreturn_t arizona_jackdet(int irq, void *data)
> {
> struct arizona_extcon_info *info = data;
> @@ -1155,6 +1191,15 @@ static irqreturn_t arizona_jackdet(int irq, void *data)
> "Removal report failed: %d\n", ret);
> }
>
> + /*
> + * If the jack was removed during a headphone detection we
> + * need to wait for the headphone detection to finish, as
> + * it can not be aborted. We don't want to be able to start
> + * a new headphone detection from a fresh insert until this
> + * one is finished.
> + */
> + arizona_hpdet_wait(info);
> +
> regmap_update_bits(arizona->regmap,
> ARIZONA_JACK_DETECT_DEBOUNCE,
> ARIZONA_MICD_CLAMP_DB | ARIZONA_JD1_DB,
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2017-01-25 9:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170125093332epcas2p27a231cb2c921811302a8e2df9c23f251@epcas2p2.samsung.com>
2017-01-25 9:34 ` [PATCH v2] extcon: arizona: Wait for any running HPDETs to complete on jack removal Charles Keepax
2017-01-25 9:35 ` Chanwoo Choi
2017-01-25 9:41 ` Charles Keepax
2017-01-25 9:48 ` Chanwoo Choi [this message]
2017-01-25 10:07 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58887456.1060904@samsung.com \
--to=cw00.choi@samsung.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).