From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752633AbdAYXr1 (ORCPT ); Wed, 25 Jan 2017 18:47:27 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:33557 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752587AbdAYXrY (ORCPT ); Wed, 25 Jan 2017 18:47:24 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a37-f79196d000001a39-0d-588938fa1da5 Content-transfer-encoding: 8BIT Message-id: <588938F9.9070907@samsung.com> Date: Thu, 26 Jan 2017 08:47:05 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: martin@kaiser.cx, Krzysztof Kozlowski , Stephen Boyd , Sylwester Nawrocki , Tomasz Figa , Kukjin Kim Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] clk: samsung: mark s3c...._clk_sleep_init() as __init In-reply-to: <1485380545-24815-1-git-send-email-martin@kaiser.cx> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDJsWRmVeSWpSXmKPExsWy7bCmvu4vi84Ig8bzPBb9j18zW5w/v4Hd YtPja6wWH3vusVpc3jWHzWLG+X1MFhvfRVocftPOavHjTDeLxapdfxgduDwu9/UyeeycdZfd o+v6FhaPTas62Tw2L6n36NuyitHj8ya5APaoVJuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMD Q11DSwtzJYW8xNxUWyUXnwBdt8wcoOuUFMoSc0qBQgGJxcVK+nY2RfmlJakKGfnFJbZK0YaG RnqGBuZ6RkZGeibGsVZGpkAlCakZaxduZyvoVqrobd/A2MC4VKaLkZNDQsBE4vCHt6wQtpjE hXvr2boYuTiEBHYwSvw48ZAVwmlnkliwq5MJpuPhNJiqOYwSexfNYQRJ8AoISvyYfI+li5GD g1lAXuLIpWyQMLOApsTW3evZIervMUps61/CAlGvJTH9zjR2EJtFQFVi3o/XYDYbUHz/ixts IDa/gKLE1R+PweaLCkRI7Jz/DWyQiMBVRolfN4+zQ2xoY5S4tgWsSFjAX2LPhXawfzgFHCXO P70C1iAhcI1domvtLFaQ6yQEZCU2HWCG+MZFYvfN7VC2sMSr41vYIWxpiVX/bjFB9HYzSqx5 2cQK4fQwSjSuOcoGUWUscf/BPWaIK/gk3n3tgVrAK9HRJgRR4iHx6tdWqAWOEhOObGOBBMVp Rom/56axT2BUmIUUerMQoTcLKfQWMDKvYhRLLSjOTU8tNiww1itOzC0uzUvXS87P3cQITqla 5jsYN5zzOcQowMGoxMObsa0jQog1say4MvcQowQHs5II7zq5zggh3pTEyqrUovz4otKc1OJD jKbAwJ/ILCWanA9M93kl8YYmZoYmRiaGhuZGBkZK4ryLG60jhATSE0tSs1NTC1KLYPqYODil Ghg9D6+xvvqF67do6ovVwmU+py+JTpySzCX69P/n1o7fK6Kz+t7rJ/Pp+LCu3jz11P+i3IyN JvqL2rw6luoWSrXuL86fuZGlacbvv0t39p9YfEKee623xq89N/bMKGjec+3ms9tcMsrbN3in d68MuNMwl4Pt4pQKjxV/Bf6qPlNpeXi8Rpe9xfyXEktxRqKhFnNRcSIA+zk1JL8DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBIsWRmVeSWpSXmKPExsVy+t9jQd2fFp0RBuuatC36H79mtjh/fgO7 xabH11gtPvbcY7W4vGsOm8WM8/uYLDa+i7Q4/Kad1eLHmW4Wi1W7/jA6cHlc7utl8tg56y67 R9f1LSwem1Z1snlsXlLv0bdlFaPH501yAexRbjYZqYkpqUUKqXnJ+SmZeem2SqEhbroWSgp5 ibmptkoRur4hQUoKZYk5pUCekQEacHAOcA9W0rdLcMtYu3A7W0G3UkVv+wbGBsalMl2MnBwS AiYSD6etZ4OwxSQu3AOxuTiEBGYxSux+v4EFJMErICjxY/I9IJuDg1lAXuLIpWyQMLOAusSk eYuYIeofMErsenydFaJeS2L6nWnsIDaLgKrEvB+vwWw2oPj+FzfAlvELKEpc/fGYEWSmqECE RPeJSpA5IgLXGSVWNL1gAXGYBdqAjlhzjwmkQVjAV6J/yWWo604zSry/vZURJMEp4Chx/ukV 9gmMgrOQHDsL4dhZSI5dwMi8ilEitSC5oDgpPdcwL7Vcrzgxt7g0L10vOT93EyM4Vp9J7WA8 uMv9EKMAB6MSD+8Nic4IIdbEsuLK3EOMEhzMSiK86+SAQrwpiZVVqUX58UWlOanFhxhNgb6d yCwlmpwPTCN5JfGGJuYm5sYGFuaWliZGSuK8jbOfhQsJpCeWpGanphakFsH0MXFwSjUwzpS4 Uhy/bvHR2p8pzF5zPZunm4VyVxbyPbtubnhGxyPW+fnmldt23fs423w3Q4Xjw/dbXJ+3HuLo 2sB4ZEaEw8PdLoffZ8inrRCYePyFeZ11yqvLNrX5YhkfZb8ZXKtf2vb+380nFx//29+4aE7i nH9Cah9Pu3qmpv16wmj+iFErVuZFceThg0osxRmJhlrMRcWJAM1bcUjrAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170125234705epcas1p4eea21467d5b10b3b39f1c47c3402d06e X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTNS9TZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170125214354epcas3p2715bf71d3c8d56aefe881f95fb4aef1d X-RootMTR: 20170125214354epcas3p2715bf71d3c8d56aefe881f95fb4aef1d References: <1485293599-23581-1-git-send-email-martin@kaiser.cx> <1485380545-24815-1-git-send-email-martin@kaiser.cx> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Martin, The v2 patch is missing my reviewed-by tag[1]. [1] https://patchwork.kernel.org/patch/9535993/ Again, I add my reviewed-by tag. Reviewed-by: Chanwoo Choi On 2017년 01월 26일 06:42, martin@kaiser.cx wrote: > From: Martin Kaiser > > These functions are referencing s3c...._clk_regs[], which are marked as > __initdata. When compiling with CONFIG_DEBUG_SECTION_MISMATCH=y, this > produces warnings like > > WARNING: vmlinux.o(.text+0x198350): > Section mismatch in reference from the function s3c2410_clk_sleep_init() > to the (unknown reference) .init.data:(unknown) > > Mark the s3c...._clk_sleep_init() functions as __init in > order to fix this. > > Signed-off-by: Martin Kaiser > --- > v2: > Fix the commit message, describe what the problem really is. > (Thanks, Krzysztof) > > drivers/clk/samsung/clk-s3c2410.c | 4 ++-- > drivers/clk/samsung/clk-s3c2412.c | 4 ++-- > drivers/clk/samsung/clk-s3c2443.c | 4 ++-- > drivers/clk/samsung/clk-s3c64xx.c | 4 ++-- > 4 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/clk/samsung/clk-s3c2410.c b/drivers/clk/samsung/clk-s3c2410.c > index d7a1e77..e0650c3 100644 > --- a/drivers/clk/samsung/clk-s3c2410.c > +++ b/drivers/clk/samsung/clk-s3c2410.c > @@ -76,7 +76,7 @@ static void s3c2410_clk_resume(void) > .resume = s3c2410_clk_resume, > }; > > -static void s3c2410_clk_sleep_init(void) > +static void __init s3c2410_clk_sleep_init(void) > { > s3c2410_save = samsung_clk_alloc_reg_dump(s3c2410_clk_regs, > ARRAY_SIZE(s3c2410_clk_regs)); > @@ -90,7 +90,7 @@ static void s3c2410_clk_sleep_init(void) > return; > } > #else > -static void s3c2410_clk_sleep_init(void) {} > +static void __init s3c2410_clk_sleep_init(void) {} > #endif > > PNAME(fclk_p) = { "mpll", "div_slow" }; > diff --git a/drivers/clk/samsung/clk-s3c2412.c b/drivers/clk/samsung/clk-s3c2412.c > index ec873ee..b8340a4 100644 > --- a/drivers/clk/samsung/clk-s3c2412.c > +++ b/drivers/clk/samsung/clk-s3c2412.c > @@ -69,7 +69,7 @@ static void s3c2412_clk_resume(void) > .resume = s3c2412_clk_resume, > }; > > -static void s3c2412_clk_sleep_init(void) > +static void __init s3c2412_clk_sleep_init(void) > { > s3c2412_save = samsung_clk_alloc_reg_dump(s3c2412_clk_regs, > ARRAY_SIZE(s3c2412_clk_regs)); > @@ -83,7 +83,7 @@ static void s3c2412_clk_sleep_init(void) > return; > } > #else > -static void s3c2412_clk_sleep_init(void) {} > +static void __init s3c2412_clk_sleep_init(void) {} > #endif > > static struct clk_div_table divxti_d[] = { > diff --git a/drivers/clk/samsung/clk-s3c2443.c b/drivers/clk/samsung/clk-s3c2443.c > index 5e24a17..abb935c 100644 > --- a/drivers/clk/samsung/clk-s3c2443.c > +++ b/drivers/clk/samsung/clk-s3c2443.c > @@ -89,7 +89,7 @@ static void s3c2443_clk_resume(void) > .resume = s3c2443_clk_resume, > }; > > -static void s3c2443_clk_sleep_init(void) > +static void __init s3c2443_clk_sleep_init(void) > { > s3c2443_save = samsung_clk_alloc_reg_dump(s3c2443_clk_regs, > ARRAY_SIZE(s3c2443_clk_regs)); > @@ -103,7 +103,7 @@ static void s3c2443_clk_sleep_init(void) > return; > } > #else > -static void s3c2443_clk_sleep_init(void) {} > +static void __init s3c2443_clk_sleep_init(void) {} > #endif > > PNAME(epllref_p) = { "mpllref", "mpllref", "xti", "ext" }; > diff --git a/drivers/clk/samsung/clk-s3c64xx.c b/drivers/clk/samsung/clk-s3c64xx.c > index a48bd5f..7306867 100644 > --- a/drivers/clk/samsung/clk-s3c64xx.c > +++ b/drivers/clk/samsung/clk-s3c64xx.c > @@ -121,7 +121,7 @@ static void s3c64xx_clk_resume(void) > .resume = s3c64xx_clk_resume, > }; > > -static void s3c64xx_clk_sleep_init(void) > +static void __init s3c64xx_clk_sleep_init(void) > { > s3c64xx_save_common = samsung_clk_alloc_reg_dump(s3c64xx_clk_regs, > ARRAY_SIZE(s3c64xx_clk_regs)); > @@ -145,7 +145,7 @@ static void s3c64xx_clk_sleep_init(void) > __func__); > } > #else > -static void s3c64xx_clk_sleep_init(void) {} > +static void __init s3c64xx_clk_sleep_init(void) {} > #endif > > /* List of parent clocks common for all S3C64xx SoCs. */ > -- Best Regards, Chanwoo Choi Samsung Electronics