From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932416AbdA0Jka (ORCPT ); Fri, 27 Jan 2017 04:40:30 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:61189 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932117AbdA0JkL (ORCPT ); Fri, 27 Jan 2017 04:40:11 -0500 Subject: Re: [PATCH RESEND] phy: fix rockchip-inno-usb2 build errors To: Randy Dunlap References: <5098aa19-9d37-adbf-06d5-1107f00bb7f0@infradead.org> CC: MyungJoo Ham , Chanwoo Choi , Heiko Stuebner , LKML From: Kishon Vijay Abraham I Message-ID: <588B01A9.2030202@ti.com> Date: Fri, 27 Jan 2017 13:45:37 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <5098aa19-9d37-adbf-06d5-1107f00bb7f0@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 26 January 2017 11:12 PM, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build errors in phy-rockchip-inno-usb2.c. The driver uses > extcon interfaces so it should depend on EXTCON. > > Fixes these build errors: > > drivers/built-in.o: In function `rockchip_usb2phy_otg_sm_work': > phy-rockchip-inno-usb2.c:(.text+0x2bcb): undefined reference to `extcon_get_state' > phy-rockchip-inno-usb2.c:(.text+0x2cd4): undefined reference to `extcon_set_state_sync' > phy-rockchip-inno-usb2.c:(.text+0x2cec): undefined reference to `extcon_set_state_sync' > phy-rockchip-inno-usb2.c:(.text+0x2d2d): undefined reference to `extcon_get_state' > drivers/built-in.o: In function `rockchip_usb2phy_probe': > phy-rockchip-inno-usb2.c:(.text+0x31d7): undefined reference to `extcon_get_edev_by_phandle' > phy-rockchip-inno-usb2.c:(.text+0x321a): undefined reference to `devm_extcon_dev_allocate' > phy-rockchip-inno-usb2.c:(.text+0x3230): undefined reference to `devm_extcon_dev_register' > phy-rockchip-inno-usb2.c:(.text+0x375a): undefined reference to `extcon_register_notifier' > > Found in linux-next but is also needed in mainline. > > Signed-off-by: Randy Dunlap > Cc: MyungJoo Ham > Cc: Chanwoo Choi > Cc: Heiko Stuebner > Reviewed-by: Chanwoo Choi merged, thanks. -Kishon > --- > drivers/phy/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20170124.orig/drivers/phy/Kconfig > +++ linux-next-20170124/drivers/phy/Kconfig > @@ -363,6 +363,7 @@ config PHY_ROCKCHIP_INNO_USB2 > tristate "Rockchip INNO USB2PHY Driver" > depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF > depends on COMMON_CLK > + depends on EXTCON > depends on USB_SUPPORT > select GENERIC_PHY > select USB_COMMON >