From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752391AbdAaULo (ORCPT ); Tue, 31 Jan 2017 15:11:44 -0500 Received: from mail-dm3nam03on0117.outbound.protection.outlook.com ([104.47.41.117]:10272 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752195AbdAaUL0 (ORCPT ); Tue, 31 Jan 2017 15:11:26 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=zi.yan@cs.rutgers.edu; Message-ID: <5890EB58.3050100@cs.rutgers.edu> Date: Tue, 31 Jan 2017 13:54:00 -0600 From: Zi Yan User-Agent: Postbox 5.0.10 (Windows/20170123) MIME-Version: 1.0 To: Anshuman Khandual , Andrew Morton , Naoya Horiguchi , "Kirill A. Shutemov" CC: , Hugh Dickins , Dave Hansen , Andrea Arcangeli , Mel Gorman , Michal Hocko , "Vlastimil Babka" , Pavel Emelyanov , Balbir Singh , , Naoya Horiguchi Subject: Re: [PATCH v2 00/12] mm: page migration enhancement for thp References: <1478561517-4317-1-git-send-email-n-horiguchi@ah.jp.nec.com> In-Reply-To: X-Enigmail-Version: 1.2.3 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig69312C755C158C734ACD21BC" X-Originating-IP: [12.1.252.66] X-ClientProxiedBy: CY1PR08CA0020.namprd08.prod.outlook.com (10.163.94.158) To MWHPR14MB1664.namprd14.prod.outlook.com (10.171.146.146) X-MS-Office365-Filtering-Correlation-Id: 7988622c-dda2-405d-fc7e-08d44a12febc X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR14MB1664; X-Microsoft-Exchange-Diagnostics: 1;MWHPR14MB1664;3:NHeoqDLYr+U3zVVnmPFSUUB1NVtfXRV3lhMAOp+fG/tyse5Ph8qWSaEmVpz07VCdzLjrqjHKZed9vunkJIvu1JCFnzlXQVWrmEMiHSmVQaN4pul3sXwbn0bR6KIlhDudGgWrcXFB76RarFtGxFQh2t+txvUAiolNjXglEJw6nFm/w4hyqQt91x29nboXdsKXa+kt2gleZclVwEPePCeERXHsnp08KOq9ht/WLI+7cytYnHPcpVqaeRreHLiLp0Yv0mKOXZtAFZjnYSMbXLMPpg==;25:MxOHOrUz/vv7ULJrz/ziR2Z1ue44Vt2AR8YSluSXmP1RXBbWpb2o5WbIwMDBst+rF8SAV9NMCXuZzZmnfQB3jXzBH04OGtcA0IbWm/ISWSi8Rb9JsEhk4od98HR0wiO30sR6jvqLAXRlo40sGwR2iqcZks5P2Ni/rNw/wOU0YN5SURbedRE1bpLzuv87SlmEwiUTmr38+MsQVrQGolQnFbWf3QotFTBk9onMJSQ/+TkQBIiosXZpPhb9oQmAIbkKkT8Hef1Dz3/p/UhSKRHjyTRFr6UUm1iQJPr+9FeaK0CG76HeUhdg48eLyD9uEAwxENCuDw1am2vM66wxVDzVyB/hk/+PxNTxDdE6hANMbORUi4LdDHR3Akuet0pB8FE4pg9phXgQBU5DDMduUYccYvcIyWxeAQ71nsez3RYdAp46YKx4uxWG/YlphLS4EzLA/a/G6+ygbF050lHnbVvN4A== X-Microsoft-Exchange-Diagnostics: 1;MWHPR14MB1664;31:+d9COFFqxD6RIWEy3Z09i9UFZB29u+KbGyhncZ70zDdtNux6Ko+pH3wGBDDwUU/YS39ELmeI2UHbScFRR5xSafZNuvZx1zfjvnTcBKH5OfH+jF5/Ua7iQGzNEEDi3NE23Dr1JPfh4YBU05xn0IqoLmgBgURdpX7pxS96f/HGxzVHQOZ4huCX71M9YD/srV+wFvv52BYco1on7meqCJrKDwaMJ8JQ5GAeVaNaoe+nYpfggvvRs5tHnIu8zFIHJMYfjV4GYPzI+rC/uIkNA9Zqqw==;20:54MJDsuv5F0elRYMYa8b9O40KCaxSbPrVE0beEHXR0luihGAVPmsEE9Gye3yjJgbIU0xecmPmx43ar69I96aV9mJUyZ6WToIi82qZWfqlWhXEN1g3diK4dheeXmGKL6FC6ssTEdHnncgXLdHpetV9f/k/rIKsH6iRL7qAY/9+QByCT9pManm/fI+bhGwGGTfdXjrWfpeFRLdTKDbN5a1YU4zEK51XrSgx3rsMv24nL8ihPQUeTevGguX5ee5rsP56Q2JY8dIOhBOGmOEhvhsKyiLdxug9HcPX5hxFNBwi50taeD7avVEZo5qN4P6OYORtOUUZt5BYURPRFIdKNZExLGYOsepPAoUH0dOhmu0EUYrwQpjG/0KsEfbpLGaq4o54xy3ncVUJirgSx1WiEaNut0Vs/za+2C6Y0B8H0VcsAy23j2RQSYTY2OlV3VmnwIkpgmWAfpwW1LcK53gldw5uO89MtQ7thb5s8DhVli9vlqeaHiJr867r9IJkTiD4JYr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(6072148);SRVR:MWHPR14MB1664;BCL:0;PCL:0;RULEID:;SRVR:MWHPR14MB1664; X-Microsoft-Exchange-Diagnostics: 1;MWHPR14MB1664;4:o8nB+ul29RARy6mg1laY2r6NFPCrRKLwxzb70zHZPOdNkYEJ17EJR1vCS3c0Ux6HsVV8m5Q0fYuHRxglzLWlBi1XWyYdSt1MRs9BwHwXXi8BEljLLa7RDU6W64UvMNsP6u2avR2CNCE3lDfSrGfP0gBPaIamACNARv8mayxxlUE/TovqUAkPPoUz9e/ACFGj6Neb/+0RoLJnLaLMiilOjyr0avOU+JnHXZ943eNEtC70e4R5iYWND6kckvJHtJiZzbp1HlTQIJ6yGOTOvdzp0GzC3CZ91osH+WRoyqwg6KArZ46Z954w5ya4VSxSHT53PcuhNFepXJJlxN8w6zYBIJ3DvLE5cMXxYIa7jTPRkPslTR6D17xMG6Ai8C3ChMgfPiUmhtggcHdVMwl85SbjwH3OAEyAF+HvBV2oNhEP+dV+YHNiQ0TZVg8xepKlMQQEUqbeg7mPuMo8DIOZemGLuFkYc0XlrNwhWV6PnXe9Zhy2UdMLMG4uOhcW3fB9F1znrL5+wjHE8DS01lRBrAJriA4LOpaU4YNUj5TRU9oxLBsmTVzz2+g8cEWx5puIWtnFZTBn7rCI88wZ0wlwoOKJCA== X-Forefront-PRVS: 0204F0BDE2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(39410400002)(39450400003)(39830400002)(53754006)(377454003)(189002)(24454002)(199003)(305945005)(83506001)(38730400001)(512874002)(4326007)(84326002)(229853002)(39060400001)(7416002)(68736007)(7736002)(5001770100001)(59896002)(97736004)(189998001)(2950100002)(2906002)(90366009)(4001150100001)(5660300001)(80316001)(6666003)(4001350100001)(88552002)(5890100001)(77096006)(6486002)(42882006)(568964002)(75432002)(66066001)(81156014)(8676002)(86362001)(6306002)(81166006)(54906002)(50986999)(65816999)(54356999)(6116002)(76176999)(101416001)(87266999)(25786008)(3846002)(21480400002)(53936002)(33656002)(92566002)(106356001)(105586002)(42186005);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR14MB1664;H:[10.20.179.160];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR14MB1664;23:ARP8JdXloeQ1bNQ/d+T4p8D44k2qLVxlnoLghXz66?= =?us-ascii?Q?+dkIe8a/cuuTlP2q/660Sx2q+ZlW4jZEnzyTjNL/jzYiX+SOFqxPkaHUMnn6?= =?us-ascii?Q?T4Df0q7hnHAV4iBzSnwgjUsXkimxjbMo9oCPoByFmxvOHKHbWYmAq6cuJ/u3?= =?us-ascii?Q?V4q+wX09anGuWb8Es5HW1EbLRX10fKFSh9zFDLDp+BeIuOr4O9/heMb46hYb?= =?us-ascii?Q?ak2nFwG9mfH8BbYQWuxB47WQHD34/tzAA+Knh/bC0Zl3ECXtGLSjV67glgo5?= =?us-ascii?Q?2g1FBUfhGi79cVZJZnJo5OohezRyKDBFX00Z66HNsC21Ym5JE4DWwMtv42cQ?= =?us-ascii?Q?oCDAyh1JWh4ZsjcMtcrsaBIBKGM6odm1PY8SvC6hdsvNJYgv26yyIpso9GPk?= =?us-ascii?Q?OEJygNvCgrzbFH8EcFksUQ/XM/5jMIXCzD/rZELS/SiVzoiwK+KZX79QA93p?= =?us-ascii?Q?ACykhk9rcFq2/4suebYj8px5Z0c8C2Q4KkH2yP6EkshPBF2CcWfECN0Wn/A6?= =?us-ascii?Q?K9+QJyoZPROf7vkY29XY6VjjnA9ArJsztk1V8eEz2WXFWYeJ73v4FVGYdizQ?= =?us-ascii?Q?2UsSj65/3Mfzmr4rjyQMrIQ2KXtoMmw0Fzhi3wUMFsj9HAD1r7oH29q2ui/O?= =?us-ascii?Q?bDSZDY5iF+5oHtf56K3lrrnNEAB2BFrS2q2d0w/1ggL7TsI1vum61+MpCiSr?= =?us-ascii?Q?PTaqURAEw+0OqtdEk+QACL3D0EJIxhBb0+ervpx9rtsmuNEqzg4leCRJHu5Q?= =?us-ascii?Q?0TVdP2ntvoYlw0Ccjpad7msaPkpWgqScqBfBJ9d2fxsipCAXgEbDFHZIQ1E/?= =?us-ascii?Q?e4c8sJROvmcySSkeXBXZhFjTmGnKU6hwc/G6hXphI7azklGFA8I7NEi/d39h?= =?us-ascii?Q?S7FkRR6mLIgr55+NtV+eCjbV5i8ojDOzhWDz2UzGfw9UwH4DMtdaKgEh0wSm?= =?us-ascii?Q?IJVPHbsirqzck30/OZuOnEIqvecJBQ19py5NOjwy7Ibk1GYuw5mLkECz5sOs?= =?us-ascii?Q?rdhudrfFcXGH/aRRmxKdrRaRbTnc6nU8mMI0AGuVy1hxN8mq9sKaNvLCe0wL?= =?us-ascii?Q?KvUAzJwOBCQzpv1knrBOC7hf2mxjBphSrgQLsKkcqJTZN4Dp4HeAwu1ahc6F?= =?us-ascii?Q?xfHaBBQok9N8rUgCPmXbXHc76hCoxMJu1+ji3hZzJzjCDX+rsU/8FbGZCN9q?= =?us-ascii?Q?P3gIKZkVkDGG2tzuW3f4orBmufXXO/UcmeNY1yzwxlihIF/x4BFVMLq+QeNs?= =?us-ascii?Q?yeM6CSIXvSA+J1qqiOlU5HnKAh5TajN9Yx44ftKcLPyFJd8Sss8fHolPYGkT?= =?us-ascii?Q?JIdJebyZ9rNcL7zToVatmaBPu7sCc16Ra702/JdydLe9uygZoxLz4fOlIe/Y?= =?us-ascii?Q?VTiTBpxHWYmC9dsZo44Kaxraya49maz8bsK+QcaI2aFww9OKhMTtFr7aTl+r?= =?us-ascii?Q?IJ2mX7fBuDQc3SEE2eWuFhJFosh6+Q8ZgqgNd0YyhiL1p68FDE1xIvPWst4b?= =?us-ascii?Q?7HcIVkIkMT29DCHhd9TJpx0lJgDWjLLb3U765FbbpZKgOP5oQER5RHA/S3Gl?= =?us-ascii?Q?LmIXn9w2p92rdGfRsdyl1KTr4P0eyIDXKAbjafhukfwuPLCRwYEv8NFIahK?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR14MB1664;6:7b0/tyxOoR+OYUhENiJ/mNTQNlEbbrAZ9C5JojwvpNgbJvs3X3a+25Zjh3LaGjs7nxdeWUw1dYaQ1C3bpD7+6U+LA+d01UxmWNWhypFV8VSK7P8JcgsG5wLisIqNDL4UuoCMFUeyb29JBru5xzTwT09UQG5iqtFa81Lxl7jPOIEcyPH/7FK46VpXeo8ihPhewoQJOjKcOXg6i1h7QdSBndkoBcVuNxrPsppIVguZpKqYis5pyheGr9mSnJx+aFaz/cScDT2XH5Rz1exLAmVH5wMIOqdMhO4d8vB8en4HWOeD+NV0F+tHBi3YUSYUxOK8CbI5gp/Iw+nOll3AaAhaNPjHIXWJydf0eOKuVz54w5A57sRKJkw8n2KFgREXAa2vUdXVAy/TLwKagSii0/swTU3zZwrc7jdGz2ZYiS1XDx4=;5:OfxooOQoP/EwiiHKlPeM9ysYaPPRmdbExK622GOLhkdBt+BgUtgey8nmRsiUraWBeyUhd+gTUu3f9LIbB3wBSkza1HythnaNWPcwyEfZAZAykfOK+j1/A2caG1jDvVcJZlu44yG4TCp5A8X0jB6ycLAvr3MMCC7h5Ah/3yUa3Mk=;24:0FqDCiPjchp7RRtbrzxZg/2sp3YJU39O7vzbT3YFvpEGT4BSqrD1phcjPzNU8X6SzEnXRF3NNxa1EJABCiekm3ZXtqgjrz9s23n9F3U5x6M= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR14MB1664;7:nwdqCLzPF8+sbXNG4fbCaM+c9a+IjLnYFcpo+XtlHez9ZFp3V0vdi8b56OLkY6z9zJPDRdMrilOYWa5DIHIWCLw3kjg8B+xmFnO8USXJzL2d3QC6ETB6C7XgvJNHrJJwBD0LUsge67Vgo8FFQWrT6tk+602KgyU8xokmY8qbzldZ8fnk3y+sYr3YVOu6zeJ3gFnGlcwH3afy3wMTm5h/3NJfJy/LLLGxJXUcshtSlNem/pD4fT3sKUUCqR6j6zhDbqLqhucBUDNuQIUjcx/+rK2lYGeGcXnQVY2n9iC2TnYJBzqWP7F5+1gS47SIr43LFcoNfuFkai0GSwmko2Buug0rxs0TPHf+jjtBH2GTHbbegTwMqjWtzl66SJucsD1f+ockLrEFq096C5kKe2HgQacrlICDVidju4JH5JTBPcb+SaCDaQoc8pLRHl0PUt3ZUGw00KeESkGDZzPNa905s+j3gQrNWz5ZttwqS48o63kUWBNO8R0HQRgnsuifTx4LtL4YWQ4iOFY9psRX0FfzXyOSfe6q8P077/j2+SnHhQmMmjN/nlLzMwKkNdCl3zH3 X-OriginatorOrg: cs.rutgers.edu X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2017 19:54:39.0111 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR14MB1664 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --------------enig69312C755C158C734ACD21BC Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I am also doing some tests on THP migration and discover that there are some corner cases not handled in this patchset. For example, in handle_mm_fault, without taking pmd_lock, the kernel may see pmd_none(*pmd) during THP migrations, which leads to handle_pte_fault or even deeper in the code path. At that moment, pmd_trans_unstable() will treat a pmd_migration_entry as pmd_bad and clear it. This leads to application crashing and page table leaks, since a deposited PTE page is not released when the application crashes. Even after I add is_pmd_migration_entry() into pmd_trans_unstable(), I still see application data corruptions. I hope someone can shed some light on how to debug this. Should I also look into pmd_trans_huge() call sites where pmd_migration_entry should be handled differently? Thanks. Anshuman Khandual wrote: > On 11/08/2016 05:01 AM, Naoya Horiguchi wrote: >> Hi everyone, >> >> I've updated thp migration patches for v4.9-rc2-mmotm-2016-10-27-18-27= >> with feedbacks for ver.1. >=20 > Hello Noaya, >=20 > I have been working with Zi Yan on the parallel huge page migration ser= ies > (https://lkml.org/lkml/2016/11/22/457) and planning to post them on top= of > this THP migration enhancement series. Hence we were wondering if you h= ave > plans to post a new version of this series in near future ? >=20 > Regards > Anshuman >=20 --=20 Best Regards, Yan Zi --------------enig69312C755C158C734ACD21BC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJYkOt/AAoJEEGLLxGcTqbMEmgH/RGfR7f5boRco6eWExeZ1adJ 6kRYWmYXipya1xJV7afp+px+MVsHA86IuCM2j+p/tSW000vRge2ydfIgHxrmIk1Q pzXu1ILdMr91/sST1Zz4EBHSU2cB40EsbPq0nUT9OGda67XCWCcW7c6H9HQagMFm w3NtHXgseJmr8vjcX5d44z1/zSBdDUQ1yNE8dzYHV5hZ7Mq47oRHju35pox+bQ6I BOfRyDDtNAOuRGigEowTPBE8iLuoCQk9Ij0Re6NmBRIRquWrUYm0Up85iOGBK96a GRL9vBAVZRAXNkVOygjwnSYxRKcbr05P0uIp6P/SWhtnoALneWA906M7nXqDHZA= =fpdi -----END PGP SIGNATURE----- --------------enig69312C755C158C734ACD21BC--