From: Daniel Rosenberg <drosen@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@android.com
Subject: Re: [PATCH] staging: android: ion: check for kref overflow
Date: Thu, 30 Aug 2018 18:36:18 -0700 [thread overview]
Message-ID: <589c036d-450a-3f3b-8f5a-4148713d4bfb@google.com> (raw)
In-Reply-To: <20180831004144.GC20664@kroah.com>
On 08/30/2018 05:41 PM, Greg Kroah-Hartman wrote:
> On Thu, Aug 30, 2018 at 04:09:46PM -0700, Daniel Rosenberg wrote:
>> This patch is against 4.9. It does not apply to master due to a large
>> rework of ion in 4.12 which removed the affected functions altogther.
>> 4c23cbff073f3b9b ("staging: android: ion: Remove import interface")
>>
>> Userspace can cause the kref to handles to increment
>> arbitrarily high. Ensure it does not overflow.
>>
>> Signed-off-by: Daniel Rosenberg <drosen@google.com>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> I signed off on this? Where? When? Are you sure?
>
> greg k-h
The sign off was on the 4.4.y version that I cherry-picked this from.
There was a trivial conflict moving it to 4.9, but it did not modify any
changed lines, so I hadn't thought that was worth noting on the patch. I
apologise if leaving the signed-off-by was incorrect here.
-Daniel
next prev parent reply other threads:[~2018-08-31 1:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 23:09 [PATCH] staging: android: ion: check for kref overflow Daniel Rosenberg
2018-08-31 0:41 ` Greg Kroah-Hartman
2018-08-31 1:36 ` Daniel Rosenberg [this message]
2018-08-31 15:56 ` Greg Kroah-Hartman
2018-08-31 21:31 ` Daniel Rosenberg
2018-09-03 16:31 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2018-08-21 1:30 Daniel Rosenberg
2018-08-21 5:13 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=589c036d-450a-3f3b-8f5a-4148713d4bfb@google.com \
--to=drosen@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).