From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753052AbdBPDCD (ORCPT ); Wed, 15 Feb 2017 22:02:03 -0500 Received: from regular1.263xmail.com ([211.150.99.132]:43337 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751371AbdBPDCC (ORCPT ); Wed, 15 Feb 2017 22:02:02 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: zyw@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 220.128.92.125 X-LOGIN-NAME: zyw@rock-chips.com X-UNIQUE-TAG: <84388dc95d650c5f80a08275bce9046c> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v3 22/24] drm/rockchip: dw-mipi-dsi: support non-burst modes To: Sean Paul , John Keeping References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-23-john@metanate.com> <20170131192255.GF20076@art_vandelay> Cc: Mark Yao , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Chris Zhong Message-ID: <58A5161A.3070205@rock-chips.com> Date: Thu, 16 Feb 2017 11:01:46 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20170131192255.GF20076@art_vandelay> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John On 02/01/2017 03:22 AM, Sean Paul wrote: > On Sun, Jan 29, 2017 at 01:24:42PM +0000, John Keeping wrote: > > Reviewed-by: Sean Paul > >> Signed-off-by: John Keeping >> Reviewed-by: Chris Zhong >> --- >> v3: >> - Add Chris' Reviewed-by >> Unchanged in v2 >> >> drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 16 +++++++++------- >> 1 file changed, 9 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c >> index 5bad92e2370e..58cb8ace2fe8 100644 >> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c >> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c >> @@ -82,6 +82,7 @@ >> #define FRAME_BTA_ACK BIT(14) >> #define ENABLE_LOW_POWER (0x3f << 8) >> #define ENABLE_LOW_POWER_MASK (0x3f << 8) >> +#define VID_MODE_TYPE_NON_BURST_SYNC_EVENTS 0x1 >> #define VID_MODE_TYPE_BURST_SYNC_PULSES 0x2 This field indicates the video mode transmission type as follows: 00: Non-burst with sync pulses 01: Non-burst with sync events 10 and 11: Burst mode So, I think define the macro like this is better: #define VID_MODE_TYPE_NON_BURST_SYNC_PULSES 0x0 #define VID_MODE_TYPE_NON_BURST_SYNC_EVENTS 0x1 #define VID_MODE_TYPE_BURST 0x2 >> #define VID_MODE_TYPE_MASK 0x3 >> >> @@ -286,6 +287,7 @@ struct dw_mipi_dsi { >> u32 format; >> u16 input_div; >> u16 feedback_div; >> + unsigned long mode_flags; >> >> const struct dw_mipi_dsi_plat_data *pdata; >> }; >> @@ -551,15 +553,10 @@ static int dw_mipi_dsi_host_attach(struct mipi_dsi_host *host, >> return -EINVAL; >> } >> >> - if (!(device->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) || >> - !(device->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)) { >> - dev_err(dsi->dev, "device mode is unsupported\n"); >> - return -EINVAL; >> - } >> - >> dsi->lanes = device->lanes; >> dsi->channel = device->channel; >> dsi->format = device->format; >> + dsi->mode_flags = device->mode_flags; >> dsi->panel = of_drm_find_panel(device->dev.of_node); >> if (dsi->panel) >> return drm_panel_attach(dsi->panel, &dsi->connector); >> @@ -716,7 +713,12 @@ static void dw_mipi_dsi_video_mode_config(struct dw_mipi_dsi *dsi) >> { >> u32 val; >> >> - val = VID_MODE_TYPE_BURST_SYNC_PULSES | ENABLE_LOW_POWER; >> + val = ENABLE_LOW_POWER; >> + >> + if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) >> + val |= VID_MODE_TYPE_BURST_SYNC_PULSES; >> + else if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)) >> + val |= VID_MODE_TYPE_NON_BURST_SYNC_EVENTS; if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) val |= VID_MODE_TYPE_BURST; else if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) val |= VID_MODE_TYPE_NON_BURST_SYNC_PULSES; else val |= VID_MODE_TYPE_NON_BURST_SYNC_EVENTS; >> >> dsi_write(dsi, DSI_VID_MODE_CFG, val); >> } >> -- >> 2.11.0.197.gb556de5.dirty >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel