From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751383AbdAWRYx (ORCPT ); Mon, 23 Jan 2017 12:24:53 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:35166 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750732AbdAWRYv (ORCPT ); Mon, 23 Jan 2017 12:24:51 -0500 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH v4 0/9] Implement clocksource for rockchip SoC using rockchip timer From: Alexander Kochetkov In-Reply-To: <1793912.WfGyM7qEjy@diego> Date: Mon, 23 Jan 2017 20:24:47 +0300 Cc: Daniel Lezcano , LKML , devicetree@vger.kernel.org, LAK , linux-rockchip@lists.infradead.org, Thomas Gleixner , Mark Rutland , Rob Herring , Russell King , Caesar Wang , Huang Tao Message-Id: <58B283B0-02F6-4342-A6D2-7E082E04863E@gmail.com> References: <1480343486-25539-1-git-send-email-al.kochet@gmail.com> <20170123144744.GE2166@mai> <1793912.WfGyM7qEjy@diego> To: =?utf-8?Q?Heiko_St=C3=BCbner?= X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0NHOwhV012132 Heiko, Daniel, thanks a lot for review! I’ll send v5 series this week. Heiko, Daniel, may I add 'Reviewed-by:’ to patch series? Reviewed-by: Heiko Stübner ? Reviewed-by: Daniel Lezcano ? Regards, Alexander. > 23 янв. 2017 г., в 20:12, Heiko Stübner написал(а): > > Am Montag, 23. Januar 2017, 15:47:44 CET schrieb Daniel Lezcano: >> On Wed, Dec 21, 2016 at 05:21:05PM +0300, Alexander Kochetkov wrote: >>> Hello Heiko, Daniel! >>> >>> Are there any reasons why the patches [1][2] are not applied yet into >>> kernel? How can I help in applying patches? >> >> Hi Alexander, >> >> sorry for the delay. Let me review them before taking the patchset. >> >> Heiko, can you have a look to them also ? > > somehow this series moved down to much in my inbox, sorry. > > Devicetree changes look good, except where I commented. > I guess it would be best (least intrusive) if I queue up the (then fixed) > devicetree changes after you are satisfied with the code parts. > > I've also looked over the code changes again, test-build them and found the > build error mentioned separately. Overall they look good though. > > > Heiko