From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753429AbdCONuc (ORCPT ); Wed, 15 Mar 2017 09:50:32 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48165 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752147AbdCONt0 (ORCPT ); Wed, 15 Mar 2017 09:49:26 -0400 Subject: Re: [PATCH v5 3/7] perf/sdt: Directly record SDT events with 'perf record' To: Arnaldo Carvalho de Melo , Jiri Olsa References: <20170314150658.7065-1-ravi.bangoria@linux.vnet.ibm.com> <20170314150658.7065-4-ravi.bangoria@linux.vnet.ibm.com> <20170315120331.GC18147@krava> <20170315131657.GI12825@kernel.org> Cc: mingo@redhat.com, mhiramat@kernel.org, brendan.d.gregg@gmail.com, peterz@infradead.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jolsa@kernel.org, ak@linux.intel.com, treeze.taeung@gmail.com, mathieu.poirier@linaro.org, hekuang@huawei.com, sukadev@linux.vnet.ibm.com, ananth@in.ibm.com, naveen.n.rao@linux.vnet.ibm.com, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, hemant@linux.vnet.ibm.com, Ravi Bangoria From: Ravi Bangoria Date: Wed, 15 Mar 2017 19:19:11 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20170315131657.GI12825@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17031513-2213-0000-0000-000001600705 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006786; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000206; SDB=6.00834184; UDB=6.00409633; IPR=6.00611841; BA=6.00005214; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014658; XFM=3.00000013; UTC=2017-03-15 13:49:24 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17031513-2214-0000-0000-000054B00F3E Message-Id: <58C94657.1010307@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-15_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703150109 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 15 March 2017 06:46 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 15, 2017 at 01:03:31PM +0100, Jiri Olsa escreveu: >> On Tue, Mar 14, 2017 at 08:36:54PM +0530, Ravi Bangoria wrote: >>> +++ b/tools/perf/builtin-record.c >>> +static int record__parse_events_option(const struct option *opt, >>> + const char *str, >>> + int unset) >>> +{ >>> + if (is_sdt_event((char *) str)) >>> + return parse_sdt_events_option(opt, str, unset); >>> + else >>> + return parse_events_option(opt, str, unset); >> so what happens if there're more than one event in 'str' like: >> -e cycles,std_... >> >> would it be better to plug this directly into parse-events.y >> parser.. and handle it like any other event type? > Yeah, I went to bed thinking about this :-) > > Ravi, > > Please test something like: > > perf record -e cycles,sdt_glib:mem__alloc,sched:*switch -a sleep 5s Thanks Jiri, Arnaldo, Yeah, this is failing :) $ sudo ./perf record -a -e sdt_libpthread:mutex_release,sced:*switch Error: sdt_libpthread:mutex_release,sched:*switch not found in the cache invalid or unsupported event: 'sdt_libpthread:mutex_release,sched:*switch' Actually I tested with 'perf record -e ev1 -e ev2', but in this case record__parse_events_option will get called separately for each individual event. Anyway, I'll fix this in next version. Thanks for the review, Ravi