linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arulprabhu Ponnusamy (arulponn)" <arulponn@cisco.com>
To: "Karan Tilak Kumar (kartilak)" <kartilak@cisco.com>,
	"Satish Kharat (satishkh)" <satishkh@cisco.com>
Cc: "Sesidhar Baddela (sebaddel)" <sebaddel@cisco.com>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: fnic: Change shost_printk with FNIC_FCS_DBG
Date: Tue, 24 Nov 2020 01:10:45 +0000	[thread overview]
Message-ID: <58CCBA06-7F76-46C8-B0D5-194B5157E861@cisco.com> (raw)
In-Reply-To: <20201120220712.16708-1-kartilak@cisco.com>

Changes look good.
Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com>

On 11/20/20, 2:08 PM, "Karan Tilak Kumar" <kartilak@cisco.com> wrote:

    Replacing shost_printk with FNIC_FCS_DBG so that
    these log messages are controlled by fnic_log_level
    flag in fnic_fip_handler_timer.

    Bumping up version number from 47 to 49 to
    maintain same level as internal version.

    Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com>
    Signed-off-by: Satish Kharat <satishkh@cisco.com>
    ---
     drivers/scsi/fnic/fnic.h     | 2 +-
     drivers/scsi/fnic/fnic_fcs.c | 6 +++---
     2 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/scsi/fnic/fnic.h b/drivers/scsi/fnic/fnic.h
    index 477513dc23b7..ed00b6061e0c 100644
    --- a/drivers/scsi/fnic/fnic.h
    +++ b/drivers/scsi/fnic/fnic.h
    @@ -39,7 +39,7 @@

     #define DRV_NAME		"fnic"
     #define DRV_DESCRIPTION		"Cisco FCoE HBA Driver"
    -#define DRV_VERSION		"1.6.0.47"
    +#define DRV_VERSION		"1.6.0.49"
     #define PFX			DRV_NAME ": "
     #define DFX                     DRV_NAME "%d: "

    diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c
    index e3384afb7cbd..3fc3a7271dc1 100644
    --- a/drivers/scsi/fnic/fnic_fcs.c
    +++ b/drivers/scsi/fnic/fnic_fcs.c
    @@ -1349,7 +1349,7 @@ void fnic_handle_fip_timer(struct fnic *fnic)
     	}

     	vlan = list_first_entry(&fnic->vlans, struct fcoe_vlan, list);
    -	shost_printk(KERN_DEBUG, fnic->lport->host,
    +	FNIC_FCS_DBG(KERN_DEBUG, fnic->lport->host,
     		  "fip_timer: vlan %d state %d sol_count %d\n",
     		  vlan->vid, vlan->state, vlan->sol_count);
     	switch (vlan->state) {
    @@ -1372,7 +1372,7 @@ void fnic_handle_fip_timer(struct fnic *fnic)
     			 * no response on this vlan, remove  from the list.
     			 * Try the next vlan
     			 */
    -			shost_printk(KERN_INFO, fnic->lport->host,
    +			FNIC_FCS_DBG(KERN_INFO, fnic->lport->host,
     				  "Dequeue this VLAN ID %d from list\n",
     				  vlan->vid);
     			list_del(&vlan->list);
    @@ -1382,7 +1382,7 @@ void fnic_handle_fip_timer(struct fnic *fnic)
     				/* we exhausted all vlans, restart vlan disc */
     				spin_unlock_irqrestore(&fnic->vlans_lock,
     							flags);
    -				shost_printk(KERN_INFO, fnic->lport->host,
    +				FNIC_FCS_DBG(KERN_INFO, fnic->lport->host,
     					  "fip_timer: vlan list empty, "
     					  "trigger vlan disc\n");
     				fnic_event_enq(fnic, FNIC_EVT_START_VLAN_DISC);
    -- 
    2.29.2



  reply	other threads:[~2020-11-24  1:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20 22:07 [PATCH] scsi: fnic: Change shost_printk with FNIC_FCS_DBG Karan Tilak Kumar
2020-11-24  1:10 ` Arulprabhu Ponnusamy (arulponn) [this message]
2020-11-24  3:48 ` Martin K. Petersen
2020-12-01  5:04 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58CCBA06-7F76-46C8-B0D5-194B5157E861@cisco.com \
    --to=arulponn@cisco.com \
    --cc=jejb@linux.ibm.com \
    --cc=kartilak@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=satishkh@cisco.com \
    --cc=sebaddel@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).