From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755115AbdDEBVf (ORCPT ); Tue, 4 Apr 2017 21:21:35 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:42841 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754981AbdDEBVc (ORCPT ); Tue, 4 Apr 2017 21:21:32 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: b6c32a2d-f792a6d0000055a1-9c-58e4469a48c7 Content-transfer-encoding: 8BIT Message-id: <58E44698.5020605@samsung.com> Date: Wed, 05 Apr 2017 10:21:28 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Enric Balletbo i Serra , MyungJoo Ham , Rob Herring Cc: Lee Jones , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Benson Leung Subject: Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out. In-reply-to: <58B7C9BF.1040708@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOJsWRmVeSWpSXmKPExsWy7bCmhu4stycRBodPsFhMf3KZxWL+kXOs FmtuH2K0uP/1KKPF5V1z2CxuN65gs2jde4Tdgd1jdsNFFo8dd5cwemxa1cnmcefaHjaPvi2r GD0+b5ILYItKtclITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1 y8wBukVJoSwxpxQoFJBYXKykb2dTlF9akqqQkV9cYqsUbWhopGdoYK5nZGSkZ2Ica2VkClSS kJox9+Zt9oKDohV3DvSxNzBOEOxi5OSQEDCRmP+xlRnCFpO4cG89WxcjF4eQwFJGiVOr3jGC JIQE2pkkljyyh2nYtWUBO0TRckaJiVdmgHXzCghK/Jh8j6WLkYODWUBe4silbJAws4CmxIsv k1gg6u8xSsxv3QFVryWxa+sBsAUsAqoSjzadYQOx2YDi+1/cALP5BRQlrv54DFYjKhAhsXP+ N7DFIgJtjBK7n2xmhdjQwihx8IkZiC0skCBxZPFZZpAjOAW0JR4eMASplxDYxy7xasc8sLiE gKzEpgNQpovE6ttqEH8JS7w6voUdwpaW+Lv0FiNEazujxOY591ggnA5GifsrG1khqowl7j+4 xwxxA59E7+8nTBBDeSU62oQgSjwkJj6+BDXUUeL8jeuMkIB4xyjR/2Ul6wRGhVlIYTcLEXaz kMJuASPzKkax1ILi3PTUYtMCI73ixNzi0rx0veT83E2M4ESppbuD8csC70OMAhyMSjy8CeJP IoRYE8uKK3MPMUpwMCuJ8OYpAYV4UxIrq1KL8uOLSnNSiw8xmgKDfiKzlGhyPjCJ55XEG5pY GpiYmhkbGBtaWCqJ86qvvBYhJJCeWJKanZpakFoE08fEwSnVwFh2R9m+8dajdjXb52tCn9Y2 lXO5VCTNZFR3L1X0tS5akPojgymizi89TPnt2c2zflaVPXfYt6HywulfAT6M1Ql9jw0yBDlf T8y17d681sPtkoQz02PxDy/fS/XMuM74Sn3P518LtsrcNolf/5jhju99k+p/rXErHsqvsGxu aLx4ZvZM+/NLTZRYijMSDbWYi4oTARnt82SqAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMIsWRmVeSWpSXmKPExsVy+t9jAd2Zbk8iDD6/E7OY/uQyi8X8I+dY LdbcPsRocf/rUUaLy7vmsFncblzBZtG69wi7A7vH7IaLLB477i5h9Ni0qpPN4861PWwefVtW MXp83iQXwBblZpORmpiSWqSQmpecn5KZl26rFBripmuhpJCXmJtqqxSh6xsSpKRQlphTCuQZ GaABB+cA92AlfbsEt4y5N2+zFxwUrbhzoI+9gXGCYBcjJ4eEgInEri0L2CFsMYkL99azdTFy cQgJLGWUmPVhNSNIgldAUOLH5HssXYwcHMwC8hJHLmVDmOoSU6bkQpQ/YJS4tuM+G0S5lsSu rQfAWlkEVCUebToDFmcDiu9/cQPM5hdQlLj64zEjyBxRgQiJ7hOVIHNEBNoYJU5u38gC4jAL tDBKvNuyBmyQsECCxJHFZ5khtr1jlJj0aD07SDengLbEwwOGExgFZyE5dRbCqbMQTl3AyLyK USK1ILmgOCk91ygvtVyvODG3uDQvXS85P3cTIzgCn0nvYDy8y/0QowAHoxIPb8W0xxFCrIll xZW5hxglOJiVRHjzlJ5ECPGmJFZWpRblxxeV5qQWH2I0Bfp1IrOUaHI+MDnklcQbmpibmBsb WJhbWpoYKYnzNs5+Fi4kkJ5YkpqdmlqQWgTTx8TBKdXAuOd80Qqmx1dLl08qPrrKOiSbs/t0 jA5fuPg2FrvYtRLa1+Nul3dWGB1uWqOvY9kcxyT5t/7NjpnavdYu4e9db2xnCula89+wrTmz JaRFnnOH99aOCl6D6Vc7PsZeP3R4csM8cU2uI2lT1p7gieVvqHXxtov5sqGeR/jdllyBZUVd Noe0e7yVWIozEg21mIuKEwH+jez01gIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170405012129epcas5p4d588155a4b63c229933b3d01032f270e X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170301112844epcas4p34012f1564f1145f8d8a8967f4fe9a821 X-RootMTR: 20170301112844epcas4p34012f1564f1145f8d8a8967f4fe9a821 References: <20170301111943.12170-1-enric.balletbo@collabora.com> <20170301111943.12170-2-enric.balletbo@collabora.com> <58B7C9BF.1040708@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Enric, On 2017년 03월 02일 16:29, Chanwoo Choi wrote: > Hi, > > On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote: >> From: Benson Leung >> >> This is the driver for the USB Type C cable detection mechanism >> built into the ChromeOS Embedded Controller on systems that >> have USB Type-C ports. >> >> At present, this allows for the presence of display out, but in >> future, it may also be used to notify host and device type cables >> and the presence of power. >> >> Signed-off-by: Benson Leung >> Signed-off-by: Enric Balletbo i Serra >> --- >> Changes since v1: >> Requested by Chanwoo Choi >> - Rename files changing _ for - >> - Remove the unneeded blank line on bottom of header. >> - Remove kobject.h and cros_ec_commands.h includes. >> - Remove the debug message as is not necessary. >> - Use the tab for indentation instead of space for if sentence. >> - Define each variable on different lines when the variables should be >> initialized. >> - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now. >> - Add one blank line to split out between state and property setting. >> - Add the author information (header and module) >> >> Enric Balletbo >> - As Rob suggested to rename the compatible name to something indicating that >> is USB Type C related I also renamed the file names, extcon-cros-ec -> >> extcon-usbc-cros-ec, I think it's more clear. >> >> drivers/extcon/Kconfig | 7 + >> drivers/extcon/Makefile | 1 + >> drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++ >> include/linux/mfd/cros_ec_commands.h | 75 +++++++ >> 4 files changed, 498 insertions(+) >> create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c >> > > Looks good to me. > Acked-by: Chanwoo Choi > > I think this patch should be handled with patches[1]. > [1] https://lkml.org/lkml/2017/2/14/655 > > I think that one maintainer among following subsystems > (mfd, chrome h/w platform, rtc and extcon) > will apply their git repository, and then one maintainer > will send the pull request of immutable branch for these patches. > As I mentioned, these patch should be handled with related patches[1]. [1] https://lkml.org/lkml/2017/2/14/655 So, I can't apply these patch on extcon git because there is a merge conflict and we should handle these patches with immutable branch between subsystem maintainer. The v4.11-rc5 was released, if you want to apply this patch to the v4.12-rc1, please take care of these patches. -- Best Regards, Chanwoo Choi Samsung Electronics