From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753307AbdDJL7a (ORCPT ); Mon, 10 Apr 2017 07:59:30 -0400 Received: from mail-pg0-f50.google.com ([74.125.83.50]:35326 "EHLO mail-pg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752746AbdDJL72 (ORCPT ); Mon, 10 Apr 2017 07:59:28 -0400 Subject: Re: [PATCH] of: change fixup of dma-ranges size to error To: Sricharan R , Rob Herring , Robin Murphy References: <1491459529-31391-1-git-send-email-frowand.list@gmail.com> <58E68ADC.6040603@gmail.com> <58E72123.4040607@gmail.com> <58E82008.7000102@gmail.com> <19a2a28f-8338-970e-3b5f-05be3362fb9a@codeaurora.org> Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Frank Rowand Message-ID: <58EB7389.7020603@gmail.com> Date: Mon, 10 Apr 2017 04:59:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <19a2a28f-8338-970e-3b5f-05be3362fb9a@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/10/17 04:48, Sricharan R wrote: > Hi Frank, > > > >>>> Can we get back to the basic premise of the proposed patch? >>>> >>>> The current code in of_dma_configure() contains a hack that allows the >>>> dma-ranges property to specify a mask instead of a size. The binding >>>> in the specification allows a size and does not allow a mask. >>>> >>>> The hack was added to account for one or more dts files that did not >>>> follow the specification. In the mail list discussion of the hack >>>> you said "Also, we need a WARN here so DTs get fixed." >>>> >>>> The hack was first present in Linux 4.1. The only in-tree dts that >>>> incorrectly contained a mask instead of a size in dma-ranges was >>>> arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi >>>> >>>> That .dtsi was fixed by >>>> commit c91cb9123cdd ("dtb: amd: Fix DMA ranges in device tree") >>>> The fix was present in Linux 4.6, May 15, 2016. >>>> >>>> I would like to remove the hack. I think that enough time has >>>> elapsed to allow this change. >>> >>> If we have no cases of what I'm concerned about, then removing it is >>> fine. Is this a dependency for iommu series? Doesn't look like it to >>> me. >> >> This patch is a replacement for patch 03/12 in the iommu series. I >> think that patch 03/12 of the iommu series could be dropped and my >> patch could be applied independently of the iommu series. >> >> There is likely a conflict between my patch and patch 06/12 of the >> iommu series because in my patch the first line of the patch chunk >> of drivers/of/device.c includes a line that is changed in 06/12 >> of the iommu series. If this is the case then the iommu series >> should take precedence over my patch (and I should subsequently >> fixup my patch). >> > > Ok, for which i just posted a V11 [1] with patch 03/12 from > V10 dropped. > > [1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1373638.html > > Regards, > Sricharan > Thanks. I'll revisit this patch after the iommu series gets merged. -Frank