From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1434637AbdDZCGB (ORCPT <rfc822;w@1wt.eu>);
        Tue, 25 Apr 2017 22:06:01 -0400
Received: from r00tworld.com ([212.85.137.150]:37299 "EHLO r00tworld.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1434621AbdDZCFy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Apr 2017 22:05:54 -0400
From: "PaX Team" <pageexec@freemail.hu>
To: linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Date: Wed, 26 Apr 2017 04:01:28 +0200
MIME-Version: 1.0
Subject: Re: [PATCH v2 0/2] x86, refcount: Implement fast refcount overflow
Reply-to: pageexec@freemail.hu
CC: Kees Cook <keescook@chromium.org>,
        Peter Zijlstra <peterz@infradead.org>, Jann Horn <jannh@google.com>,
        Eric Biggers <ebiggers3@gmail.com>,
        Christoph Hellwig <hch@infradead.org>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        James Bottomley <James.Bottomley@hansenpartnership.com>,
        Elena Reshetova <elena.reshetova@intel.com>,
        Hans Liljestrand <ishkamiel@gmail.com>,
        David Windsor <dwindsor@gmail.com>, "x86@kernel.org" <x86@kernel.org>,
        Ingo Molnar <mingo@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "David S. Miller" <davem@davemloft.net>,
        Rik van Riel <riel@redhat.com>,
        linux-arch <linux-arch@vger.kernel.org>,
        "kernel-hardening@lists.openwall.com" 
        <kernel-hardening@lists.openwall.com>
Message-ID: <58FFFF78.5586.1FBAC458@pageexec.freemail.hu>
In-reply-to: <1493160997-126108-1-git-send-email-keescook@chromium.org>
References: <1493160997-126108-1-git-send-email-keescook@chromium.org>
X-mailer: Pegasus Mail for Windows (4.72.572)
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7BIT
Content-description: Mail message body
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.1.12 (r00tworld.com [212.85.137.150]); Wed, 26 Apr 2017 04:01:29 +0200 (CEST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 25 Apr 2017 at 15:56, Kees Cook wrote:

> This protection is a modified version of the x86 PAX_REFCOUNT
> implementation from PaX/grsecurity. This speeds up the refcount_t API by
> duplicating the existing atomic_t implementation with a single instruction
> added to detect if the refcount has wrapped past INT_MAX (or below 0)
> resulting in a signed value.

'signed value' sounds somewhat ambiguous given that in C a signed type (such
as the one beneath refcount_t) can have both negative and positive values yet
you didn't mean the latter here i guess.

> Various differences from PaX:
> - uses "js" instead of "jo" to trap all signed results instead of just
>   under/overflow transitions

there're differences in my 4.11 port but this isn't one of them.