From: Quan Nguyen <quan@os.amperecomputing.com> To: minyard@acm.org Cc: Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>, Brendan Higgins <brendanhiggins@google.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Wolfram Sang <wsa@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, openipmi-developer@lists.sourceforge.net, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Open Source Submission <patches@amperecomputing.com>, Phong Vo <phong@os.amperecomputing.com>, "Thang Q . Nguyen" <thang@os.amperecomputing.com>, openbmc@lists.ozlabs.org Subject: Re: [PATCH v3 0/7] Add Aspeed SSIF BMC driver Date: Thu, 20 May 2021 21:23:04 +0700 [thread overview] Message-ID: <58adf982-bf9c-f706-68ed-c25be43a22fb@os.amperecomputing.com> (raw) In-Reply-To: <20210519123401.GG2921206@minyard.net> On 19/05/2021 19:34, Corey Minyard wrote: > On Wed, May 19, 2021 at 02:49:27PM +0700, Quan Nguyen wrote: >> This series add support for the Aspeed specific SSIF BMC driver which >> is to perform in-band IPMI communication with the host in management >> (BMC) side. >> >> v3: >> + Switched binding doc to use DT schema format [Rob] >> + Splited into generic ssif_bmc and aspeed-specific [Corey, Joel] >> + Removed redundant license info [Joel] >> + Switched to use traditional if-else [Joel] >> + Removed unused ssif_bmc_ioctl() [Joel] >> + Made handle_request()/complete_response() to return void [Joel] >> + Refactored send_ssif_bmc_response()/receive_ssif_bmc_request() [Corey] >> + Remove mutex [Corey] >> + Use spin_lock/unlock_irqsave/restore in callback [Corey] >> + Removed the unnecessary memset [Corey] >> + Switch to use dev_err() [Corey] >> + Combine mask/unmask two interrupts together [Corey] >> + Fixed unhandled Tx done with NAK [Quan] >> + Late ack'ed Tx done w/wo Ack irq [Quan] >> + Use aspeed-specific exported aspeed_set_slave_busy() when slave busy >> to fix the deadlock [Graeme, Philipp, Quan] >> + Clean buffer for last multipart read [Quan] >> + Handle unknown incoming command [Quan] >> >> v2: >> + Fixed compiling error with COMPILE_TEST for arc >> >> Quan Nguyen (7): >> i2c: i2c-core-smbus: Expose PEC calculate function for generic use > > Note that for this I2C-specific change, I will need acks from the I2C > maintainers to be able to include this in my tree. > >> ipmi: ssif_bmc: Add SSIF BMC driver >> i2c: aspeed: Fix unhandled Tx done with NAK > > For the aspeed changes, they don't really belong here, they belong in > the aspeed tree. I see that you need them for the device to work > correctly, though. I'll need acks from maintainers to include them. > Thanks for you information. Will separate these i2c-aspeed's patches into other independent series in next version. >> i2c: aspeed: Acknowledge Tx done w/wo ACK irq late >> i2c: aspeed: Add aspeed_set_slave_busy() >> ipmi: ssif_bmc: Add Aspeed SSIF BMC driver >> bindings: ipmi: Add binding for Aspeed SSIF BMC driver >> >> .../bindings/ipmi/aspeed-ssif-bmc.yaml | 33 + >> drivers/char/ipmi/Kconfig | 22 + >> drivers/char/ipmi/Makefile | 2 + >> drivers/char/ipmi/ssif_bmc.c | 605 ++++++++++++++++++ >> drivers/char/ipmi/ssif_bmc.h | 93 +++ >> drivers/char/ipmi/ssif_bmc_aspeed.c | 75 +++ >> drivers/i2c/busses/i2c-aspeed.c | 51 +- >> drivers/i2c/i2c-core-smbus.c | 12 +- >> include/linux/i2c.h | 1 + >> 9 files changed, 884 insertions(+), 10 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.yaml >> create mode 100644 drivers/char/ipmi/ssif_bmc.c >> create mode 100644 drivers/char/ipmi/ssif_bmc.h >> create mode 100644 drivers/char/ipmi/ssif_bmc_aspeed.c >> >> -- >> 2.28.0 >>
prev parent reply other threads:[~2021-05-20 14:23 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-19 7:49 Quan Nguyen 2021-05-19 7:49 ` [PATCH v3 1/7] i2c: i2c-core-smbus: Expose PEC calculate function for generic use Quan Nguyen 2021-06-25 15:02 ` Wolfram Sang 2021-05-19 7:49 ` [PATCH v3 2/7] ipmi: ssif_bmc: Add SSIF BMC driver Quan Nguyen 2021-05-19 12:30 ` Corey Minyard 2021-05-20 14:19 ` Quan Nguyen 2021-05-19 7:49 ` [PATCH v3 3/7] i2c: aspeed: Fix unhandled Tx done with NAK Quan Nguyen 2021-05-19 23:28 ` Joel Stanley 2021-05-20 11:28 ` Ryan Chen 2021-05-20 14:15 ` Quan Nguyen 2021-05-20 13:48 ` Quan Nguyen 2021-05-19 7:49 ` [PATCH v3 4/7] i2c: aspeed: Acknowledge Tx done w/wo ACK irq late Quan Nguyen 2021-05-19 23:43 ` Joel Stanley 2021-05-20 1:19 ` Guenter Roeck 2021-05-20 14:03 ` Quan Nguyen 2021-05-20 13:52 ` Quan Nguyen 2021-05-19 7:49 ` [PATCH v3 5/7] i2c: aspeed: Add aspeed_set_slave_busy() Quan Nguyen 2021-05-20 11:06 ` Ryan Chen 2021-05-20 14:10 ` Quan Nguyen 2021-05-21 6:09 ` Ryan Chen 2021-05-28 1:00 ` Quan Nguyen 2021-05-24 10:06 ` Ryan Chen 2021-05-24 10:20 ` Quan Nguyen 2021-05-24 10:36 ` Ryan Chen 2021-05-24 10:48 ` Quan Nguyen 2021-05-25 10:30 ` Ryan Chen 2021-05-28 0:53 ` Quan Nguyen 2021-05-28 2:57 ` Ryan Chen 2021-06-07 14:57 ` Graeme Gregory 2021-05-19 7:49 ` [PATCH v3 6/7] ipmi: ssif_bmc: Add Aspeed SSIF BMC driver Quan Nguyen 2021-05-19 7:49 ` [PATCH v3 7/7] bindings: ipmi: Add binding for " Quan Nguyen 2021-05-19 15:29 ` Rob Herring 2021-05-20 14:24 ` Quan Nguyen 2021-05-19 12:34 ` [PATCH v3 0/7] Add " Corey Minyard 2021-05-20 14:23 ` Quan Nguyen [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=58adf982-bf9c-f706-68ed-c25be43a22fb@os.amperecomputing.com \ --to=quan@os.amperecomputing.com \ --cc=andrew@aj.id.au \ --cc=benh@kernel.crashing.org \ --cc=brendanhiggins@google.com \ --cc=devicetree@vger.kernel.org \ --cc=joel@jms.id.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=minyard@acm.org \ --cc=openbmc@lists.ozlabs.org \ --cc=openipmi-developer@lists.sourceforge.net \ --cc=p.zabel@pengutronix.de \ --cc=patches@amperecomputing.com \ --cc=phong@os.amperecomputing.com \ --cc=robh+dt@kernel.org \ --cc=thang@os.amperecomputing.com \ --cc=wsa@kernel.org \ --subject='Re: [PATCH v3 0/7] Add Aspeed SSIF BMC driver' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).