From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] task_work: simplify the task_work_add() interface
Date: Thu, 10 Mar 2022 05:43:25 -0700 [thread overview]
Message-ID: <58c5f828-df7d-6698-e2d6-2a869e134dd4@kernel.dk> (raw)
In-Reply-To: <20220223072754.616027-1-hch@lst.de>
On 2/23/22 12:27 AM, Christoph Hellwig wrote:
> Provide a low-level task_work_add_nonotify interface that just adds
> the work to the list and open code the TWA_SIGNAL and TWA_NONE callers
> using it. task_work_add() itself now only handles the common TWA_RESUME
> case and can drop the notify argument.
Not sure this is much of a cleanup, and a potential fast case of
TWA_NONE will now still still set TIF_NOTIFY_RESUME. Also:
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 77b9c7e4793bf..94116a102dc61 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -9606,7 +9606,7 @@ static __cold void io_ring_exit_work(struct work_struct *work)
> ctx_node);
> /* don't spin on a single task if cancellation failed */
> list_rotate_left(&ctx->tctx_list);
> - ret = task_work_add(node->task, &exit.task_work, TWA_SIGNAL);
> + ret = task_work_add_nonotify(node->task, &exit.task_work);
> if (WARN_ON_ONCE(ret))
> continue;
This one is now no longer setting TIF_NOTIFY_SIGNAL.
If you want to get rid of the argument, why not just have separate
helpers? task_work_add_signal(), task_work_add_resume(),
task_work_add(). Setting TWA_RESUME unconditionally because it's the
common use case doesn't seem ideal.
--
Jens Axboe
next prev parent reply other threads:[~2022-03-10 12:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 7:27 [PATCH] task_work: simplify the task_work_add() interface Christoph Hellwig
2022-03-03 10:55 ` Christoph Hellwig
2022-03-10 7:05 ` Christoph Hellwig
2022-03-10 12:43 ` Jens Axboe [this message]
2022-03-10 14:27 ` Christoph Hellwig
2022-03-15 14:58 ` Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2022-01-04 7:24 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58c5f828-df7d-6698-e2d6-2a869e134dd4@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).