linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Rene Herman <rene.herman@keyaccess.nl>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [2.6.10-rc2+] ide1=ata66 -- OBSOLETE OPTION, WILL BE REMOVED SOON!
Date: Mon, 13 Dec 2004 22:47:32 +0100	[thread overview]
Message-ID: <58cb370e04121313473057143b@mail.gmail.com> (raw)
In-Reply-To: <41B36021.5050600@keyaccess.nl>

On Sun, 05 Dec 2004 20:23:13 +0100, Rene Herman
<rene.herman@keyaccess.nl> wrote:
> Hi Bart.

Hi,
 
> I see your 2004-11-01 IDE update:
> 
> http://lkml.org/lkml/2004/11/1/158
> 
> obsoleted the idex=ata66 option, saying that it "should be handled by
> host drivers needing it". As far as I can see, amd74xx does not handle this?
> 
> I do need a way to force an 80c cable on this AMD756 (ATA66 max) board,
> since the BIOS doesn't seem to be setting the cable bits correctly.

Ugh, I checked AMD datasheets and AMD756 doesn't support host
side cable detection.  Well, we can try doing disk side only for it.
[ ATi and ITE (in -ac kernels) drivers are also doing this. ]

--- amd74xx.c.orig	2004-11-02 14:17:14.000000000 +0100
+++ amd74xx.c	2004-12-13 22:41:50.406229168 +0100
@@ -344,10 +344,8 @@
 			break;
 
 		case AMD_UDMA_66:
-			pci_read_config_dword(dev, AMD_UDMA_TIMING, &u);
-			for (i = 24; i >= 0; i -= 8)
-				if ((u >> i) & 4)
-					amd_80w |= (1 << (1 - (i >> 4)));
+			/* no host side cable detection */
+			amd_80w = 0x03;
 			break;
 	}

  reply	other threads:[~2004-12-13 21:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-05 19:23 [2.6.10-rc2+] ide1=ata66 -- OBSOLETE OPTION, WILL BE REMOVED SOON! Rene Herman
2004-12-13 21:47 ` Bartlomiej Zolnierkiewicz [this message]
2004-12-14  6:51   ` Andre Hedrick
2004-12-14 16:15   ` Rene Herman
2004-12-15 23:52   ` Alan Cox
2004-12-16 14:29     ` Bartlomiej Zolnierkiewicz
2004-12-16 14:32       ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58cb370e04121313473057143b@mail.gmail.com \
    --to=bzolnier@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rene.herman@keyaccess.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).