From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Rashkae <rashkae@tigershaunt.com>
Cc: "Ville Syrjälä" <syrjala@sci.fi>,
"Ondrej Zary" <linux@rainbow-software.org>,
"Robert Hancock" <hancockr@shaw.ca>,
"Volker Kuhlmann" <list0570@paradise.net.nz>,
"Jens Axboe" <axboe@suse.de>,
linux-ide <linux-ide@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: ide-cd turning off DMA when verifying DVD-R
Date: Fri, 13 Jan 2006 15:16:51 +0100 [thread overview]
Message-ID: <58cb370e0601130616l25e0e25ai6b7d2025d9774eff@mail.gmail.com> (raw)
In-Reply-To: <20060113140618.GB12360@tigershaunt.com>
On 1/13/06, Rashkae <rashkae@tigershaunt.com> wrote:
> On Fri, Jan 13, 2006 at 10:19:17AM +0100, Bartlomiej Zolnierkiewicz wrote:
>
>
> > On 1/13/06, Volker Kuhlmann <list0570@paradise.net.nz> wrote:
> > > On Fri 13 Jan 2006 17:40:33 NZDT +1300, Robert Hancock wrote:
> > >
> > > > I'm thinking the IDE code is too aggressive in assuming that the failure
> > > > is because of a DMA problem and disabling it.. Most likely all that's
> > > > happening is the drive is taking a long time to complete the current
> > > > command.
> >
> > What actually happened is that normal command timed out
> > and because of that driver reset the device which caused
> > it to loose DMA:
> >
> > ->ide_atapi_error()
> > ->ide_do_reset()
> > ->pre_reset()
> > ->check_dma_crc()
> > ->__ide_dma_off()
> >
> > Somebody needs to investigate why __ide_dma_off() is called
> > et all and if we need to restore DMA after reset (don't count ATM
> > on me, I'm buried by bugreports). Ondrej, could you fill the bug at
> > http://bugzilla.kernel.org so we don't lose it?
>
> Shouldn't whether DMA is restored after reset be governed by keepsettings flag?
settings should always be preserved and keepsettings flag should die
> From the hdparm man page:
>
> -k Get/set the keep_settings_over_reset flag for the
> drive. When this flag is set, the driver will pre
> serve the -dmu options over a soft reset, (as done
> during the error recovery sequence).
>
> I was a little disapointed that this didn't work as advertised.
AFAIR (2.5/2.6 and probably 2.4 also) it never worked w.r.t. to DMA
as documented in hdparm manual.
Bartlomiej
next prev parent reply other threads:[~2006-01-13 14:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5ujmU-1UQ-665@gated-at.bofh.it>
[not found] ` <5uoqr-Qq-7@gated-at.bofh.it>
2006-01-13 4:40 ` ide-cd turning off DMA when verifying DVD-R Robert Hancock
2006-01-13 8:30 ` Volker Kuhlmann
2006-01-13 9:19 ` Bartlomiej Zolnierkiewicz
2006-01-13 13:03 ` Ondrej Zary
[not found] ` <58cb370e0601130121s2f6c0a26jda00ff64df197342@mail.gmail.com>
[not found] ` <20060113093818.GA22984@sci.fi>
[not found] ` <58cb370e0601130149g32323b4axbf0ac55f83ac9148@mail.gmail.com>
[not found] ` <20060113112510.GA23264@sci.fi>
2006-01-13 13:33 ` Fwd: " Bartlomiej Zolnierkiewicz
2006-01-13 14:24 ` Alan Cox
[not found] ` <20060113140618.GB12360@tigershaunt.com>
2006-01-13 14:16 ` Bartlomiej Zolnierkiewicz [this message]
2006-01-12 21:35 Ondrej Zary
2006-01-13 4:04 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e0601130616l25e0e25ai6b7d2025d9774eff@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=axboe@suse.de \
--cc=hancockr@shaw.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=list0570@paradise.net.nz \
--cc=rashkae@tigershaunt.com \
--cc=syrjala@sci.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).