From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161072AbWBNP5l (ORCPT ); Tue, 14 Feb 2006 10:57:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161101AbWBNP5k (ORCPT ); Tue, 14 Feb 2006 10:57:40 -0500 Received: from nproxy.gmail.com ([64.233.182.197]:21099 "EHLO nproxy.gmail.com") by vger.kernel.org with ESMTP id S1161072AbWBNP5j convert rfc822-to-8bit (ORCPT ); Tue, 14 Feb 2006 10:57:39 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=q5u1+b7Mb5hk+uvyCiCUHnCKukGUF2pTeNeZ18kXCFbULGrx67kKNYH32JT8pm194/fxspNthHotrWc39/ZCiyxNe8huH6eD1tvsjwuV1+DB+MAvq0Fwtg5duiJgtqsitrkU2CuWOlUnGwzijoh9oUoQu0/k4SM3LortJJVBSd4= Message-ID: <58cb370e0602140757r5b265f25wc9f1f2e44d5f075c@mail.gmail.com> Date: Tue, 14 Feb 2006 16:57:37 +0100 From: Bartlomiej Zolnierkiewicz To: Kumar Gala Subject: Re: RFC: Compact Flash True IDE Mode Driver Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <58cb370e0602130235h3ab521cep47584ee634e8fc7f@mail.gmail.com> <58cb370e0602130853s4ce767c6j57337a9587cc2963@mail.gmail.com> <9E02DAB4-8DCE-42AA-8F47-080636F78E4C@kernel.crashing.org> <58cb370e0602131221k60e23cffo480fbec812b6560e@mail.gmail.com> <4EAA9C9B-947B-493D-B3D9-CFA1EC0A71CA@kernel.crashing.org> <58cb370e0602131435u317d1f2fxec9f156328807e9e@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 2/14/06, Kumar Gala wrote: > >> Now I'm confused. If I understand the code, what I want is for the > >> "io_32bit" setting to have its RW field set to SETTING_READ, such > >> that drive->no_io_32bit can NOT be changed. Additionally, I want it > >> set to 1 if hwif->no_io_32bit is 1. > > > > Yes. > > > >> Are you saying that at the end of probe_hwif() I should iterate over > >> the drives for that hwif and set drive->no_io_32bit to 1 if hwif- > >>> no_io_32bit is 1? If so, can I do this in the last loop that > >> already exists that iterates over the drives? > > > > Well, no - this loop is for tuning and is already over-complicated. > > > >> Will I not also want to test hwif->no_io_32bit in idedisk_setup() to > >> ensure that it can only set driver->no_io_32bit to 0 if hwif- > >>> no_io32bit is 0? > > > > No, you want to move this code to ide-probe.c because of the > > reason given in my last mail: setting drive->no_io_32bit in ide-disk > > is too late w.r.t. ide_add_generic_settings(): > > > > init_gendisk()->hwif_init()->ide_add_generic_settings() > > > > so drive->no_io_32bit flag needs to be set earlier > > (probe_hwif() is OK). > > Will drive->id->dword_io be valid by the end of probe_hwif()? Yes. > > And yes, this IDE stuff is complicated... :) > > That it is ;) > > - kumar