From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161112AbWBNQYx (ORCPT ); Tue, 14 Feb 2006 11:24:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161118AbWBNQYx (ORCPT ); Tue, 14 Feb 2006 11:24:53 -0500 Received: from nproxy.gmail.com ([64.233.182.207]:55487 "EHLO nproxy.gmail.com") by vger.kernel.org with ESMTP id S1161117AbWBNQYw convert rfc822-to-8bit (ORCPT ); Tue, 14 Feb 2006 11:24:52 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Uq9C9x+yWlRm0ALzBRvh/ohYOpANYAya/8KBCqYIJfOsiMJL2pFRy4qseUTQlG5Vuf+j6WfS076aUVJBo8XIui0W2lra0P2619J4ZAwcJ/j6ZdfMrwCaGZxBEQ9jv+M7YNxKPCG46kiupN54+JytnNyBtsGwu8YXjGLGQZyK3Xc= Message-ID: <58cb370e0602140824p32991ba3sa5e731a1394c3fbe@mail.gmail.com> Date: Tue, 14 Feb 2006 17:24:50 +0100 From: Bartlomiej Zolnierkiewicz To: Kumar Gala Subject: Re: RFC: Compact Flash True IDE Mode Driver Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <58cb370e0602140757r5b265f25wc9f1f2e44d5f075c@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 2/14/06, Kumar Gala wrote: > If this looks good, I'll send a more official patch with an signed-off-by. Looks good but please add some description and Signed-off-by. Acked-by: Bartlomiej Zolnierkiewicz You can send final patch to akpm for inclusion into -mm. > - k > > diff --git a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c > index 09086b8..359f659 100644 > --- a/drivers/ide/ide-disk.c > +++ b/drivers/ide/ide-disk.c > @@ -977,8 +977,6 @@ static void idedisk_setup (ide_drive_t * > ide_dma_verbose(drive); > printk("\n"); > > - drive->no_io_32bit = id->dword_io ? 1 : 0; > - > /* write cache enabled? */ > if ((id->csfo & 1) || (id->cfs_enable_1 & (1 << 5))) > drive->wcache = 1; > diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c > index 427d1c2..1b7b4c5 100644 > --- a/drivers/ide/ide-probe.c > +++ b/drivers/ide/ide-probe.c > @@ -858,6 +858,15 @@ static void probe_hwif(ide_hwif_t *hwif) > } > } > } > + > + for (unit = 0; unit < MAX_DRIVES; ++unit) { > + ide_drive_t *drive = &hwif->drives[unit]; > + > + if (hwif->no_io_32bit) > + drive->no_io_32bit = 1; > + else > + drive->no_io_32bit = drive->id->dword_io ? 1 : 0; > + } > } > > static int hwif_init(ide_hwif_t *hwif); > diff --git a/include/linux/ide.h b/include/linux/ide.h > index a7fc4cc..8d2db41 100644 > --- a/include/linux/ide.h > +++ b/include/linux/ide.h > @@ -792,6 +792,7 @@ typedef struct hwif_s { > unsigned no_dsc : 1; /* 0 default, 1 dsc_overlap disabled */ > unsigned auto_poll : 1; /* supports nop auto-poll */ > unsigned sg_mapped : 1; /* sg_table and sg_nents are ready */ > + unsigned no_io_32bit : 1; /* 1 = can not do 32-bit IO ops */ > > struct device gendev; > struct completion gendev_rel_comp; /* To deal with device release() */