From: Paolo Bonzini <pbonzini@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Alexander Graf <graf@amazon.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [GIT PULL] KVM patches for Linux 6.1-rc2
Date: Tue, 25 Oct 2022 11:42:37 +0200 [thread overview]
Message-ID: <58d6167b-e1bd-df9f-5518-3173a9ab0581@redhat.com> (raw)
In-Reply-To: <CAHk-=wgL7sh-+6mPk7FGCFtjuh36fhOLNRTT0_4g3yd380P0+w@mail.gmail.com>
On 10/24/22 00:15, Linus Torvalds wrote:
>
> compat_ptr() also happens to get the address space right (ie it
> returns a "void __user *" pointer). But since the non-compat 'struct
> kvm_msr_filter_range' bitmap member doesn't get that right either
> (because it uses the same type for kernel pointers as for user
> pointers - ugly uglt), that isn't such a big deal. The kvm code
> clearly doesn't do proper user pointer typing, and just uses random
> casts instead.
In general KVM ioctl arguments very rarely have __user pointers in them,
so there's not much need for compat ioctls at all. KVM_GET_DIRTY_LOG
and KVM_CLEAR_DIRTY_LOG get it right, but this one indeed can be
improved with compat_ptr(). Will do for 6.2, thanks for the review.
Paolo
next prev parent reply other threads:[~2022-10-25 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-23 17:43 [GIT PULL] KVM patches for Linux 6.1-rc2 Paolo Bonzini
2022-10-23 22:15 ` Linus Torvalds
2022-10-25 9:42 ` Paolo Bonzini [this message]
2022-10-23 22:39 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58d6167b-e1bd-df9f-5518-3173a9ab0581@redhat.com \
--to=pbonzini@redhat.com \
--cc=graf@amazon.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).