From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751568AbcHXFcW (ORCPT ); Wed, 24 Aug 2016 01:32:22 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:21912 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750933AbcHXFcU (ORCPT ); Wed, 24 Aug 2016 01:32:20 -0400 X-AuditID: cbfec7f5-f792a6d000001302-24-57bd3101da9c Subject: Re: [PATCH v2 2/4] ARM: dts: exynos: Use 'hpd-gpios' instead of 'hpd-gpio' To: Milo Kim , Kukjin Kim , Krzysztof Kozlowski , David Airlie References: <1472005524-3489-1-git-send-email-woogyom.kim@gmail.com> <1472005524-3489-3-git-send-email-woogyom.kim@gmail.com> Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , Rob Herring , linux-arm-kernel@lists.infradead.org From: Andrzej Hajda Message-id: <58f9145c-9c01-33a8-f5cb-82955fa0e79c@samsung.com> Date: Wed, 24 Aug 2016 07:30:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <1472005524-3489-3-git-send-email-woogyom.kim@gmail.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDLMWRmVeSWpSXmKPExsVy+t/xq7qMhnvDDTqPilv0njvJZDH/yDlW iytf37NZvH5haNH/+DWzxdmmN+wWmx5fY7W4vGsOm8WM8/uYLFr3HmG3mDH5JZvF7cnT2Rx4 PHbOusvusWlVJ5vH9m8PWD3udx9n8ti8pN6jb8sqRo/Pm+QC2KO4bFJSczLLUov07RK4Mr6f u8JScJanYsqe/YwNjPu4uhg5OSQETCTuXH/LDmGLSVy4t56ti5GLQ0hgKaPE3hUToJznjBK3 HzWzgVQJC4RKvNx2hxkkISIwFSjRe4EVJCEkUC8xddcrsASzwEImib6NDSwgCTYBTYm/m2+C dfMK2Ek8aFrK2MXIwcEioCoxaU0iSFhUIELi1qqPjBAlghI/Jt8Da+UUcJXYtvQXG0g5s4C6 xJQpuSBhZgF5ic1r3jJPYBSYhaRjFkLVLCRVCxiZVzGKppYmFxQnpeca6RUn5haX5qXrJefn bmKExMnXHYxLj1kdYhTgYFTi4e0I2RMuxJpYVlyZe4hRgoNZSYR3p8recCHelMTKqtSi/Pii 0pzU4kOM0hwsSuK8M3e9DxESSE8sSc1OTS1ILYLJMnFwSjUwVqa7fLTe3No4uXfrXdEnFhOm +BgsZ2iVyvJL6D4QL/ZJI/fnecPW8k88ud+XpphJtt5tXNblsbenulIz2Orh23L9WU6H978R DfJ1f+/lmPD8QGvSxnb7Mq7HTtMn9lkKiHif0l3yT5eP8X/DCSujv9v/Rzyobc5Ml5q58d3L 9/O3n9i44eYjJZbijERDLeai4kQA99Lv448CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/24/2016 04:25 AM, Milo Kim wrote: > This patch enables getting a HPD GPIO descriptor quickly. > The exynos-hdmi driver uses "hpd" for HDMI hot plug detection. > > static int hdmi_resources_init(struct hdmi_context *hdata) > { > ... > hdata->hpd_gpio = devm_gpiod_get(dev, "hpd", GPIOD_IN); > ... > } > > This calls 'of_find_gpio()' and it generates the GPIO consumer ID by referring > GPIO suffix. So 'hpd-gpios' is preferred on getting a GPIO descriptor. > > However, if the device tree uses 'hpd-gpio', then the exynos-hdmi driver > always retries to get a GPIO descriptor because the first GPIO suffix is not > 'gpio' but 'gpios'. So you always see the debug message below. > > of_get_named_gpiod_flags: can't parse 'hpd-gpios' property of node '/soc/hdmi@14530000[0]' > > Use the preferred property, 'hpd-gpios' instead of 'hpd-gpio'. > > Acked-by: Rob Herring > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: David Airlie > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: devicetree@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Milo Kim I am not sure if this long Cc list is necessary. Anyway: Reviewed-by: Andrzej Hajda -- Regards Andrzej