From: Valdis.Kletnieks@vt.edu
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: silence GCC warning
Date: Fri, 05 Oct 2012 18:20:44 -0400 [thread overview]
Message-ID: <59004.1349475644@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Wed, 03 Oct 2012 09:23:36 +0200." <1349249016.1414.55.camel@x61.thuisdomein>
[-- Attachment #1: Type: text/plain, Size: 763 bytes --]
On Wed, 03 Oct 2012 09:23:36 +0200, Paul Bolle said:
> By the way, GCC doesn't warn if I add an early check whether 'val_count'
> is non-zero:
>
> diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
> index c241ae2..d41527b 100644
> --- a/drivers/base/regmap/regmap.c
> +++ b/drivers/base/regmap/regmap.c
> @@ -1171,6 +1171,8 @@ int regmap_raw_read(struct regmap *map, unsigned int reg, void *val,
> unsigned int v;
> int ret, i;
>
> + if (!val_count)
> + return -EINVAL;
> That is another way to silence GCC here.
That's probably a preferable approach - that way, if a bogus val_count gets
passed in, the caller will be informed of the fact. Which is a lot better than
just papering over the warning.
[-- Attachment #2: Type: application/pgp-signature, Size: 865 bytes --]
next prev parent reply other threads:[~2012-10-05 22:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 10:15 [PATCH] regmap: silence GCC warning Paul Bolle
2012-10-01 10:03 ` Mark Brown
2012-10-01 10:16 ` Paul Bolle
2012-10-01 10:19 ` Mark Brown
2012-10-01 10:32 ` Paul Bolle
2012-10-01 11:39 ` Mark Brown
2012-10-01 19:08 ` Paul Bolle
2012-10-01 19:11 ` Mark Brown
2012-10-03 0:11 ` Valdis.Kletnieks
2012-10-03 7:23 ` Paul Bolle
2012-10-03 11:06 ` Mark Brown
2012-10-05 22:20 ` Valdis.Kletnieks [this message]
2012-10-06 8:53 ` Mark Brown
2012-10-06 9:57 ` Paul Bolle
2012-10-08 1:14 ` Mark Brown
2012-10-08 20:06 ` [PATCH v2] " Paul Bolle
2012-10-12 6:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59004.1349475644@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).