From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S3000024AbdD2ICj (ORCPT ); Sat, 29 Apr 2017 04:02:39 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:5520 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1952613AbdD2IC3 (ORCPT ); Sat, 29 Apr 2017 04:02:29 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Sat, 29 Apr 2017 00:58:16 -0700 Message-ID: <59044881.7090901@nvidia.com> Date: Sat, 29 Apr 2017 13:32:09 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Matthias Kaehlcke , Liam Girdwood , Mark Brown , Rob Herring , "Mark Rutland" CC: , , "Douglas Anderson" , Brian Norris Subject: Re: [PATCH] regulator: Allow for asymmetric settling times References: <20170429000643.56407-1-mka@chromium.org> In-Reply-To: <20170429000643.56407-1-mka@chromium.org> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: BGMAIL104.nvidia.com (10.25.59.13) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 29 April 2017 05:36 AM, Matthias Kaehlcke wrote: > Some regulators have different settling times for voltage increases and > decreases. To avoid a time penalty on the faster transition extend the > settling time property to allow for different settings for upward and > downward transitions. > > Signed-off-by: Matthias Kaehlcke > --- > Dependencies (from broonie/regulator topic/settle): > - regulator: DT: Add settling time property for non-linear voltage change > - regulator: Add settling time for non-linear voltage transition > > Sorry for not bringing this up during the review of the 'settling time' > patch, I just came across it when looking to revive a similar change I > sent out some time ago (https://patchwork.kernel.org/patch/9332051/). > > Documentation/devicetree/bindings/regulator/regulator.txt | 11 ++++++++--- > drivers/regulator/core.c | 8 ++++++-- > drivers/regulator/of_regulator.c | 9 +++++++-- > include/linux/regulator/machine.h | 9 ++++++--- > 4 files changed, 27 insertions(+), 10 deletions(-) I think DT change and code change go in different patches. > diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt > index d18edb075e1c..f21fead1c802 100644 > --- a/Documentation/devicetree/bindings/regulator/regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/regulator.txt > @@ -21,9 +21,14 @@ Optional properties: > design requires. This property describes the total system ramp time > required due to the combination of internal ramping of the regulator itself, > and board design issues such as trace capacitance and load on the supply. > -- regulator-settling-time-us: Settling time, in microseconds, for voltage > - change if regulator have the constant time for any level voltage change. > - This is useful when regulator have exponential voltage change. > +- regulator-settling-time-up-us: Settling time, in microseconds, for voltage > + increase if the regulator needs a constant time to settle after voltage > + increases of any level. This is useful for regulators with exponential > + voltage changes. > +- regulator-settling-time-down-us: Settling time, in microseconds, for voltage > + decrease if the regulator needs a constant time to settle after voltage > + decreases of any level. This is useful for regulators with exponential > + voltage changes. Can we have regulator-settling-time-us also so if it is there then up/down same. If up/down different then separate properties can be used. Also in driver, if up/dn are not provided and only regulator-settling-time-us is provided then up/dn can take value from this property.