From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4314CC433EF for ; Mon, 25 Jul 2022 16:24:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236066AbiGYQYi (ORCPT ); Mon, 25 Jul 2022 12:24:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234315AbiGYQYf (ORCPT ); Mon, 25 Jul 2022 12:24:35 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD84317A8C; Mon, 25 Jul 2022 09:24:34 -0700 (PDT) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26PFs6FH009209; Mon, 25 Jul 2022 16:24:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=ASnxwFUYdxCyeDA2J9p5DdAuN8MhNlL3KDL6zyM2Cpk=; b=he0MdEPeoxfqV5UazktwFtDjH3/hdzlqEfgk++1LtDgClJGjRrxrGmhTCsLES15aYTjS KNbJQdGKCXOz2CDFfFJNSH2maylR9YfJcuEOU5+4h7vfWMd1KXJoGBTj+wiX0emark9o qvZZtMWF75E2oa5feRx2o+HGPfzkOHdk+3IMjtwb3P4xniPAwD4I5duO8nXV04QZJyka PeRNMGGR3fEGwhN0jpdbapwEamNVMLuYmhcSWzNmpDe0tWd4qkOPTJYqbVqgUgYfDuxV L6jV1O1RJhjbX6izbsZu8k33HYkvjlhoNKWpZnOxXQjiL+xYZ44O4LEc5Y5PwYLjU3DF ZQ== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3hg8k6vyxm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Jul 2022 16:24:20 +0000 Received: from nasanex01a.na.qualcomm.com ([10.52.223.231]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 26PGOJW9009169 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Jul 2022 16:24:19 GMT Received: from [10.110.113.144] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 25 Jul 2022 09:24:19 -0700 Message-ID: <5905e987-722a-885f-e37b-33d8dc63ceef@quicinc.com> Date: Mon, 25 Jul 2022 09:24:18 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support To: Avri Altman , Can Guo , "bvanassche@acm.org" , "stanley.chu@mediatek.com" , "adrian.hunter@intel.com" , "alim.akhtar@samsung.com" , "beanhuo@micron.com" , "quic_nguyenb@quicinc.com" , "quic_ziqichen@quicinc.com" , "linux-scsi@vger.kernel.org" , "kernel-team@android.com" CC: "James E.J. Bottomley" , "Martin K. Petersen" , Daejun Park , Jinyoung Choi , Kiwoong Kim , open list References: <1658214120-22772-1-git-send-email-quic_cang@quicinc.com> <1658214120-22772-2-git-send-email-quic_cang@quicinc.com> From: "Asutosh Das (asd)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: wgpv7XuJXaXEZPf3AE8IAp7sfvSYCJSe X-Proofpoint-ORIG-GUID: wgpv7XuJXaXEZPf3AE8IAp7sfvSYCJSe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-25_11,2022-07-25_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxlogscore=999 phishscore=0 spamscore=0 impostorscore=0 bulkscore=0 mlxscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207250066 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/23/2022 8:26 AM, Avri Altman wrote: >> + >> + /* sqen|size|cqid */ >> + ufsmcq_writel(hba, (1 << 31) | qsize | (i << 16), >> + MCQ_CFG_n(REG_SQATTR, i)); > So there is a 1X1 SQ-CQ topology. > Isn't that should be configurable? > > Thanks, > Avri The popular configuration appeared to be 1:1. Other configurations may be added as needed later, perhaps. -asd