From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E37CBC433FE for ; Mon, 25 Oct 2021 14:06:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C3CBB60F70 for ; Mon, 25 Oct 2021 14:06:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231512AbhJYOJL (ORCPT ); Mon, 25 Oct 2021 10:09:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:20838 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231335AbhJYOJJ (ORCPT ); Mon, 25 Oct 2021 10:09:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635170807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FblMqi74l2aNQDmIbjX/cagfl890xy4Kf5Rp2sw8Ik4=; b=iybnwA0ZadanTHPHXV9Sbz8JrJm508VE747MwvM0WjR6zQ0H7YDqd8ZruBnkQ8FFxyEkLe EgxdHniFGcd9Kn9JX9OlnRN8CIce0gmXIzCQlA1kEkpfoB6YZQAZlGvUeoCF65178Zytrj D7Zwzzcgb/nbyViN/FOhKcEzj6+6j48= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-431-1qEgo8EUMNONcrLdJb5Mlw-1; Mon, 25 Oct 2021 10:06:46 -0400 X-MC-Unique: 1qEgo8EUMNONcrLdJb5Mlw-1 Received: by mail-ed1-f72.google.com with SMTP id r25-20020a05640216d900b003dca3501ab4so9973304edx.15 for ; Mon, 25 Oct 2021 07:06:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=FblMqi74l2aNQDmIbjX/cagfl890xy4Kf5Rp2sw8Ik4=; b=jdnj2OPM2h0bE1T5aj+WjQsGKGOQ3nf5M3JMIfrG3I7p3ktD4d0QJqudBeW3COVXky mIlPE2YHUOyjugA0vRyhNmkWOuhwdspBINmEhaclHMJVHANhfJHykNRLTcoUNAbORyEP zXVFXIn2DfS0Ob7N3/Bb3BQ79HR84Y1oHnaeD2DADj+/48SqiSYh3wyOIUQzkSxDnuc5 k+07uNE10kRI5Tix8cskLwut5XOj3ZeqlQHKRPw6R4bFl2GSSHID3qEzZNJR4zST8ef3 L0JsVI8e/U8M6EszbJRdJ5q+uTcg15DzPnDQjFbzX+CRXRQxwXnVOJ4r8SAV4YHzmTjn h29A== X-Gm-Message-State: AOAM533uQadp5NUG+dFQgbFO/vjIRuUXTsal22CfhABGboyPlietXUyE ts2SLFX+3MgEzOkl6T2Y6XD7gymn/Mpg3TID4MiFr99BkfU7CoM3GYlbaBvSo7qV+fRxIYXlIBB xwqfSApzvxW2E7Sav0stgFpes X-Received: by 2002:a50:fb02:: with SMTP id d2mr11770138edq.100.1635170804934; Mon, 25 Oct 2021 07:06:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZ2X8dAbxM+1kv2smymvR7I3dtS7qD9GGOcFC9wjjp+md9MuSuvCzqRB05il5WqZEpIp8nlw== X-Received: by 2002:a50:fb02:: with SMTP id d2mr11770084edq.100.1635170804745; Mon, 25 Oct 2021 07:06:44 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id o3sm7472237eju.123.2021.10.25.07.06.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 07:06:44 -0700 (PDT) Message-ID: <591073c1-b520-21de-8573-ddb83950e9f1@redhat.com> Date: Mon, 25 Oct 2021 16:06:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 19/43] KVM: Add helpers to wake/query blocking vCPU Content-Language: en-US To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-20-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20211009021236.4122790-20-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/10/21 04:12, Sean Christopherson wrote: > diff --git a/arch/arm64/kvm/arch_timer.c b/arch/arm64/kvm/arch_timer.c > index 7e8396f74010..addd53b6eba6 100644 > --- a/arch/arm64/kvm/arch_timer.c > +++ b/arch/arm64/kvm/arch_timer.c > @@ -649,7 +649,6 @@ void kvm_timer_vcpu_put(struct kvm_vcpu *vcpu) > { > struct arch_timer_cpu *timer = vcpu_timer(vcpu); > struct timer_map map; > - struct rcuwait *wait = kvm_arch_vcpu_get_wait(vcpu); > > if (unlikely(!timer->enabled)) > return; > @@ -672,7 +671,7 @@ void kvm_timer_vcpu_put(struct kvm_vcpu *vcpu) > if (map.emul_ptimer) > soft_timer_cancel(&map.emul_ptimer->hrtimer); > > - if (rcuwait_active(wait)) > + if (kvm_vcpu_is_blocking(vcpu)) > kvm_timer_blocking(vcpu); > > /* So this trick is what you're applying to x86 too instead of using vmx_pre_block, I see. Paolo