From: Suman Anna <s-anna@ti.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>, <ohad@wizery.com>,
<bjorn.andersson@linaro.org>
Cc: <linux-remoteproc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] rpmsg: core: Add wildcard match for name service
Date: Thu, 26 Mar 2020 10:06:09 -0500 [thread overview]
Message-ID: <591bd727-32af-9ea2-8c46-98f46ee3711e@ti.com> (raw)
In-Reply-To: <20200310155058.1607-1-mathieu.poirier@linaro.org>
Hi Mathieu,
On 3/10/20 10:50 AM, Mathieu Poirier wrote:
> Adding the capability to supplement the base definition published
> by an rpmsg_driver with a postfix description so that it is possible
> for several entity to use the same service.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
So, the concern I have here is that we are retrofitting this into the
existing 32-byte name field, and the question is if it is going to be
enough in general. That's the reason I went with the additional 32-byte
field with the "rpmsg: add a description field" patch.
regards
Suman
> ---
> Changes for V2:
> - Added Arnaud's Acked-by.
> - Rebased to latest rproc-next.
>
> drivers/rpmsg/rpmsg_core.c | 20 +++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c
> index e330ec4dfc33..bfd25978fa35 100644
> --- a/drivers/rpmsg/rpmsg_core.c
> +++ b/drivers/rpmsg/rpmsg_core.c
> @@ -399,7 +399,25 @@ ATTRIBUTE_GROUPS(rpmsg_dev);
> static inline int rpmsg_id_match(const struct rpmsg_device *rpdev,
> const struct rpmsg_device_id *id)
> {
> - return strncmp(id->name, rpdev->id.name, RPMSG_NAME_SIZE) == 0;
> + size_t len = min_t(size_t, strlen(id->name), RPMSG_NAME_SIZE);
> +
> + /*
> + * Allow for wildcard matches. For example if rpmsg_driver::id_table
> + * is:
> + *
> + * static struct rpmsg_device_id rpmsg_driver_sample_id_table[] = {
> + * { .name = "rpmsg-client-sample" },
> + * { },
> + * }
> + *
> + * Then it is possible to support "rpmsg-client-sample*", i.e:
> + * rpmsg-client-sample
> + * rpmsg-client-sample_instance0
> + * rpmsg-client-sample_instance1
> + * ...
> + * rpmsg-client-sample_instanceX
> + */
> + return strncmp(id->name, rpdev->id.name, len) == 0;
> }
>
> /* match rpmsg channel and rpmsg driver */
>
next prev parent reply other threads:[~2020-03-26 15:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 15:50 [PATCH v2] rpmsg: core: Add wildcard match for name service Mathieu Poirier
2020-03-26 15:06 ` Suman Anna [this message]
2020-03-26 20:21 ` Mathieu Poirier
2020-03-26 20:42 ` Suman Anna
2020-03-26 22:01 ` Mathieu Poirier
2020-03-27 9:35 ` Arnaud POULIQUEN
2020-03-27 19:36 ` Mathieu Poirier
2020-04-07 23:07 ` Suman Anna
2020-04-08 15:59 ` Mathieu Poirier
2020-04-08 20:52 ` Suman Anna
2020-04-09 8:54 ` Arnaud POULIQUEN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=591bd727-32af-9ea2-8c46-98f46ee3711e@ti.com \
--to=s-anna@ti.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).