From: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
To: Amelie DELAUNAY <amelie.delaunay@st.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE <alexandre.torgue@st.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
Fabrice GASNIER <fabrice.gasnier@st.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH v6 0/3] Add USB role switch support to DWC2
Date: Thu, 24 Sep 2020 12:36:35 +0000 [thread overview]
Message-ID: <591f30b5-3d37-a077-957c-ea0ca7ae4fcb@synopsys.com> (raw)
In-Reply-To: <542ec140-fd49-04a1-bc66-e473858caa67@st.com>
On 9/24/2020 4:27 PM, Amelie DELAUNAY wrote:
> Gentle reminder on the whole series instead.
>
> Thanks,
> Amelie
>
> On 9/9/20 11:35 AM, Amelie DELAUNAY wrote:
>> When using usb-c connector (but it can also be the case with a micro-b
>> connector), iddig, avalid, bvalid, vbusvalid input signals may not be
>> connected to the DWC2 OTG controller.
>> DWC2 OTG controller features an overriding control of the PHY voltage
>> valid
>> and ID input signals.
>> So, missing signals can be forced using usb role from usb role switch
>> and
>> this override feature.
>>
>> This series adds support for usb role switch to dwc2, by using
>> overriding
>> control of the PHY voltage valid and ID input signals.
>>
>> It has been tested on stm32mp157c-dk2 [1], which has a Type-C connector
>> managed by a Type-C port controller, and connected to USB OTG
>> controller.
>>
>> [1]
>> https://urldefense.com/v3/__https://www.st.com/en/evaluation-tools/stm32mp157c-dk2.html__;!!A4F2R9G_pg!LArZ8m2rAg5r1gjIUgMe3YNtFeRB8li8yKNkU0n3UqbgNZADD96VXRTHT7BLT4o$
>>
>> Amelie Delaunay (3):
>> dt-bindings: usb: dwc2: add optional usb-role-switch property
>> usb: dwc2: override PHY input signals with usb role switch support
>> usb: dwc2: don't use ID/Vbus detection if usb-role-switch on
>> STM32MP15
>> SoCs
>> ---
>> Changes in v6:
>> - Select USB_ROLE_SWITCH if USB_DWC2, and not only if
>> USB_DWC2_DUAL_ROLE:
>> drd.c is built whatever DWC2 mode (DUAL, HOST, PERIPHERAL) as it
>> is used also
>> to detect attach/detach (so a-valid/b-valid sessions).
>> Changes in v5:
>> - Use device_property_read_bool instead of of_read_property_bool in
>> params.c
>> Changes in v4:
>> - Simplify call to dwc2_force_mode in drd.c
>> - Add error_drd label in probe error path in platform.c
>> Changes in v3:
>> - Fix build issue reported by kernel test robot in drd.c
>> Changes in v2:
>> - Previous DT patch already in stm32-next branch so removed from v2
>> patchset
>> "ARM: dts: stm32: enable usb-role-switch on USB OTG on
>> stm32mp15xx-dkx"
>> - DWC2 DT bindings update added
>> - Build issue reported by kernel test robot fixed
>> - Martin's comments taken into account
>> ---
>> .../devicetree/bindings/usb/dwc2.yaml | 4 +
>> drivers/usb/dwc2/Kconfig | 1 +
>> drivers/usb/dwc2/Makefile | 2 +-
>> drivers/usb/dwc2/core.h | 9 +
>> drivers/usb/dwc2/drd.c | 180 ++++++++++++++++++
>> drivers/usb/dwc2/gadget.c | 2 +-
>> drivers/usb/dwc2/params.c | 2 +-
>> drivers/usb/dwc2/platform.c | 20 +-
>> 8 files changed, 215 insertions(+), 5 deletions(-)
>> create mode 100644 drivers/usb/dwc2/drd.c
>>
Acked-by: Minas Harutyunyan <hminas@synopsys.com> for dwc2
prev parent reply other threads:[~2020-09-24 12:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 9:35 [PATCH v6 0/3] Add USB role switch support to DWC2 Amelie Delaunay
2020-09-09 9:35 ` [PATCH v6 1/3] dt-bindings: usb: dwc2: add optional usb-role-switch property Amelie Delaunay
2020-09-09 9:35 ` [PATCH v6 2/3] usb: dwc2: override PHY input signals with usb role switch support Amelie Delaunay
2020-09-24 12:08 ` Amelie DELAUNAY
2020-09-09 9:35 ` [PATCH v6 3/3] usb: dwc2: don't use ID/Vbus detection if usb-role-switch on STM32MP15 SoCs Amelie Delaunay
2020-09-24 12:27 ` [PATCH v6 0/3] Add USB role switch support to DWC2 Amelie DELAUNAY
2020-09-24 12:36 ` Minas Harutyunyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=591f30b5-3d37-a077-957c-ea0ca7ae4fcb@synopsys.com \
--to=minas.harutyunyan@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=amelie.delaunay@st.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).