From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936860AbdEWJ6U (ORCPT ); Tue, 23 May 2017 05:58:20 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:40621 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933487AbdEWJ6R (ORCPT ); Tue, 23 May 2017 05:58:17 -0400 X-AuditID: b6c32a59-f79bc6d0000079c4-ec-592407b6f748 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <592407B4.5040108@samsung.com> Date: Tue, 23 May 2017 18:58:12 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Enric Balletbo i Serra , MyungJoo Ham , Rob Herring Cc: Lee Jones , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Benson Leung , Olof Johansson Subject: Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out. In-reply-to: <3f4c4b85-e9db-0531-e3da-2e671a8fa750@collabora.com> X-Brightmail-Tracker: H4sIAAAAAAAAA01Se0hTcRjt533NcnWbml+Dat40UnRuc7NrZRRZXXohWdB6YDe9qLmH7G69 KHBJtowkE4rUyl6WUmQryuyJrRKxl6U9NJePwILqDysK6bG7W9R/5zuc8/Gdw6fAVDWkWpFv cwoOG29hyJH45TtxcYmXqRizrqM3nD048BRnj/oeEuzZrmbE+r/cRezTpmqS7XKfIdnW50Mk u/OGj5qt4KqKnuBc4+uTiPPW7ya57s7rJPesZQfBlV2qR9yQd2IGtUqYmSfwOYJDI9iy7Tn5 ttw0ZlFm1twsU4pOn6hPZacxGhtvFdKY9MUZifPzLYGrGM1G3uIKUBm8KDJJs2Y67C6noMmz i840ZrVeb9DqddO0BoNBa0xeO91gCkjWCXm1g7vIwprozXvvm4uQX12KQhVAG+HEwwuEjMfB 457zpIRV9CkEHb1QikYG8BCCR+deoVKkCBoqWmNlvhHBnuGGEMmgpMfCt4oeXNJg9CTwtRdI NEbHweDn/bis70HQ9vgNIevjofudO6jH6Vg4cGW8RJMB+tbgi+ANY+ho6PjWjyQcSa+Eq0e/ UtKeCLoEwbWBi4Q0YPRpBL7epqAjnF4HvhMPMAmH0nOgZscRJImAbqKgpb+CkhNMAO9tTIbp 8HKIk8OHw/v7lygZq2GPp5KSrbsQXKzuweXBg8Bf5/5TVzK0lrpD5JijYe/wQIi8VAmeEpUs 4aC8v/3P0jnw6MVzJDdRjcHb2tfYPqSp/K+8yn/lVf5XXg3C6tE4oVC05gqiqdCkFXmr6LLl arPtVi8Kfme8uRE9O7SsGdEKxIQpG89ONqsIfqO4xdqMQIExEcpyIsasUubwW7YKDnuWw2UR xGZkCnRfjqkjs+2BX7c5s/TGVJ3RlJKsS9azqUyUcmpd50oVncs7hQJBKBQcf30hilB1ERLr 1qd8KF4yKftnX1ntxIal3ZYpCV0j8KTQdxo/ZWxb+Gq4voVpuNm68Fzm6e0N4nH77sxtFWsG 2qvfpq7+GVbwPaYt6eXme2mjErHDHzclFB8ri5z3JSrd23mEcBWIG25zhGfJvh/lK65FzPjF lmjCihOq3LFtCyYs93yq7e+L8X9lcDGP18djDpH/DeGlnAGzAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsVy+t9jAd2t7CqRBjM/sFtMf3KZxWL+kXOs FmtuH2K0uP/1KKPF5V1z2CxuN65gszh1/TObReveI+wOHB6zGy6yeOy4u4TRY9OqTjaPO9f2 sHlcOdHE6tG3ZRWjx+dNcgHsUW42GamJKalFCql5yfkpmXnptkqhIW66FkoKeYm5qbZKEbq+ IUFKCmWJOaVAnpEBGnBwDnAPVtK3S3DLWPaina1ggWJF7/HIBsb7Ul2MHBwSAiYSk0+pdjFy ApliEhfurWcDsYUEtjFKLHiQA2LzCghK/Jh8jwWknFlAXuLIpWwIU11iypTcLkYuoOoHjBI3 JjWzQZRrSdx52QhWziKgKjFtuyRImA0ovP/FDbASfgFFias/HjOClIgKREh0n6gEGSMi0MYo cXL7RhaQGmaB5YwSM39WgtjCAgkSRxafZYbYNYdZ4tuGVYwgCU4BR4kFTfMYJzAKzkJy6SyE S2chXLqAkXkVI1dqQXFuem6xUYHRJkZgxG07rBWwg7HpXPQhRgEORiUe3hmuypFCrIllxZW5 hxglOJiVRHgnsqpECvGmJFZWpRblxxeV5qQWH2I0BXpuIrOUaHI+MBnklcQbmlgamRiYmRka GRibKYnzTgj8EiEkkJ5YkpqdmlqQWgTTx8TBKdXAqPNa82JEq5hRjfCH58dZplxfrtSht56z eU2F/Lu+Flmdz7/2CYq02BtU1N62WuM4IaXoIIud3euPOqfsi3bYuk5NTOCfkLf2P3t1r2n/ 98qW+o3K04WUBZiPW58LVrntfFq7cMbD3dttV3z9/PD3P02Lhimu2yfm1D8+nNFSF7DZcfY1 7e/PlFiKMxINtZiLihMBmgBC5s4CAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170523095813epcas5p1cc9e25d59949582d9917d92edb59cc8d X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170301112844epcas4p34012f1564f1145f8d8a8967f4fe9a821 X-RootMTR: 20170301112844epcas4p34012f1564f1145f8d8a8967f4fe9a821 References: <20170301111943.12170-1-enric.balletbo@collabora.com> <20170301111943.12170-2-enric.balletbo@collabora.com> <58B7C9BF.1040708@samsung.com> <58E44698.5020605@samsung.com> <59240507.1040005@samsung.com> <3f4c4b85-e9db-0531-e3da-2e671a8fa750@collabora.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 05월 23일 18:52, Enric Balletbo i Serra wrote: > > > On 23/05/17 11:46, Chanwoo Choi wrote: >> Hi Enric, >> >> On 2017년 04월 20일 19:16, Enric Balletbo i Serra wrote: >>> On 05/04/17 03:21, Chanwoo Choi wrote: >>>> Hi Enric, >>>> >>>> On 2017년 03월 02일 16:29, Chanwoo Choi wrote: >>>>> Hi, >>>>> >>>>> On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote: >>>>>> From: Benson Leung >>>>>> >>>>>> This is the driver for the USB Type C cable detection mechanism >>>>>> built into the ChromeOS Embedded Controller on systems that >>>>>> have USB Type-C ports. >>>>>> >>>>>> At present, this allows for the presence of display out, but in >>>>>> future, it may also be used to notify host and device type cables >>>>>> and the presence of power. >>>>>> >>>>>> Signed-off-by: Benson Leung >>>>>> Signed-off-by: Enric Balletbo i Serra >>>>>> --- >>>>>> Changes since v1: >>>>>> Requested by Chanwoo Choi >>>>>> - Rename files changing _ for - >>>>>> - Remove the unneeded blank line on bottom of header. >>>>>> - Remove kobject.h and cros_ec_commands.h includes. >>>>>> - Remove the debug message as is not necessary. >>>>>> - Use the tab for indentation instead of space for if sentence. >>>>>> - Define each variable on different lines when the variables should be >>>>>> initialized. >>>>>> - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now. >>>>>> - Add one blank line to split out between state and property setting. >>>>>> - Add the author information (header and module) >>>>>> >>>>>> Enric Balletbo >>>>>> - As Rob suggested to rename the compatible name to something indicating that >>>>>> is USB Type C related I also renamed the file names, extcon-cros-ec -> >>>>>> extcon-usbc-cros-ec, I think it's more clear. >>>>>> >>>>>> drivers/extcon/Kconfig | 7 + >>>>>> drivers/extcon/Makefile | 1 + >>>>>> drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++ >>>>>> include/linux/mfd/cros_ec_commands.h | 75 +++++++ >>>>>> 4 files changed, 498 insertions(+) >>>>>> create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c >>>>>> >>>>> >>>>> Looks good to me. >>>>> Acked-by: Chanwoo Choi >>>>> >>>>> I think this patch should be handled with patches[1]. >>>>> [1] https://lkml.org/lkml/2017/2/14/655 >>>>> >>>>> I think that one maintainer among following subsystems >>>>> (mfd, chrome h/w platform, rtc and extcon) >>>>> will apply their git repository, and then one maintainer >>>>> will send the pull request of immutable branch for these patches. >>>>> >>>> >>>> As I mentioned, these patch should be handled with related patches[1]. >>>> [1] https://lkml.org/lkml/2017/2/14/655 >>>> >>>> So, I can't apply these patch on extcon git because there is a merge conflict >>>> and we should handle these patches with immutable branch between subsystem maintainer. >>>> >>>> The v4.11-rc5 was released, if you want to apply this patch to the v4.12-rc1, >>>> please take care of these patches. >>>> >>> >>> CC'ied : Olof Johansson >>> >>> Olof, Benson, >>> >>> Could at least the following patch in this series [1] picked as soon as possible >>> if it's ok. >>> >>> 9630769 New [01/13] mfd: cros_ec: Add helper for event notifier >>> >>> This specific patch is blocking this and others like the rtc-cros-ec to land and >>> the series were send some time ago without received bad feedback. >>> >>> [1] https://lkml.org/lkml/2017/3/17/321 >>> >>> Many thanks, >>> Enric >> >> Maybe, you better to resend these patches based on v4.12-rcX. >> > > I did a week ago :) The patches were rebased on top of current linux-next, > waiting for the maintainers, hope will be accepted soon so we can unblock this > patch and the rtc patches. > > https://lkml.org/lkml/2017/5/16/478 > OK. This patch must need the immutable branch. I expect that some maintainer will make the immutable branch and then send pull request to other maintainer related to them. -- Best Regards, Chanwoo Choi Samsung Electronics