From: "Boehme, Markus" <markubo@amazon.de>
To: "sj38.park@gmail.com" <sj38.park@gmail.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"Foerster, Leonard" <foersleo@amazon.de>,
"guoju.fgj@alibaba-inc.com" <guoju.fgj@alibaba-inc.com>,
"brendanhiggins@google.com" <brendanhiggins@google.com>,
"riel@surriel.com" <riel@surriel.com>,
"greg@kroah.com" <greg@kroah.com>,
"Heyne, Maximilian" <mheyne@amazon.de>,
"david@redhat.com" <david@redhat.com>,
"rientjes@google.com" <rientjes@google.com>,
"linux-damon@amazon.com" <linux-damon@amazon.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"Gowans, James" <jgowans@amazon.com>,
"Park, Seongjae" <sjpark@amazon.de>,
"snu@zelle79.org" <snu@zelle79.org>,
"Jonathan.Cameron@Huawei.com" <Jonathan.Cameron@Huawei.com>,
"Sieber, Fernand" <sieberf@amazon.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"rppt@kernel.org" <rppt@kernel.org>,
"shuah@kernel.org" <shuah@kernel.org>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"zgf574564920@gmail.com" <zgf574564920@gmail.com>,
"mgorman@suse.de" <mgorman@suse.de>,
"amit@kernel.org" <amit@kernel.org>,
"fan.du@intel.com" <fan.du@intel.com>,
"minchan@kernel.org" <minchan@kernel.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"acme@kernel.org" <acme@kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"gthelen@google.com" <gthelen@google.com>,
"shakeelb@google.com" <shakeelb@google.com>,
"elver@google.com" <elver@google.com>,
"vdavydov.dev@gmail.com" <vdavydov.dev@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v30 12/13] mm/damon: Add user space selftests
Date: Thu, 17 Jun 2021 11:28:08 +0000 [thread overview]
Message-ID: <592c117d55bea3e5f97c49cbe9a79f0093e03dcb.camel@amazon.de> (raw)
In-Reply-To: <20210616073119.16758-13-sj38.park@gmail.com>
On Wed, 2021-06-16 at 07:31 +0000, SeongJae Park wrote:
> From: SeongJae Park <sjpark@amazon.de>
>
> This commit adds a simple user space tests for DAMON. The tests are
> using kselftest framework.
>
> Signed-off-by: SeongJae Park <sjpark@amazon.de>
> ---
> tools/testing/selftests/damon/Makefile | 7 ++
> .../selftests/damon/_chk_dependency.sh | 28 +++++++
> .../testing/selftests/damon/debugfs_attrs.sh | 75 +++++++++++++++++++
> 3 files changed, 110 insertions(+)
> create mode 100644 tools/testing/selftests/damon/Makefile
> create mode 100644 tools/testing/selftests/damon/_chk_dependency.sh
> create mode 100755 tools/testing/selftests/damon/debugfs_attrs.sh
>
> [...]
> diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh b/tools/testing/selftests/damon/debugfs_attrs.sh
> new file mode 100755
> index 000000000000..60342d6c86d8
> --- /dev/null
> +++ b/tools/testing/selftests/damon/debugfs_attrs.sh
> @@ -0,0 +1,75 @@
> +#!/bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +
> +test_write_result() {
> + file=$1
> + content=$2
> + orig_content=$3
> + expect_reason=$4
> + expected=$5
> +
> + echo "$content" > "$file"
> + if [ $? -ne "$expected" ]
> + then
> + echo "writing $content to $file doesn't return $expected"
> + echo "expected because: $expect_reason"
> + echo "$orig_content" > "$file"
> + exit 1
> + fi
> +}
> +
> +test_write_succ() {
> + test_write_result "$1" "$2" "$3" "$4" 0
> +}
> +
> +test_write_fail() {
> + test_write_result "$1" "$2" "$3" "$4" 1
> +}
> +
> +test_content() {
> + file=$1
> + orig_content=$2
> + expected=$3
> + expect_reason=$4
> +
> + content=$(cat "$file")
> + if [ "$content" != "$content" ]
That'll always evaluate false and should compare against "expected"
instead.
> + then
> + echo "reading $file expected $expected but $content"
> + echo "expected because: $expect_reason"
> + echo "$orig_content" > "$file"
> + exit 1
> + fi
> +}
>
> [...]
Otherwise looking good.
Best regards,
Markus
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
next prev parent reply other threads:[~2021-06-17 11:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 7:31 [PATCH v30 00/13] Introduce Data Access MONitor (DAMON) SeongJae Park
2021-06-16 7:31 ` [PATCH v30 01/13] mm: " SeongJae Park
2021-06-16 7:31 ` [PATCH v30 02/13] mm/damon/core: Implement region-based sampling SeongJae Park
2021-06-16 7:31 ` [PATCH v30 03/13] mm/damon: Adaptively adjust regions SeongJae Park
2021-06-16 7:31 ` [PATCH v30 04/13] mm/idle_page_tracking: Make PG_idle reusable SeongJae Park
2021-06-16 7:31 ` [PATCH v30 05/13] mm/damon: Implement primitives for the virtual memory address spaces SeongJae Park
2021-06-16 7:31 ` [PATCH v30 06/13] mm/damon: Add a tracepoint SeongJae Park
2021-06-16 7:31 ` [PATCH v30 07/13] mm/damon: Implement a debugfs-based user space interface SeongJae Park
2021-06-16 7:31 ` [PATCH v30 08/13] mm/damon/dbgfs: Export kdamond pid to the user space SeongJae Park
2021-06-16 7:31 ` [PATCH v30 09/13] mm/damon/dbgfs: Support multiple contexts SeongJae Park
2021-06-16 7:31 ` [PATCH v30 10/13] Documentation: Add documents for DAMON SeongJae Park
2021-06-17 11:07 ` Boehme, Markus
2021-06-16 7:31 ` [PATCH v30 11/13] mm/damon: Add kunit tests SeongJae Park
2021-06-16 7:31 ` [PATCH v30 12/13] mm/damon: Add user space selftests SeongJae Park
2021-06-17 11:28 ` Boehme, Markus [this message]
2021-06-17 11:29 ` Boehme, Markus
2021-06-17 11:35 ` SeongJae Park
2021-06-16 7:31 ` [PATCH v30 13/13] MAINTAINERS: Update for DAMON SeongJae Park
2021-06-17 11:10 ` Boehme, Markus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=592c117d55bea3e5f97c49cbe9a79f0093e03dcb.camel@amazon.de \
--to=markubo@amazon.de \
--cc=Jonathan.Cameron@Huawei.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=amit@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=dwmw@amazon.co.uk \
--cc=elver@google.com \
--cc=fan.du@intel.com \
--cc=foersleo@amazon.de \
--cc=greg@kroah.com \
--cc=gthelen@google.com \
--cc=guoju.fgj@alibaba-inc.com \
--cc=jgowans@amazon.com \
--cc=linux-damon@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mheyne@amazon.de \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=sieberf@amazon.com \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
--cc=snu@zelle79.org \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=zgf574564920@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).