From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751530AbdFHBW1 (ORCPT ); Wed, 7 Jun 2017 21:22:27 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:13643 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbdFHBWZ (ORCPT ); Wed, 7 Jun 2017 21:22:25 -0400 X-AuditID: b6c32a59-f79bc6d0000079c4-b0-5938a6cee70c MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <5938A6CC.8030206@samsung.com> Date: Thu, 08 Jun 2017 10:22:20 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , MyungJoo Ham , Kyungmin Park , Kukjin Kim , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] devfreq: exynos-ppmu: Staticize event list In-reply-to: <20170607181228.32102-1-krzk@kernel.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmk+LIzCtJLcpLzFFi42LZdlhTXffcMotIg92fmC36H79mtjh/fgO7 xdmmN+wWmx5fY7W4vGsOm8Xn3iOMFjPO72OyuN24gs2Bw2PTqk42j81L6j36tqxi9Pi8SS6A JSrVJiM1MSW1SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwfoCiWF ssScUqBQQGJxsZK+nU1RfmlJqkJGfnGJrVK0oaGRnqGBuZ6RkZGeiXGslZEpUElCasbRr1OZ C/ayV7xb/ZSlgbGfrYuRk0NCwETixv1OKFtM4sK99UA2F4eQwFJGiZtzZzKCJIQEPjNKXNob 2MXIAdaw8w47RM1aRonZZ56A1fAKCEr8mHyPBaSGWUBe4silbJAws4CmxNbd66Hq7zFKLNt8 lh2khldAS+L9XCaQGhYBVYnGPduYQWw2oPD+FzfA7uEXUJS4+uMx2HhRgQiJnfO/gc0REVjK JLGw/x07SEJYwF7iwYu5YHs5BUwlzn/MA6mREJjHLnHo/mIWiJtlJTYdYIYwXSRW/0iDeFdY 4tXxLewQtpREd8csdojWdkaJzXNAXgFxOhgl7q9sZIWoMpY41dXIBPEYn0Tv7ydMEEN5JTra hCBKPCQurVvOAmE7Shy5u5AJ4negOW/mfGGdwCg/Cym4ZiGCaxZScC1gZF7FKJZaUJybnlps WmCqV5yYW1yal66XnJ+7iRGcALUidzBemRl0iFGAg1GJh3eFgkWkEGtiWXFl7iFGCQ5mJRHe W/OAQrwpiZVVqUX58UWlOanFhxhNgcE9kVlKNDkfmJzzSuINTSwNTEzNjA2MDS0slcR5NVZe ixASSE8sSc1OTS1ILYLpY+LglGpgtPOrE1axz7UrPFDpe+yE4bzLtyS4eabr39knIHfX7oDp 1hyNYksl+2/+kaHsnrGx3lbHXhWf+lWRl73zvW0s18aUVwaL9jPoKb48ObH67tb5CuesD07b /kT2oPCpXReZ3vDOmmD9Yn39X54vScFvlP0Y32la/f+59+ecnxrqfOnzVtWmP9cSUmIpzkg0 1GIuKk4EAKSP0RaWAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEIsWRmVeSWpSXmKPExsVy+t9jQd2zyywiDVYtlrbof/ya2eL8+Q3s Fmeb3rBbbHp8jdXi8q45bBafe48wWsw4v4/J4nbjCjYHDo9NqzrZPDYvqffo27KK0ePzJrkA lig3m4zUxJTUIoXUvOT8lMy8dFul0BA3XQslhbzE3FRbpQhd35AgJYWyxJxSIM/IAA04OAe4 Byvp2yW4ZRz9OpW5YC97xbvVT1kaGPvZuhg5OCQETCR23mHvYuQEMsUkLtxbDxTm4hASWM0o 8WnhMhaQBK+AoMSPyfdYQOqZBeQljlzKBgkzC6hLTJq3iBmi/gGjxObLS9lBangFtCTez2UC qWERUJVo3LONGcRmAwrvf3GDDcTmF1CUuPrjMSNIuahAhET3iUqQMSICS5kkVkxbC7ZWWMBe 4sGLuSwQ87sYJbbtOQ52M6eAqcT5j3kTGAVmIbluFsJ1s5Bct4CReRUjV2pBcW56brFRgdEm RmD8bDusFbCDselc9CFGAQ5GJR7eADmLSCHWxLLiytxDjBIczEoivLfmAYV4UxIrq1KL8uOL SnNSiw8xmgJ9NJFZSjQ5HxjbeSXxhiaWRiYGZmaGRgbGZkrivBMCv0QICaQnlqRmp6YWpBbB 9DFxcEo1MEbfmqZ9M0HQ/Ola3l3mO37Hrs/v6Y1f9jZqDuvPl85Rthyud0rSG14ki18QLQ8/ sa11+V8ucfVNEV+f/DzrfXLeBo+qFHXmlw/zNzsa1q6S0mreXSDlvnbD3YJbx1/8SzwZ9Ngl Rb/5Vd6ZK7G/HOOm5L1acuBi4rOmN3vKnuqfO2NiHXv4d74SS3FGoqEWc1FxIgAuYm4mtQIA AA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170608012221epcas5p26cd5e0337c988cc557c9d52707c6c294 X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170607181258epcas2p4191204d7b3853ef0482d84df7a06589d X-RootMTR: 20170607181258epcas2p4191204d7b3853ef0482d84df7a06589d References: <20170607181228.32102-1-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 2017년 06월 08일 03:12, Krzysztof Kozlowski wrote: > The ppmu_events array is accessed only in this compilation unit so it > can be made static. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/devfreq/event/exynos-ppmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c > index 9b7350935b73..c68f3b5a10b5 100644 > --- a/drivers/devfreq/event/exynos-ppmu.c > +++ b/drivers/devfreq/event/exynos-ppmu.c > @@ -44,7 +44,7 @@ struct exynos_ppmu { > { "ppmu-event2-"#name, PPMU_PMNCNT2 }, \ > { "ppmu-event3-"#name, PPMU_PMNCNT3 } > > -struct __exynos_ppmu_events { > +static struct __exynos_ppmu_events { > char *name; > int id; > } ppmu_events[] = { > Looks good to me. Acked-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics