From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Luca Weiss <luca.weiss@fairphone.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH] arm64: dts: qcom: sm8350: fix BAM DMA crash and reboot
Date: Mon, 26 Jun 2023 15:24:04 +0200 [thread overview]
Message-ID: <593b3b3e-7613-734d-91a9-9a48bbe5a9da@linaro.org> (raw)
In-Reply-To: <7b909a56-1b3d-79fb-0286-b10117982dc3@linaro.org>
On 26/06/2023 14:46, Krzysztof Kozlowski wrote:
> On 26/06/2023 13:32, Luca Weiss wrote:
>> Hi Krzysztof,
>>
>> On Wed Jun 21, 2023 at 4:36 PM CEST, Krzysztof Kozlowski wrote:
>>> SM8350 HDK and MTP boards were silently dying and rebooting during BAM
>>> DMA probe:
>>>
>>> [ 1.574304] vreg_bob: Setting 3008000-3960000uV
>>> [ 1.576918] bam-dFormat: Log Type - Time(microsec) - Message -
>>> Optional Info
>>> Log Type: B - Since Boot(Power On Reset), D - Delta, S - Statistic
>>> S - QC_IMAGE_VERSION_STRING=BOOT.MXF.1.0-00637.1-LAHAINA-1
>>> S - IMAGE_VARIANT_STRING=SocLahainaLAA
>>> S - OEM_IMAGE_VERSION_STRING=crm-ubuntu77
>>> S - Boot Interface: UFS
>>>
>>> It seems that BAM DMA is locally controller (not by firmware) and
>>> requires proper initialization by the driver prior to use, at least on
>>> HDK8350 and MTP8350, but probably on all boards.
>>
>> Are you sure that the bam (and subsequent the qce) actually probes with
>> this change? From reading the code I don't see how the bam should probe
>> without either qcom,controlled-remotely or qcom,powered-remotely but no
>
> Why the binding does not require either this or that? Eh, buggy stuff...
>
>
>> clocks supplied. I think the probe just fails with this change, right?
>
> I will need to double check. I was happy enough to be able to boot my
> device instead of having crashes, but indeed it would be nice to fix it
> fully.
You were right and my patch is not correct. I checked downstream and
there are no clocks there. Therefore I assume something else is wrong here.
I will send v2 disabling this.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-06-26 13:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 14:36 [PATCH] arm64: dts: qcom: sm8350: fix BAM DMA crash and reboot Krzysztof Kozlowski
2023-06-21 14:37 ` Krzysztof Kozlowski
2023-06-26 10:52 ` Thorsten Leemhuis
2023-06-21 16:05 ` Konrad Dybcio
2023-06-22 13:50 ` Manivannan Sadhasivam
2023-06-26 11:32 ` Luca Weiss
2023-06-26 12:46 ` Krzysztof Kozlowski
2023-06-26 13:24 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=593b3b3e-7613-734d-91a9-9a48bbe5a9da@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).