From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751759AbdFNNiL (ORCPT ); Wed, 14 Jun 2017 09:38:11 -0400 Received: from mail-he1eur01on0063.outbound.protection.outlook.com ([104.47.0.63]:60450 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750717AbdFNNiJ (ORCPT ); Wed, 14 Jun 2017 09:38:09 -0400 From: Laurentiu Tudor To: Greg KH CC: "stuyoder@gmail.com" , "devel@driverdev.osuosl.org" , "arnd@arndb.de" , "marc.zyngier@arm.com" , Stuart Yoder , Roy Pledge , "linux-kernel@vger.kernel.org" , "agraf@suse.de" , Catalin Horghidan , Ioana Ciornei , "Thomas Gleixner" , Leo Li , Bharat Bhushan , Jason Cooper , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v7 10/10] staging: fsl-mc: move bus driver out of staging Thread-Topic: [PATCH v7 10/10] staging: fsl-mc: move bus driver out of staging Thread-Index: AQHS4GO2LbWaGeIRBU+cQyVZFtkTn6IinROAgAHJCAA= Date: Wed, 14 Jun 2017 13:38:04 +0000 Message-ID: <59413C3A.1010306@nxp.com> References: <20170608142855.10455-1-laurentiu.tudor@nxp.com> <20170608142855.10455-11-laurentiu.tudor@nxp.com> <20170613102215.GA5866@kroah.com> In-Reply-To: <20170613102215.GA5866@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linuxfoundation.org; dkim=none (message not signed) header.d=none;linuxfoundation.org; dmarc=none action=none header.from=nxp.com; x-originating-ip: [192.88.146.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR0401MB2558;7:o/W4inNO9aspxnUorjzUXaLi0Zc1IW4/cO6O1HcGi9Lz0FCw9qBgAsrJ5VpC9N2gFq43GHSW0XpLAXdX6qaGZXHB8MhgyN5FkE6QCjscJxcJqE8tYBy4l3sMGDVy083usdxFsZRD8zCK74WhpZnSb0u4e8eIWCbQj9wMrL5Lx5Zvhw277QBgyNGCwKgpCs++maqv+da/fxXjI5inB7PVxDJUJR4fT2/1f9lepzzreR7eoaVZW3XOPp4o8Z8FNdBHHHjphHLP/WOVnKJzWlpxG+JPY57mqjvQmpvy1uY2o1hkByqH6aYvRxqZQRuxMC6hOxu9WMbeobz4v7roBH7gTg== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(39850400002)(39410400002)(39450400003)(39400400002)(39840400002)(377454003)(24454002)(478600001)(8936002)(86362001)(33656002)(2900100001)(87266999)(54356999)(561944003)(2906002)(3660700001)(65816999)(99136001)(66066001)(3280700002)(8676002)(80316001)(76176999)(36756003)(50986999)(81166006)(189998001)(59896002)(5250100002)(54906002)(6512007)(39060400002)(53546009)(99286003)(6246003)(53936002)(6916009)(5660300001)(4326008)(2950100002)(7736002)(6116002)(3846002)(102836003)(6486002)(305945005)(6506006)(6436002)(229853002)(7416002)(14454004)(38730400002)(110136004)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB2558;H:VI1PR0401MB1856.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; x-ms-office365-filtering-correlation-id: 7e56e00b-6015-4286-11a2-08d4b32a9591 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:VI1PR0401MB2558; x-ms-traffictypediagnostic: VI1PR0401MB2558: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123564025)(20161123560025)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:VI1PR0401MB2558;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VI1PR0401MB2558; x-forefront-prvs: 033857D0BD spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="Windows-1252" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2017 13:38:04.3205 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2558 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5EDcFwG007294 Hi Greg, On 06/13/2017 01:22 PM, Greg KH wrote: > On Thu, Jun 08, 2017 at 05:28:55PM +0300, laurentiu.tudor@nxp.com wrote: >> From: Stuart Yoder >> >> Move the source files out of staging into their final locations: >> -include files in drivers/staging/fsl-mc/include go to include/linux/fsl >> -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip > > Why do you have so many different .h files? You should only need 1 > "external" one, and one "internal" one, right? Can you please work on > cleaning that up first? > So here's the list of headers, for quick reference. dpbp.h dpcon-cmd.h dpmng.h dprc.h mc-bus.h mc-cmd.h mc-sys.h mc.h And here's a proposal on how to reorganize them: - dpbp.h (together with dbbp.c) be left behind in staging as they are not used by the bus itself but by the drivers probing on this bus. They will be moved out of staging at a later time. - same for dpcon-cmd.h. Will handle it when we'll start work on getting dpcon.c & dpcon.h out of staging. - dprc.h contains APIs for handling mc-bus "device containers" that are managed by the mc-bus driver itself. I'd leave this as is, but i think i can make it private. - regarding the multiple mc*.h files, i'll see what it takes to refactor them in a mc-bus.h + mc-bus-private.h - dpmng.h merged in the public header Regarding the future plans for dpbp.h and dpcon.h, these expose common APIs used throughout all the drivers, so i think it makes sense to leave them as they are and, when their time comes, move them in the public include/linux/fsl. --- Thanks & Best Regards, Laurentiu