From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 105C3C43381 for ; Wed, 13 Mar 2019 01:40:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC476217F4 for ; Wed, 13 Mar 2019 01:40:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726783AbfCMBkj (ORCPT ); Tue, 12 Mar 2019 21:40:39 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4677 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726365AbfCMBkj (ORCPT ); Tue, 12 Mar 2019 21:40:39 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id ABBF65E459BFAD0C34FF; Wed, 13 Mar 2019 09:40:36 +0800 (CST) Received: from [127.0.0.1] (10.142.63.192) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.408.0; Wed, 13 Mar 2019 09:40:26 +0800 CC: , , , , , , , , , , , , , , , , , Mark Rutland , "Binghui Wang" Subject: Re: [PATCH v3 01/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY To: Rob Herring References: <20190302090505.65542-1-chenyu56@huawei.com> <20190302090505.65542-2-chenyu56@huawei.com> <20190312134525.GA9706@bogus> From: Chen Yu Message-ID: <594394e2-c399-39db-979a-fadb17ef28df@huawei.com> Date: Wed, 13 Mar 2019 09:40:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20190312134525.GA9706@bogus> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.63.192] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 2019/3/12 21:45, Rob Herring wrote: > On Sat, Mar 02, 2019 at 05:04:54PM +0800, Yu Chen wrote: >> This patch adds binding documentation for supporting the hi3660 usb >> phy on boards like the HiKey960. >> >> Cc: Rob Herring >> Cc: Mark Rutland >> Cc: John Stultz >> Cc: Binghui Wang >> Signed-off-by: Yu Chen >> --- >> v1: >> * Fix some format error as suggested by Rob. >> v2: >> * Change hi3660 usb PHY to hi3660 USB PHY >> v3: >> * Make device node a subnode of usb3_otg_bc register. >> --- >> --- >> .../devicetree/bindings/phy/phy-hi3660-usb3.txt | 28 ++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt >> >> diff --git a/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt >> new file mode 100644 >> index 000000000000..6096214a2bc6 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt >> @@ -0,0 +1,28 @@ >> +Hisilicon hi3660 USB PHY >> +----------------------- >> + >> +Required properties: >> +- compatible: should be "hisilicon,hi3660-usb-phy" >> +- #phy-cells: must be 0 >> +- hisilicon,pericrg-syscon: phandle of syscon used to control phy. >> +- hisilicon,pctrl-syscon: phandle of syscon used to control phy. >> +- hisilicon,usb3-otg-bc-syscon: phandle of syscon used to control phy. > > You can drop this as it is now just the parent node. > >> +- hisilicon,eye-diagram-param: parameter set for phy >> +Refer to phy/phy-bindings.txt for the generic PHY binding properties >> + >> +This is a subnode of usb3_otg_bc register node. >> + >> +Example: >> + usb3_otg_bc: usb3_otg_bc@ff200000 { >> + compatible = "syscon", "simple-mfd"; > > This node should have a specific compatible. > Do you mean I need write a specific driver for this node ? >> + reg = <0x0 0xff200000 0x0 0x1000>; >> + >> + usb-phy { >> + compatible = "hisilicon,hi3660-usb-phy"; >> + #phy-cells = <0>; >> + hisilicon,pericrg-syscon = <&crg_ctrl>; >> + hisilicon,pctrl-syscon = <&pctrl>; >> + hisilicon,usb3-otg-bc-syscon = <&usb3_otg_bc>; >> + hisilicon,eye-diagram-param = <0x22466e4>; >> + }; >> + }; >> -- >> 2.15.0-rc2 >> > > . > Thanks Yu Chen