From: kajoljain <kjain@linux.ibm.com>
To: James Clark <james.clark@arm.com>,
acme@kernel.org, john.garry@huawei.com, ak@linux.intel.com,
linux-perf-users@vger.kernel.org
Cc: Nick.Forrington@arm.com, Andrew.Kilroy@arm.com,
Will Deacon <will@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Leo Yan <leo.yan@linaro.org>, Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] perf tools: Enable strict JSON parsing
Date: Fri, 8 Oct 2021 16:56:55 +0530 [thread overview]
Message-ID: <5947c093-cff9-f70e-af20-75bc053edf5f@linux.ibm.com> (raw)
In-Reply-To: <e8752b2d-65a7-1ed8-3c68-30d9006261ba@arm.com>
On 10/8/21 3:32 PM, James Clark wrote:
>
>
> On 08/10/2021 08:43, kajoljain wrote:
>>
>>
>> On 10/7/21 4:35 PM, James Clark wrote:
>>> After a discussion on "[PATCH 1/4] perf vendor events: Syntax corrections in Neoverse N1 json",
>>> John Garry suggested that we can just modify the parser to make it more strict. Hopefully this will
>>> remove the need to apply any future JSON comma fixup commits.
>>>
>>> Applies on top of "[PATCH v2 1/3] perf vendor events: Syntax corrections in Neoverse N1 json" on
>>> perf/core.
>>>
>>> Also available at:
>>> git clone --branch james-json-parse-fix git@git.gitlab.arm.com:linux-arm/linux-jc.git
>>
>> Hi James,
>> Do we have any dependency patches on top of this patch series. I am
>> reviewing and testing it, but in both powerpc and x86 system I am
>> getting build issue. Not sure if I am missing something>
>> I am trying your changes on top of upstream perf.
>>
>> pmu-events/arch/test/test_soc/sys/uncore.json: json error Invalid
>> character inside JSON string
>
> Hi Kajol,
>
> A trailing comma was fixed in this file 3 weeks ago at b8b350a. Can you
> confirm if you have updated to get this commit on perf core?
>
> Alternately you could pull from my branch above which is up to date enough
> to include it.
Hi James,
Thanks for pointing it. Not getting build issue now.
>
> The file is in pmu-events/arch/test/ so I would expect it to fail on all platforms.
>
>> make[3]: *** [pmu-events/Build:18: pmu-events/pmu-events.c] Error 1
>> make[3]: *** Deleting file 'pmu-events/pmu-events.c'
>> make[2]: *** [Makefile.perf:667: pmu-events/pmu-events-in.o] Error 2
>> make[2]: *** Waiting for unfinished jobs....
>> make[1]: *** [Makefile.perf:238: sub-make] Error 2
>> make: *** [Makefile:70: all] Error 2
>>
>> Also, Is it possible to add line number along with file name while
>> showing this error `json error Invalid character inside JSON string`.
>> It might make it easy to fix.
>
> I can add a character number with the following fix if you think that would
> be good enough? A line number might be a bigger change and involve keeping
> track of newline characters.
Sure. I think then we can skip this change. Not sure if character
number will be helpful.
Patch-set looks good to me.
Reviewed-by Kajol Jain<kjain@linux.ibm.com>
Thanks,
Kajol Jain
>
> diff --git a/tools/perf/pmu-events/json.c b/tools/perf/pmu-events/json.c
> index 0544398d6e2d..41a14e1543bf 100644
> --- a/tools/perf/pmu-events/json.c
> +++ b/tools/perf/pmu-events/json.c
> @@ -99,7 +99,7 @@ jsmntok_t *parse_json(const char *fn, char **map, size_t *size, int *len)
> res = jsmn_parse(&parser, *map, *size, tokens,
> sz / sizeof(jsmntok_t));
> if (res != JSMN_SUCCESS) {
> - pr_err("%s: json error %s\n", fn, jsmn_strerror(res));
> + pr_err("%s: json error at character %u '%s'\n", fn, parser.pos, jsmn_strerror(res));
> goto error_free;
> }
> if (len)
>
>
> It prints this for the same error you have above>
> pmu-events/arch/test/test_soc/sys/uncore.json: json error at character 213 'Invalid character inside JSON string'
>
> Although funnily enough after re-introducing that extra comma it doesn't fail the build for me,
> it just prints the error message. But I may have noticed some dependency tracking issues around
> the json files.
>
> James
>
next prev parent reply other threads:[~2021-10-08 11:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 11:05 [PATCH 0/3] perf tools: Enable strict JSON parsing James Clark
2021-10-07 11:05 ` [PATCH 1/3] perf vendor-events: Fix all remaining invalid JSON files James Clark
2021-10-07 17:22 ` John Garry
2021-10-07 11:05 ` [PATCH 2/3] perf tools: Make the JSON parser more conformant when in strict mode James Clark
2021-10-07 17:52 ` Jiri Olsa
2021-10-08 10:08 ` James Clark
2021-10-08 13:12 ` Jiri Olsa
2021-10-08 18:56 ` Arnaldo Carvalho de Melo
2021-10-08 19:01 ` Arnaldo Carvalho de Melo
2021-10-07 11:05 ` [PATCH 3/3] perf tools: Enable strict JSON parsing James Clark
2021-10-07 23:51 ` [PATCH 0/3] " Andi Kleen
2021-10-08 7:43 ` kajoljain
2021-10-08 10:02 ` James Clark
2021-10-08 11:26 ` kajoljain [this message]
2021-10-08 19:00 ` Arnaldo Carvalho de Melo
2021-10-12 13:30 ` James Clark
2021-10-12 20:15 ` Arnaldo Carvalho de Melo
2021-10-13 16:57 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5947c093-cff9-f70e-af20-75bc053edf5f@linux.ibm.com \
--to=kjain@linux.ibm.com \
--cc=Andrew.Kilroy@arm.com \
--cc=Nick.Forrington@arm.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=namhyung@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).