From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933605AbcIFJeR convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Sep 2016 05:34:17 -0400
Received: from mout.kundenserver.de ([217.72.192.74]:60627 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754086AbcIFJeO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Sep 2016 05:34:14 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>, Hauke Mehrtens <hauke@hauke-m.de>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] bcma: use of_dma_configure() to set initial dma mask
Date: Tue, 06 Sep 2016 11:34:26 +0200
Message-ID: <5961451.eLRiX5Tibt@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <CACna6rza3U+X=cNXqvjB8fe1s+hP234cu405m3ObJBB=wQUcOQ@mail.gmail.com>
References: <1458207563-3453369-1-git-send-email-arnd@arndb.de> <CACna6rza3U+X=cNXqvjB8fe1s+hP234cu405m3ObJBB=wQUcOQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="UTF-8"
X-Provags-ID: V03:K0:zv4NT8A3j1PQpJQjy6wibBfmd2HZiCH37KsIcZy9r302AZQr68w
 DCXEqSF9Yb/oDebWOm2mBw16qSkSgtaQGolotsGUrIOTqFtd6nvFoViZohmuEZxxVFQgXLP
 CHq+im3oEw0p8aul1+sHHy+V92nBIkUx/y78GeoBnYikOUtAcp94dec7cAQAvNNVCwwDvkX
 7QVpJWL66IAaBala/5E/w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:4YiMskQII0I=:sNE0SQ02a4KtjW59fyn2z1
 kH9NkSF33AC3B8ej+U8V1LRsMMgjB7NOcJx/Nk6OnD/N/ZDqEuKp8wMjpPDirHSAIwhFkPKK+
 zUdcL5+6nABB5HAf8wfdjHO/nuct/QGZSDkmvE4bMikictTtPA3DCYtVYxUgZETF+WJkRMbyW
 q+gQFOjvJ5alMgvNeat69HV+LHZU7kHu7aX3prvAPi6AM6zNMukQNSxLPy8PISzEIWqMflyMt
 pUJXcPVcZIg15ORNQeDLT1DoFK2Lw4Cr6ajPYXb0Rh8i0GL6N7gW4g29aMuxd7WjMiheOq4MN
 aQ6yNRLLdk+a380Da3UM+5VMjZAZ2DmvGMEVm5WjScNU1STSkjGc4GZNIK/bks0FHWEWF9uZQ
 9l90/baJ6DFBfoGd1Agfv752g9dmeVu1o9guA9uhrk9bosmilmU8IHcWodPfLtXKs/4okuqQX
 jahjz7oGK/2qGLMpQSVYlkWgimEUYHC0hUENe/2TZZse8F9auZwe9oHBW7F4UBlXJs3mGJ+BM
 rM++eFZfSynfoqgBx47dsboCE66CodhHwC8zUMHhLehJ7s0GV5AHM+To3okCKB95VE2MhU4O7
 PoPBhTxuqEnFydGcp3ndx7fiWAx6oEiTWC8DfI5xg2mbp8TlRXoLDee7AtLqEKOsWdjYAW1/r
 9Qq0Fe+eT2OujeZZQPGCtXB5X46qxWllibynRfEKlfiDItSR1iIh0MjQvCZ84SubbOSnvK6q8
 hrmWTZTHMVJ4JGkP
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, September 5, 2016 11:34:14 PM CEST Rafał Miłecki wrote:
> On 17 March 2016 at 10:39, Arnd Bergmann <arnd@arndb.de> wrote:
> > While fixing another bug, I noticed that bcma manually sets up
> > a dma_mask pointer for its child devices. We have a generic
> > helper for that now, which should be able to cope better with
> > any variations that might be needed to deal with cache coherency,
> > unusual DMA address offsets, iommus, or limited DMA masks, none
> > of which are currently handled here.
> >
> > This changes the core to use the of_dma_configure(), like
> > we do for platform devices that are probed directly from
> > DT.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> I applied this patch and tested on BCM47081 based device. I still got
> bgmac working which surely uses DMA.

Thanks!

> There is only 1 ARM wireless SoC
> using bcma (BCM47198) but its WiFi core isn't supported by b43.
> 
> Any tips what else to test? SPI core/driver doesn't use DMA. Maybe
> NAND core does, but we don't use it.
> 

If there is nothing else using this, then the patch won't cause
a regression ;-)

	Arnd