linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lee.jones@linaro.org" <lee.jones@linaro.org>
Subject: Re: [RESEND PATCH v2] dt-bindings: bd718x7: Yamlify and add BD71850
Date: Mon, 6 Apr 2020 05:10:27 +0000	[thread overview]
Message-ID: <5963a34e3ebaada7cc6ec786f6f2342a7cc2a15c.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <CAL_JsqJ2VBDHSWViyvjEBckOqsMQVUdOGjABH0AT6LiaMnJx1Q@mail.gmail.com>

Morning Rob & Lee,

Lee already applied this to for-mfd-next. (The driver changes with
BD71850 compatible addition went in his tree too). I guess the right
thing to do is to send him an incremental patch for his for-mfd-next
branch? I'll do that - sorry for the trouble.

Best Regards,
	Matti

On Sat, 2020-04-04 at 11:30 -0600, Rob Herring wrote:
> On Sat, Apr 4, 2020 at 11:28 AM Rob Herring <robh+dt@kernel.org>
> wrote:
> > On Fri, Mar 20, 2020 at 3:42 AM Matti Vaittinen
> > <matti.vaittinen@fi.rohmeurope.com> wrote:
> > > Convert ROHM bd71837 and bd71847 PMIC binding text docs to yaml.
> > > Split
> > > the binding document to two separate documents (own documents for
> > > BD71837
> > > and BD71847) as they have different amount of regulators. This
> > > way we can
> > > better enforce the node name check for regulators. ROHM is also
> > > providing
> > > BD71850 - which is almost identical to BD71847 - main difference
> > > is some
> > > initial regulator states. The BD71850 can be driven by same
> > > driver and it
> > > has same buck/LDO setup as BD71847 - add it to BD71847 binding
> > > document and
> > > introduce compatible for it.
> > > 
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com
> > > >
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> > 
> > I did, but there's some dtc warnings that need to be fixed:
> > 
> > Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dts:23.17-30:
> > Warning (reg_format): /example-0/i2c/pmic@4b:reg: property has
> > invalid
> > length (4 bytes) (#address-cells == 2, #size-cells == 1)
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dt.yaml:
> > Warning (pci_device_reg): Failed prerequisite 'reg_format'
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dt.yaml:
> > Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dt.yaml:
> > Warning (simple_bus_reg): Failed prerequisite 'reg_format'
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dts:20.13-131.11:
> > Warning (i2c_bus_bridge): /example-0/i2c: incorrect #address-cells
> > for
> > I2C bus
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dts:20.13-131.11:
> > Warning (i2c_bus_bridge): /example-0/i2c: incorrect #size-cells for
> > I2C bus
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dt.yaml:
> > Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dt.yaml:
> > Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge'
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dt.yaml:
> > Warning (spi_bus_reg): Failed prerequisite 'reg_format'
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dts:21.25-130.15:
> > Warning (avoid_default_addr_size): /example-0/i2c/pmic@4b: Relying
> > on
> > default #address-cells value
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dts:21.25-130.15:
> > Warning (avoid_default_addr_size): /example-0/i2c/pmic@4b: Relying
> > on
> > default #size-cells value
> >  Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.example.dt.yaml:
> > Warning (unique_unit_address): Failed prerequisite
> > 'avoid_default_addr_size'
> 
> And also:
> 
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dts:23.17-30:
> Warning (reg_format): /example-0/i2c/pmic@4b:reg: property has
> invalid
> length (4 bytes) (#address-cells == 2, #size-cells == 1)
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dt.yaml:
> Warning (pci_device_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dt.yaml:
> Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dt.yaml:
> Warning (simple_bus_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dts:20.13-112.11:
> Warning (i2c_bus_bridge): /example-0/i2c: incorrect #address-cells
> for
> I2C bus
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dts:20.13-112.11:
> Warning (i2c_bus_bridge): /example-0/i2c: incorrect #size-cells for
> I2C bus
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dt.yaml:
> Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dt.yaml:
> Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge'
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dt.yaml:
> Warning (spi_bus_reg): Failed prerequisite 'reg_format'
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dts:21.25-111.15:
> Warning (avoid_default_addr_size): /example-0/i2c/pmic@4b: Relying on
> default #address-cells value
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dts:21.25-111.15:
> Warning (avoid_default_addr_size): /example-0/i2c/pmic@4b: Relying on
> default #size-cells value
> Documentation/devicetree/bindings/mfd/rohm,bd71847-
> pmic.example.dt.yaml:
> Warning (unique_unit_address): Failed prerequisite
> 'avoid_default_addr_size'

I believe these were already applied by Lee.



  reply	other threads:[~2020-04-06  5:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20  9:42 [RESEND PATCH v2] dt-bindings: bd718x7: Yamlify and add BD71850 Matti Vaittinen
2020-03-20 13:28 ` Lee Jones
2020-04-04 17:28 ` Rob Herring
2020-04-04 17:30   ` Rob Herring
2020-04-06  5:10     ` Vaittinen, Matti [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-02-26 11:47 Matti Vaittinen
2020-02-27 16:45 ` Mark Brown
2020-01-15  6:29 Matti Vaittinen
2020-02-06 12:42 ` Vaittinen, Matti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5963a34e3ebaada7cc6ec786f6f2342a7cc2a15c.camel@fi.rohmeurope.com \
    --to=matti.vaittinen@fi.rohmeurope.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mazziesaccount@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).