From: Lu Baolu <baolu.lu@linux.intel.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] usb: xhci: Add DbC support in xHCI driver
Date: Mon, 24 Jul 2017 11:59:22 +0800 [thread overview]
Message-ID: <5975709A.8070602@linux.intel.com> (raw)
In-Reply-To: <87pocu3wts.fsf@linux.intel.com>
Hi Felipe,
On 07/21/2017 06:31 PM, Felipe Balbi wrote:
> Hi,
>
> Lu Baolu <baolu.lu@linux.intel.com> writes:
>> +static void xhci_dbc_stop(struct xhci_hcd *xhci)
>> +{
>> + struct xhci_dbc *dbc = xhci->dbc;
>> +
>> + WARN_ON(!dbc);
>> +
>> + cancel_delayed_work_sync(&dbc->event_work);
>> +
>> + if (dbc->gs_port_num != GSPORT_INVAL) {
>> + gserial_disconnect(&dbc->gs_port);
>> + gserial_free_line(dbc->gs_port_num);
> why are you tying host stack to the gadget framework?
XHCI debug capability is actually a debug device gadget.
The hardware and firmware do everything of gadget work
and leave the interface to xHCI for enabling/disabling and
queuing transfer requests.
u_serial.c provides a generic layer between a USB gadget
and the TTY layer. I used it to avoid duplicating code.
>
> With this, you're forcing every single PC in the world to compile the
> gadget framework, that's a bit much don't you think?
>
Yes, you are right. Is it acceptable if I move u_serial.c from
the current place to drivers/usb/common?
Best regards,
Lu Baolu
next prev parent reply other threads:[~2017-07-24 3:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 8:52 [PATCH 0/3] usb: xhci: Add debug capability support in xhci Lu Baolu
2017-07-21 8:52 ` [PATCH 1/3] usb: xhci: Make some static functions global Lu Baolu
2017-07-21 8:52 ` [PATCH 2/3] usb: xhci: Add DbC support in xHCI driver Lu Baolu
2017-07-21 10:31 ` Felipe Balbi
2017-07-24 3:59 ` Lu Baolu [this message]
2017-07-21 8:52 ` [PATCH 3/3] usb: doc: Update document for USB3 debug port usage Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5975709A.8070602@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).