From: Dmitry Osipenko <digetx@gmail.com>
To: Rob Herring <robh@kernel.org>, David Heidelberg <david@ixit.cz>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
~okias/devicetree@lists.sr.ht, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: sound: nvidia,tegra-audio: Convert multiple txt bindings to yaml
Date: Thu, 25 Nov 2021 05:15:21 +0300 [thread overview]
Message-ID: <59a8095b-fa80-258f-f2d7-dc241bfae24a@gmail.com> (raw)
In-Reply-To: <YYBRTK9KGglu/s9m@robh.at.kernel.org>
01.11.2021 23:42, Rob Herring пишет:
>> Convert Tegra audio complex with the
>> * ALC5632
>> * MAX98090
>> * RT5640
>> * RT5677
>> * SGTL5000
>> * TrimSlice
>> * WM8753
>> * WM8903
>> * WM9712
>> codec to the YAML format.
> Perhaps say why they can all be combined.
>
> I don't think that really works because the properties which are valid
> varies. Specifically, the GPIO lines vary.
>
> Instead, define a schema with all the common properties and then
> reference it.
>
Those GPIO lines should be more board-specific, rather than
CODEC-specific. Yes, some of GPIO lines may be unrelated to a specific
CODEC, but practically it's not worth the effort to split this binding
because of a couple optional GPIOs, IMO. We actually considered the
variant with the reference that you're suggesting and decided that it
should be unnecessary.
Are you insisting that the binding needs to be split?
next prev parent reply other threads:[~2021-11-25 3:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 17:19 [PATCH] dt-bindings: sound: nvidia,tegra-audio: Convert multiple txt bindings to yaml David Heidelberg
2021-11-01 20:42 ` Rob Herring
2021-11-25 2:15 ` Dmitry Osipenko [this message]
2021-11-25 4:19 ` Dmitry Osipenko
2021-11-25 4:23 ` Dmitry Osipenko
2021-11-25 2:18 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59a8095b-fa80-258f-f2d7-dc241bfae24a@gmail.com \
--to=digetx@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=~okias/devicetree@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).