From: Kishon Vijay Abraham I <kishon@ti.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Tony Lindgren <tony@atomide.com>,
Rob Herring <robh+dt@kernel.org>
Cc: <nsekhar@ti.com>, <linux-omap@vger.kernel.org>,
<linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 3/7] mmc: sdhci: Add callback to set bus mode
Date: Thu, 17 Aug 2017 11:01:35 +0530 [thread overview]
Message-ID: <59b63873-0071-663b-0551-774887ddba90@ti.com> (raw)
In-Reply-To: <c561b463-bf4b-1ad1-e053-19cec6d8fc28@intel.com>
Adrian,
On Tuesday 15 August 2017 01:08 PM, Adrian Hunter wrote:
> On 07/08/17 19:01, Kishon Vijay Abraham I wrote:
>> Add callback to set bus mode in sdhci library so that the
>> controller driver can perform any bus mode specific configurations
>> in the callback function.
>
> A quirk isn't needed. Just hook ->set_ios() e.g.
>
> host->mmc_host_ops.set_ios = sdhci_omap_set_ios;
>
> Then sdhci_omap_set_ios() can call sdhci_set_ios() and then do the bus mode
> setting.
I'm not adding a quirk here.. but I got your point.
Thanks
Kishon
next prev parent reply other threads:[~2017-08-17 5:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 16:01 [RFC PATCH 0/7] mmc: Add OMAP SDHCI driver Kishon Vijay Abraham I
2017-08-07 16:01 ` [RFC PATCH 1/7] mmc: sdhci: Add quirk to indicate no CRC stripping in MMC_RSP_136 Kishon Vijay Abraham I
2017-08-15 7:27 ` Adrian Hunter
2017-08-17 5:20 ` Kishon Vijay Abraham I
2017-08-17 6:31 ` Adrian Hunter
2017-08-17 7:40 ` Kishon Vijay Abraham I
2017-08-07 16:01 ` [RFC PATCH 2/7] mmc: sdhci: Add quirk to indicate controller supports ADMA2 Kishon Vijay Abraham I
2017-08-15 7:33 ` Adrian Hunter
2017-08-17 5:30 ` Kishon Vijay Abraham I
2017-08-07 16:01 ` [RFC PATCH 3/7] mmc: sdhci: Add callback to set bus mode Kishon Vijay Abraham I
2017-08-15 7:38 ` Adrian Hunter
2017-08-17 5:31 ` Kishon Vijay Abraham I [this message]
2017-08-07 16:01 ` [RFC PATCH 4/7] mmc: sdhci: Add quirk to indicate broken POWER_CONTROL Kishon Vijay Abraham I
2017-08-15 7:41 ` Adrian Hunter
2017-08-17 5:32 ` Kishon Vijay Abraham I
2017-08-07 16:01 ` [RFC PATCH 5/7] dt-bindings: ti-omap-hsmmc: Document new compatible for sdhci omap Kishon Vijay Abraham I
2017-08-09 22:12 ` Tony Lindgren
2017-08-17 5:43 ` Kishon Vijay Abraham I
2017-08-17 16:05 ` Tony Lindgren
2017-08-07 16:01 ` [RFC PATCH 6/7] mmc: sdhci-omap: Add OMAP SDHCI driver Kishon Vijay Abraham I
2017-08-15 8:22 ` Adrian Hunter
2017-08-17 5:57 ` Kishon Vijay Abraham I
2017-08-17 6:43 ` Adrian Hunter
2017-08-17 7:59 ` Kishon Vijay Abraham I
2017-08-17 8:23 ` Adrian Hunter
2017-08-20 11:03 ` Kishon Vijay Abraham I
2017-08-07 16:01 ` [RFC PATCH 7/7] MAINTAINERS: Add TI OMAP SDHCI Maintainer Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59b63873-0071-663b-0551-774887ddba90@ti.com \
--to=kishon@ti.com \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).