From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00BEBC43463 for ; Fri, 18 Sep 2020 17:09:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BD8F2067D for ; Fri, 18 Sep 2020 17:09:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="NIrcTZCN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726332AbgIRRJu (ORCPT ); Fri, 18 Sep 2020 13:09:50 -0400 Received: from so254-54.mailgun.net ([198.61.254.54]:23230 "EHLO so254-54.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726239AbgIRRJu (ORCPT ); Fri, 18 Sep 2020 13:09:50 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1600448989; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=thyujIIB3eiKeskRUDzOVjH6lcM4CSCxYjc4gLe9/ZU=; b=NIrcTZCNQ0xrqojuf0/GDKxDroVSFVMWQ9VgV1U+ZbJ5mu6E+WVpRWWCj3kmiV4EX/LvBfah uaw8y45vU+NvKzJGfROJVg02X2AZg5o6MXeNxHg+4FEfOBRvJttMUOylwXN+2Oh6HYdRPsXK vOuCXBq9NuoNUAyfP+Hl3Wg3FzU= X-Mailgun-Sending-Ip: 198.61.254.54 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 5f64e99c4ab73023a70f57b3 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 18 Sep 2020 17:08:44 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 0E77EC433FE; Fri, 18 Sep 2020 17:08:44 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: bbhatt) by smtp.codeaurora.org (Postfix) with ESMTPSA id 86C4CC433CB; Fri, 18 Sep 2020 17:08:43 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 18 Sep 2020 10:08:43 -0700 From: bbhatt@codeaurora.org To: Randy Dunlap Cc: manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/3] bus: mhi: core: Introduce debugfs entries for MHI In-Reply-To: References: <1600381176-37604-1-git-send-email-bbhatt@codeaurora.org> <1600381176-37604-3-git-send-email-bbhatt@codeaurora.org> Message-ID: <59df7b450303542c498ff845ea171be4@codeaurora.org> X-Sender: bbhatt@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-09-17 16:36, Randy Dunlap wrote: > On 9/17/20 3:19 PM, Bhaumik Bhatt wrote: >> diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig >> index a8bd9bd..ae68347 100644 >> --- a/drivers/bus/mhi/Kconfig >> +++ b/drivers/bus/mhi/Kconfig >> @@ -12,3 +12,11 @@ config MHI_BUS >> communication protocol used by the host processors to control >> and communicate with modem devices over a high speed peripheral >> bus or shared memory. >> + >> +config MHI_BUS_DEBUG >> + bool "Debugfs support for the MHI bus" >> + depends on MHI_BUS && DEBUG_FS >> + help >> + Enable debugfs support for use with the MHI transport. Allows >> + reading and/or modifying some values within the MHI controller >> + for debug and test purposes. > > from Documentation/process/coding-style.rst: > > """For all of the Kconfig* configuration files throughout the source > tree, > the indentation is somewhat different. Lines under a ``config`` > definition > are indented with one tab, while help text is indented an additional > two > spaces.""" > > Several lines above use spaces instead of one tab... Thank you for pointing out. I will fix this.