From: lijiang <lijiang@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bhe@redhat.com,
dyoung@redhat.com, jgross@suse.com, dhowells@redhat.com,
Thomas.Lendacky@amd.com, ebiederm@xmission.com,
vgoyal@redhat.com, d.hatayama@fujitsu.com, horms@verge.net.au,
kexec@lists.infradead.org
Subject: Re: [PATCH 3/3 v9] kexec: Fix i386 build warnings that missed declaration of struct kimage
Date: Thu, 14 Nov 2019 22:20:42 +0800 [thread overview]
Message-ID: <59fbd119-495a-4d00-9738-98c22b276c1f@redhat.com> (raw)
In-Reply-To: <20191114123920.GA7222@zn.tnic>
在 2019年11月14日 20:39, Borislav Petkov 写道:
> On Fri, Nov 08, 2019 at 05:00:27PM +0800, Lianbo Jiang wrote:
>> Kbuild test robot reported some build warnings as follow:
>>
>> arch/x86/include/asm/crash.h:5:32: warning: 'struct kimage' declared
>> inside parameter list will not be visible outside of this definition
>> or declaration
>> int crash_load_segments(struct kimage *image);
>> ^~~~~~
>> int crash_copy_backup_region(struct kimage *image);
>> ^~~~~~
>> int crash_setup_memmap_entries(struct kimage *image,
>> ^~~~~~
>> The 'struct kimage' is defined in the header file include/linux/kexec.h,
>> before using it, need to include its header file or make a declaration.
>> Otherwise the above warnings may be triggered.
>>
>> Add a declaration of struct kimage to the file arch/x86/include/asm/
>> crash.h, that will solve these compile warnings.
>>
>> Fixes: dd5f726076cc ("kexec: support for kexec on panic using new system call")
>
> This is, of course, wrong. Your *first* patch is introducing those
> warnings and I'm wondering how did you not see them during building?
>
I really saw my building result, but kbuild reported the following messages:
vim +5 arch/x86/include/asm/crash.h
dd5f726076cc76 Vivek Goyal 2014-08-08 4
dd5f726076cc76 Vivek Goyal 2014-08-08 @5 int crash_load_segments(struct kimage *image);
dd5f726076cc76 Vivek Goyal 2014-08-08 6 int crash_copy_backup_region(struct kimage *image);
dd5f726076cc76 Vivek Goyal 2014-08-08 7 int crash_setup_memmap_entries(struct kimage *image,
dd5f726076cc76 Vivek Goyal 2014-08-08 8 struct boot_params *params);
89f579ce99f7e0 Yi Wang 2018-11-22 9 void crash_smp_send_stop(void);
dd5f726076cc76 Vivek Goyal 2014-08-08 10
:::::: The code at line 5 was first introduced by commit
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
:::::: dd5f726076cc7639d9713b334c8c133f77c6757a kexec: support for kexec on panic using new system call
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Would you mind giving me any suggestions about this?
> In file included from arch/x86/realmode/init.c:11:
> ./arch/x86/include/asm/crash.h:5:32: warning: ‘struct kimage’ declared inside parameter list will not be visible outside of this definition or declaration
> 5 | int crash_load_segments(struct kimage *image);
> | ^~~~~~
> ./arch/x86/include/asm/crash.h:6:37: warning: ‘struct kimage’ declared inside parameter list will not be visible outside of this definition or declaration
> 6 | int crash_copy_backup_region(struct kimage *image);
> | ^~~~~~
> ./arch/x86/include/asm/crash.h:7:39: warning: ‘struct kimage’ declared inside parameter list will not be visible outside of this definition or declaration
> 7 | int crash_setup_memmap_entries(struct kimage *image,
> |
>
>
> And that happens because you've included asm/crash.h in
> arch/x86/realmode/init.c and it of course complains because it hasn't
> seen that struct yet.
>
Exactly. Last time, i fixed the warnings in my first patch, please refer to the patch v8(resend).
Link: https://lkml.kernel.org/r/20191031033517.11282-2-lijiang@redhat.com
-[PATCH 1/2 RESEND v8] x86/kdump: always reserve the low 1M when the crashkernel option is specified
And kbuild said that need to add the reported-by, please refer to the following Link.
Link: https://lkml.kernel.org/r/201910310233.EJRtTMWP%25lkp@intel.com
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
Any idea about this? Any suggestions will be appreciated.
Thanks.
Lianbo
next prev parent reply other threads:[~2019-11-14 14:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 9:00 [PATCH 0/3 v9] x86/kdump: Fix 'kmem -s' reported an invalid freepointer when SME was active Lianbo Jiang
2019-11-08 9:00 ` [PATCH 1/3 v9] x86/kdump: always reserve the low 1M when the crashkernel option is specified Lianbo Jiang
2019-11-08 9:00 ` [PATCH 2/3 v9] x86/kdump: clean up all the code related to the backup region Lianbo Jiang
2019-11-08 9:00 ` [PATCH 3/3 v9] kexec: Fix i386 build warnings that missed declaration of struct kimage Lianbo Jiang
2019-11-14 12:39 ` Borislav Petkov
2019-11-14 14:20 ` lijiang [this message]
2019-11-14 14:43 ` Borislav Petkov
2019-11-15 0:18 ` lijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59fbd119-495a-4d00-9738-98c22b276c1f@redhat.com \
--to=lijiang@redhat.com \
--cc=Thomas.Lendacky@amd.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=d.hatayama@fujitsu.com \
--cc=dhowells@redhat.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).